Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3721378pxt; Tue, 10 Aug 2021 09:48:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw55MWrDMcnXUd0ty4JGMrZPQJcpFu7vZHs9RpA9mGOPVt1xV0JlUiIYM+tWZhsi++Ukg2y X-Received: by 2002:a17:906:aada:: with SMTP id kt26mr2655375ejb.199.1628614086802; Tue, 10 Aug 2021 09:48:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628614086; cv=none; d=google.com; s=arc-20160816; b=TFArjDIqozrtmtriRkk/q67E6dysPtnfIZFvLaOrBVKlce+h/3wR3Sau9EoFxM8id2 X2Na8a0TQr5XmrtysCVPhcb5uLdOBaozgoCXkf7UaizrHuEU83xiQXcwzMoW3B96vVAv VX5GTZZQYAjkS9elqEFCbKhpjG+EXFrbM91wZ9WgNJwBWQHXOf3nDSIPsiZ/6NTFieBx yrxdJXWpB++JnS27kSk+kKHs4aXkyHgtq2VBXsLwSy866MG6HC+129IRNpv45X2Ahp3j C2bgUgmrstd2uCq2ZHznVJaLN9qHy7XOytBGi1bnsZxYG33ANjHev3D8ozXbnEpqBgmX fqUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=xYaFzcIMw3qFmrYTgphte6/1PHFhObKrzlRtTshtz30=; b=bhF6qnpnaod9XZxb6mkATf+FuQq8oDu+4akMMZsdbUbBxz+f070XUS7/8nl3Yck15/ dbkO6ymyrs27VV8yF6yhjxKKMds0hwoukb1EAV1Pq1TBoXJkCSJJ31PZyV/bSOBV5OEo z3NxHiEnXmc5iotix57Q6b804MBxljAoMqwu6cReweyqHkQXL6cLQYTJjsaapNntHBeu FIDxUsPbvDXJ3q6HIUV0kfZUOo3e7hqnWUlb5Tbut7PMHq6Kto+Qhg7+lPvc0UUzb59C nupGOi4LtM10TBrLGdpCj5DBCIR9bjLufc/wRwr6Nqjb49MZq7l/ebb0WUx04LCjYo3m PWdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=qk8q7pku; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mq21si4249598ejc.409.2021.08.10.09.47.42; Tue, 10 Aug 2021 09:48:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=qk8q7pku; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232947AbhHJQIf (ORCPT + 99 others); Tue, 10 Aug 2021 12:08:35 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:49908 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232734AbhHJQI0 (ORCPT ); Tue, 10 Aug 2021 12:08:26 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B404921FF3; Tue, 10 Aug 2021 16:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628611683; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xYaFzcIMw3qFmrYTgphte6/1PHFhObKrzlRtTshtz30=; b=qk8q7pkuEJDBRmDi0XWjJiCMOBtUMgVD3VgPOsfacQ+7B0EzIvwE3AjBrQgr26JZBbr8HO UK7XZc74aeOTC/NpE8tXNfRwzQ90U04DGhk/vnycpDrYuX72GEFDabffdnhMT7c3ffEwNe JlmEc8SeRUlFPb78uk77QeBzLf91CTk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628611683; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xYaFzcIMw3qFmrYTgphte6/1PHFhObKrzlRtTshtz30=; b=/Rvwrz+U1xpku/2UomWswBRqPRzN8NIdIVSOHq1NPDYJpYLl5tCpTpX41ahErZY+hu1Mfd oNt2yf+ptmJzPGBw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 8BB4C137DA; Tue, 10 Aug 2021 16:08:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id Kyr4IGOkEmHUTAAAGKfGzw (envelope-from ); Tue, 10 Aug 2021 16:08:03 +0000 Subject: Re: [PATCH v14 022/138] mm/filemap: Add __folio_lock_or_retry() To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , William Kucharski References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-23-willy@infradead.org> From: Vlastimil Babka Message-ID: <984ee3c0-7189-3481-8a1f-9e2765906224@suse.cz> Date: Tue, 10 Aug 2021 18:08:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-23-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote: > Convert __lock_page_or_retry() to __folio_lock_or_retry(). This actually > saves 4 bytes in the only caller of lock_page_or_retry() (due to better > register allocation) and saves the 14 byte cost of calling page_folio() > in __folio_lock_or_retry() for a total saving of 18 bytes. Also use > a bool for the return type. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Reviewed-by: William Kucharski Acked-by: Vlastimil Babka Nit: > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1625,48 +1625,46 @@ static int __folio_lock_async(struct folio *folio, struct wait_page_queue *wait) > > /* > * Return values: > - * 1 - page is locked; mmap_lock is still held. > - * 0 - page is not locked. > + * true - folio is locked; mmap_lock is still held. > + * false - folio is not locked. > * mmap_lock has been released (mmap_read_unlock(), unless flags had both > * FAULT_FLAG_ALLOW_RETRY and FAULT_FLAG_RETRY_NOWAIT set, in > * which case mmap_lock is still held. > * > * If neither ALLOW_RETRY nor KILLABLE are set, will always return 1 s/1/true/ ? :) > - * with the page locked and the mmap_lock unperturbed. > + * with the folio locked and the mmap_lock unperturbed. > */ > -int __lock_page_or_retry(struct page *page, struct mm_struct *mm, > +bool __folio_lock_or_retry(struct folio *folio, struct mm_struct *mm, > unsigned int flags) > { > - struct folio *folio = page_folio(page); > - > if (fault_flag_allow_retry_first(flags)) { > /* > * CAUTION! In this case, mmap_lock is not released > * even though return 0. > */ > if (flags & FAULT_FLAG_RETRY_NOWAIT) > - return 0; > + return false; > > mmap_read_unlock(mm); > if (flags & FAULT_FLAG_KILLABLE) > folio_wait_locked_killable(folio); > else > folio_wait_locked(folio); > - return 0; > + return false; > } > if (flags & FAULT_FLAG_KILLABLE) { > - int ret; > + bool ret; > > ret = __folio_lock_killable(folio); > if (ret) { > mmap_read_unlock(mm); > - return 0; > + return false; > } > } else { > __folio_lock(folio); > } > > - return 1; > + return true; > } > > /**