Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3734550pxt; Tue, 10 Aug 2021 10:06:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwR1JtIwWQwlAlHuO3T/UddTrG81zHGrRWDTuezsvdYSVY6V1IUXlB1StvAM5jojfczCqUI X-Received: by 2002:a05:6402:1057:: with SMTP id e23mr6276426edu.352.1628615171121; Tue, 10 Aug 2021 10:06:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628615171; cv=none; d=google.com; s=arc-20160816; b=URIswTRa8tlXzFMEDy9V3249qGj3S/pbDv/Ugr9uIi7F1f6giBHrIUJJDJh5vPU04w PHKoDpu/PRid9bXLGtotP3q8USxl/zUz3VxuokQ5ocLBjvOZ/B/Xx5HYYZbPRbSOp0HT /1eYtblCCm/BYGl9UTfzQDqKjNmv3ZAwRwwBPUoEQEdqJseTG5ymAhsWCUxGdJKxRrMH eX8M1CtznpghNP0hx2nSIllY9h9v2V0nQCZV1zrByub6N5LIDHwVPM7TXkGxFivGQqTK 3y9j7b90/nxVYtcnxFIuSyeCy8GY/W7UdOFlVJBV+QXJefPnbJgjOW5eyR473FTHyhAm ddqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=94EOIQouGlTJAzq6iuzYMmH+XFfcFVkH7sLnkfJnBo0=; b=jrEJ3TCQrP5EbO+5J0tAvPwJtZFllB51rfPAxvUhXtUnvLQyfeh8CmU8feL6o9oiSU P1VFeNdL10p/DFHm0DLMm5sIoakNKLRIdWFHL7h0gzuLI61LBrlEtvxFzTCxQbIzNgHw IcY0jF4XAUriH0ELQFFc+Zet5/POPBhU3aXRnRJ7Pq5zvXgKpca7b1YV+S71pcKEDGTJ pJ6SOO8A3j6MG98Hh5OfxOMRJcTVDkok+KzYklP0MwFKw4uqTGSb6fpAfFIb2eDzCvjl VEyf8Bem5nQ3hF/qZv9jscS4XcTBF9n9bzngpIHHgYN+x+r3Nf1SE4y7tUTNVSl3s62A G7OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MTF7TXsz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e26si6911450edr.7.2021.08.10.10.05.44; Tue, 10 Aug 2021 10:06:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MTF7TXsz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbhHJRBx (ORCPT + 99 others); Tue, 10 Aug 2021 13:01:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229474AbhHJRBx (ORCPT ); Tue, 10 Aug 2021 13:01:53 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1533C0613C1 for ; Tue, 10 Aug 2021 10:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=94EOIQouGlTJAzq6iuzYMmH+XFfcFVkH7sLnkfJnBo0=; b=MTF7TXszk6Upk/7HLlum0qi7WA /74ci0UwiktZW0T1hRkkbXcuOhaJ803PCUHCPjXFYaau1xhgZNLmz7C1CnWwL8QCCfnQZYXiOXB7+ hAY1ljzWoXLDvz89Z8B6iZ15KJbk+DEvEosekAlXd+bx6S8GVzp4oqwm0ySEjJFgsDyS4iuxdHTJl HIJM5o1U7Pa6k9rP1YYg9x2gk8LkX6Ezm+oYMfGLDKm9ecHf3dCIKUWVFbnc7cx83apMah5dvgHP6 I6q2A/SMzbsOeboooJh+wWLv8RFS8Ek4nMWPCdHyS1fCRZgwMyTH0J8mAUvuIKRR9xkcWuF6NNOcd fHmBuDOg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDV72-00CN9P-4l; Tue, 10 Aug 2021 17:00:33 +0000 Date: Tue, 10 Aug 2021 18:00:24 +0100 From: Christoph Hellwig To: Maurizio Lombardi Cc: rppt@kernel.org, bp@alien8.de, tglx@linutronix.de, x86@kernel.org, pjones@redhat.com, konrad@kernel.org, george.kennedy@oracle.com, rafael@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3] iscsi_ibft: fix crash due to KASLR physical memory remapping Message-ID: References: <20210729135250.32212-1-mlombard@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729135250.32212-1-mlombard@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Fix this bug by saving the address of the physical location > of the ibft; later the driver will use isa_bus_to_virt() to get > the correct virtual address. That sound rather broken. Why not save the physical address in find_ibft_region and then later ioremap that when a virtual address is needed like all other code accessing magic I/O memory?