Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3736661pxt; Tue, 10 Aug 2021 10:08:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsrVTjiwVf1tyeOktjWtECI0IOoOSRtqmOOAAMMqmQBZyYdeJmni5U7/dWC7Kwg7mLR4ee X-Received: by 2002:a05:6e02:114e:: with SMTP id o14mr122666ill.121.1628615309694; Tue, 10 Aug 2021 10:08:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628615309; cv=none; d=google.com; s=arc-20160816; b=Dmxd/mmqjGXu/Y2GysGgQjOHUdxl1Z5la4E0+2T/JwZ8eyovSidVNl1ymV0McUulVH gq1b7hSaslgRyI1qD9bxT++O1+EaelhhdavIxC6Bzz2nM0kePpk7rPlPCyGTPXhnKkxa isD1zT08542G0CRvlm/0PTRRMjOMvw8aMSS/tHvk9aUSelRox4nt2jj9SVAC0JzL51wA aM8+OUbd3wF1BKK/uCvwinFepLDUauvtwlqAjy6bjIeMeMyZCP2cfKNXmP7JtGIOWXzh rKIM5w4fT/lnpI0wOuYo4g5qugIteleNI1bd9LET7uwzcKhJfcfFaTE4RrjaU1bbu2iY mvSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sXSNP++sReaSGRQyX++f3ew6IUcXPS+NrBDMsxe8cao=; b=EyRJmZ3Zpy/NHXMiapnnKM5JJ+hIqIX7SKCCzPTJ3wq8LCjk0IcTODGxX5FjKf2neU T49PaSv3c46SzqtwSQgsxXxdq/Tklz4tA6B503iETHNJHMIyloKvGL5fuLrmDBVcX4+P i/ZWEOguhcsnL+7ODNZlze+oTbGPGdftFx8feACUFFrOdVd+mWyHY9twMJvW4DjJ0uit Iizg4jxTzwktr11QyW1j9GgZTjnDDG4IqI7x1/J4HNrNafnkZDxu9R3+E3BLJuMMiuTM hsrAwhDtX/oHRyC/3y+75WQ9IfKjzyRQJ5MAopUfgx49xSNR4E/js+1OGgcQkqCd2Ubr fvLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U29ntLO8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r12si12552767jad.35.2021.08.10.10.08.18; Tue, 10 Aug 2021 10:08:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U29ntLO8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229743AbhHJRGe (ORCPT + 99 others); Tue, 10 Aug 2021 13:06:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:46252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbhHJRGe (ORCPT ); Tue, 10 Aug 2021 13:06:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6ABD5600EF; Tue, 10 Aug 2021 17:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628615171; bh=v/Z8K0cHbxfW2UPujBeHKC6ZbgjyhWPVFh7X3HNJV1c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U29ntLO8FtULlDO7gwSA+D9Ie2n/jNPsD2Ppc+6LT7sh/LQv0o04IZ3+xN/AxkaKf 18EXHB+Se6fbrxv1lyPojROhEdOOOvUzNvZYIsudGsoNCRKz8qFBCDMPlAvhXqhpO3 cwS8fGPo2v+KviYLmUz9diBmdwQzgAOw15rmdFaw= Date: Tue, 10 Aug 2021 19:06:09 +0200 From: Greg KH To: trix@redhat.com Cc: mdf@kernel.org, p.pisati@gmail.com, atull@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH] fpga: machxo2-spi: return an error on failure Message-ID: References: <20210810164036.922830-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210810164036.922830-1-trix@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 10, 2021 at 09:40:36AM -0700, trix@redhat.com wrote: > From: Tom Rix > > Reported problem > > drivers/fpga/machxo2-spi.c:229 machxo2_write_init() > warn: missing error code 'ret' > > drivers/fpga/machxo2-spi.c:316 machxo2_write_complete() > warn: missing error code 'ret' What reported this? What does it mean? Where was it reported? please be specific... thanks, greg k-h