Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3746901pxt; Tue, 10 Aug 2021 10:21:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwexniSVxDJU2dkzcyyjgScrdmOmt4ky7GynwORNljUPzpRxihNtYd0WW4qWylQ2r7J75g7 X-Received: by 2002:a92:d304:: with SMTP id x4mr212168ila.82.1628616060457; Tue, 10 Aug 2021 10:21:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628616060; cv=none; d=google.com; s=arc-20160816; b=OBqw4OMWOpJuQAnBRd2/pd4PRRmSAUXlNoireV1Gt9HwHPTWBvPCNniW835+X9vBOj VlIR9DbqNdCRYQcK1N/TDteLXIaVOW3QrCZ+xHQd49N8Qm+woK7nAKdeGgglDAuW4txG wZ4jJKcPeDJZPakevWsqfL8z7C4fq47r1kU7dfVVACSYOFcu97V1lH3OZuaXEixgwrkH mqU2/qj5HBBcFdBONswiOiZR8IKptmkREYb+w3jCpZ1nYzj8tilZUti3Y9CxmzGY2Qka ylpxNLi6ncyXhJfF+0dl4yudg/fBmq123I1FzPib2WGGd9TC8xKJJFFOJ+MDi9qwJU/a p5fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=73nwB+H/Gc5EpUEtTt+5UourBXEJEhmgmjgofq3FJ8g=; b=ctwFQG1FLKCU1htEwk0kVYDgmoBk0Jz0MrjbJARQwLoyYJn2LQVA0JzjXIsZDwhIiW cGJuK7rtEIzYn4Kz5C0aExSuAPKF4dBoTlwGa0lkunC7BaQsL6cHGZB0mRM3OSmyjD8l JBs8xVN3XysdZvguml+V9qn5W+nvlnjw+0HK/1fOqPfSP2rdkiC4BEEMrTZoGTgEIp8w 0gShYtM+EmLTIiEuKa5F2LNPTAwdK7pIe1sPfOuv2Uawrw3m/MWTwnwN1UUsWGhAH4lB amUgtTXKCdmtlr2TFMCKQfqLgTUHn4Y7F9EONBzTOylUSSIiKMukOUALNnxxOfik34Rj dkeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=UTKpNVCb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s13si23746866ilp.102.2021.08.10.10.20.48; Tue, 10 Aug 2021 10:21:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=UTKpNVCb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239270AbhHJJoJ (ORCPT + 99 others); Tue, 10 Aug 2021 05:44:09 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:5100 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S239092AbhHJJoE (ORCPT ); Tue, 10 Aug 2021 05:44:04 -0400 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17A9evor011042; Tue, 10 Aug 2021 02:43:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=73nwB+H/Gc5EpUEtTt+5UourBXEJEhmgmjgofq3FJ8g=; b=UTKpNVCbsPQpHFbypkk1LOwo7ya7pdKgwaDD4oGuRBhnHK+sAnKQRv3dQjckaUoTgmnY 5BCN4duB3EjmmmezWajw+G2m2IDESjFmdebi+bL5S/M+lOtsu8TrIvGnapx9M/0OP58O oI0zxUQAGT1nBp1563b/drFNm2b2HM3N5sEZ3EROug0UU/d5Flg66yUatC5fO0i45I3I oFqK4H3zA5mCWOaQHe0fbYHXoBwjpmx4I6hUS+25vBmdyy+1EBUxLBTc0e68TmQeYsbd ze5Od8DU6YU+ozvBYNC3G6T8rhwuoQwzJzUaBhCh4eeSWYqzTJRZRlTQEnZJjZzvwLCg sg== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com with ESMTP id 3abfu2hdn8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 10 Aug 2021 02:43:33 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 10 Aug 2021 02:43:32 -0700 Received: from bbhushan2.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 10 Aug 2021 02:43:29 -0700 From: Bharat Bhushan To: , , , , , CC: Bharat Bhushan Subject: [PATCH v2 4/4] perf/marvell: cn10k DDR perf event core ownership Date: Tue, 10 Aug 2021 15:13:07 +0530 Message-ID: <20210810094307.29595-5-bbhushan2@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210810094307.29595-1-bbhushan2@marvell.com> References: <20210810094307.29595-1-bbhushan2@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-ORIG-GUID: uUl1SUkLu2osK3avE2Ct2BXd5pJ0FeII X-Proofpoint-GUID: uUl1SUkLu2osK3avE2Ct2BXd5pJ0FeII X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-10_03:2021-08-06,2021-08-10 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As DDR perf event counters are not per core, so they should be accessed only by one core at a time. Select new core when previously owning core is going offline. Signed-off-by: Bharat Bhushan --- v1->v2: - No change drivers/perf/marvell_cn10k_ddr_pmu.c | 50 ++++++++++++++++++++++++++-- include/linux/cpuhotplug.h | 1 + 2 files changed, 49 insertions(+), 2 deletions(-) diff --git a/drivers/perf/marvell_cn10k_ddr_pmu.c b/drivers/perf/marvell_cn10k_ddr_pmu.c index 80f1441961d0..3bf810fe0cf5 100644 --- a/drivers/perf/marvell_cn10k_ddr_pmu.c +++ b/drivers/perf/marvell_cn10k_ddr_pmu.c @@ -130,6 +130,7 @@ struct cn10k_ddr_pmu { int active_events; struct perf_event *events[DDRC_PERF_NUM_COUNTERS]; struct hrtimer hrtimer; + struct hlist_node node; }; #define to_cn10k_ddr_pmu(p) container_of(p, struct cn10k_ddr_pmu, pmu) @@ -613,6 +614,24 @@ static enum hrtimer_restart cn10k_ddr_pmu_timer_handler(struct hrtimer *hrtimer) return HRTIMER_RESTART; } +static int cn10k_ddr_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node) +{ + struct cn10k_ddr_pmu *pmu = hlist_entry_safe(node, struct cn10k_ddr_pmu, + node); + unsigned int target; + + if (cpu != pmu->cpu) + return 0; + + target = cpumask_any_but(cpu_online_mask, cpu); + if (target >= nr_cpu_ids) + return 0; + + perf_pmu_migrate_context(&pmu->pmu, cpu, target); + pmu->cpu = target; + return 0; +} + static int cn10k_ddr_perf_probe(struct platform_device *pdev) { struct cn10k_ddr_pmu *ddr_pmu; @@ -666,20 +685,33 @@ static int cn10k_ddr_perf_probe(struct platform_device *pdev) hrtimer_init(&ddr_pmu->hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); ddr_pmu->hrtimer.function = cn10k_ddr_pmu_timer_handler; + cpuhp_state_add_instance_nocalls( + CPUHP_AP_PERF_ARM_MARVELL_CN10K_DDR_ONLINE, + &ddr_pmu->node); + ret = perf_pmu_register(&ddr_pmu->pmu, name, -1); if (ret) - return ret; + goto error; ddr_pmu->id = index++; pr_info("CN10K DDR PMU Driver for ddrc@%llx - id-%d\n", res->start, ddr_pmu->id); return 0; +error: + cpuhp_state_remove_instance_nocalls( + CPUHP_AP_PERF_ARM_MARVELL_CN10K_DDR_ONLINE, + &ddr_pmu->node); + return ret; } static int cn10k_ddr_perf_remove(struct platform_device *pdev) { struct cn10k_ddr_pmu *ddr_pmu = platform_get_drvdata(pdev); + cpuhp_state_remove_instance_nocalls( + CPUHP_AP_PERF_ARM_MARVELL_CN10K_DDR_ONLINE, + &ddr_pmu->node); + perf_pmu_unregister(&ddr_pmu->pmu); return 0; } @@ -702,12 +734,26 @@ static struct platform_driver cn10k_ddr_pmu_driver = { static int __init cn10k_ddr_pmu_init(void) { - return platform_driver_register(&cn10k_ddr_pmu_driver); + int ret; + + ret = cpuhp_setup_state_multi( + CPUHP_AP_PERF_ARM_MARVELL_CN10K_DDR_ONLINE, + "perf/marvell/cn10k/ddr:online", NULL, + cn10k_ddr_pmu_offline_cpu); + if (ret) + return ret; + + ret = platform_driver_register(&cn10k_ddr_pmu_driver); + if (ret) + cpuhp_remove_multi_state( + CPUHP_AP_PERF_ARM_MARVELL_CN10K_DDR_ONLINE); + return ret; } static void __exit cn10k_ddr_pmu_exit(void) { platform_driver_unregister(&cn10k_ddr_pmu_driver); + cpuhp_remove_multi_state(CPUHP_AP_PERF_ARM_MARVELL_CN10K_DDR_ONLINE); } module_init(cn10k_ddr_pmu_init); diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h index 47e13582d9fc..ce7f2740d7db 100644 --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -185,6 +185,7 @@ enum cpuhp_state { CPUHP_AP_PERF_ARM_QCOM_L3_ONLINE, CPUHP_AP_PERF_ARM_APM_XGENE_ONLINE, CPUHP_AP_PERF_ARM_CAVIUM_TX2_UNCORE_ONLINE, + CPUHP_AP_PERF_ARM_MARVELL_CN10K_DDR_ONLINE, CPUHP_AP_PERF_POWERPC_NEST_IMC_ONLINE, CPUHP_AP_PERF_POWERPC_CORE_IMC_ONLINE, CPUHP_AP_PERF_POWERPC_THREAD_IMC_ONLINE, -- 2.17.1