Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3761709pxt; Tue, 10 Aug 2021 10:42:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOJ++/0R9xcj+Jcjo9DJyHmppiX1NhtIwFROJ04tcrFMDFdEr5fmYqc31Q+msSfQEZEDlC X-Received: by 2002:a05:6402:70b:: with SMTP id w11mr2315985edx.189.1628617374020; Tue, 10 Aug 2021 10:42:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628617374; cv=none; d=google.com; s=arc-20160816; b=Ib1R8RDkA/Eq/x2oIk4zSWuQpynoniu1kR3UMd4aN9C4e5YSg6mTXJRO4TBZkljOkn 82dodTqUoFMg9xocwOQBUAjG7HPwa2bDUOkbsJaMwMg9uuglxZgDb3rOBK6t+9ioCxBA Z5YvKQMUn30ctEr4//qD+SvwSxXNWJJj99S2a2XvKzn0im7EVWUrDoyAflwLlMy6gqx2 I+lPA6aMJ2bNdQetHmgcMeHY9EKSXhSOLOvgLwKIcEHPHX9pu7WEXx13CrJUA96B9pJ7 JcBoZTnwgZ/ZR8+DbLRqrGK3DQhlrFvXWPX4aDyNKwLxANxDZTJwb1iSs037Rup0CnE7 RzLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nLOkZWUk1PSyeY8uQjBLDiRkglheYj2X50oIZ+/TA74=; b=Vc80Pc+F4V9ctYs5A3Xp6qWZzFotuL2sMdIONJl7Ms6KCYJ+M8mBW1gWG+EaeXQP8Z XS0P4R7DqKVfnAjExHHH81bWevS54Bierten01A0ll3hahDOz9zOpAclBA/tH7yURL4u ByHJpcEH0+zYnw2dW5Ww4N7+MOfowX/JxbOI5NJgGaKZYMzuVBfRewGciQEwRNtZXcIf +tn3q3TA4R2HzmNtBd3aB/mkVGy8Nma02/pa2uoG+DsUYEPAxz+QyVEHF7KDAIPE2OK1 85AYD14zrnCD+tJqvbwjYHQqZ2XdAd1ntmuVKjpwta+EC5569bQHxwvvKLuq7IM6DXCc o7wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1CQGFraX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v19si21499087edc.51.2021.08.10.10.42.30; Tue, 10 Aug 2021 10:42:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1CQGFraX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234086AbhHJRlZ (ORCPT + 99 others); Tue, 10 Aug 2021 13:41:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:44144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234793AbhHJRiT (ORCPT ); Tue, 10 Aug 2021 13:38:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BE1806108C; Tue, 10 Aug 2021 17:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628616982; bh=amhtCrGFvdrjbWgQ93G8dOT53+d74mqChd1YIJSqSWM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1CQGFraX2bbifg63tUUTl9Lc8LSPpuVXuNqWoQK6DpqMPRhNObG+GmEBMCrGT6fOk vrzusWwQqPacmTNE/UBVkGOmoJ9xt86trbZN8hK2V+Kv93b/PzV4EJTzJxZOVNhUi2 e2vEd2f8+sBx+qIWIyUw9iOx4chELuWAMWeWg9ZY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Borkmann , Alexei Starovoitov , Ovidiu Panait Subject: [PATCH 5.4 78/85] bpf, selftests: Adjust few selftest result_unpriv outcomes Date: Tue, 10 Aug 2021 19:30:51 +0200 Message-Id: <20210810172950.866385030@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810172948.192298392@linuxfoundation.org> References: <20210810172948.192298392@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Borkmann commit 1bad6fd52be4ce12d207e2820ceb0f29ab31fc53 upstream. Given we don't need to simulate the speculative domain for registers with immediates anymore since the verifier uses direct imm-based rewrites instead of having to mask, we can also lift a few cases that were previously rejected. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov [OP: backport to 5.4, small context adjustment in stack_ptr.c] Signed-off-by: Ovidiu Panait Signed-off-by: Greg Kroah-Hartman --- tools/testing/selftests/bpf/verifier/stack_ptr.c | 2 -- tools/testing/selftests/bpf/verifier/value_ptr_arith.c | 8 -------- 2 files changed, 10 deletions(-) --- a/tools/testing/selftests/bpf/verifier/stack_ptr.c +++ b/tools/testing/selftests/bpf/verifier/stack_ptr.c @@ -291,8 +291,6 @@ BPF_LDX_MEM(BPF_B, BPF_REG_0, BPF_REG_1, 0), BPF_EXIT_INSN(), }, - .result_unpriv = REJECT, - .errstr_unpriv = "invalid stack off=0 size=1", .result = ACCEPT, .retval = 42, }, --- a/tools/testing/selftests/bpf/verifier/value_ptr_arith.c +++ b/tools/testing/selftests/bpf/verifier/value_ptr_arith.c @@ -301,8 +301,6 @@ }, .fixup_map_array_48b = { 3 }, .result = ACCEPT, - .result_unpriv = REJECT, - .errstr_unpriv = "R0 pointer arithmetic of map value goes out of range", .retval = 1, }, { @@ -372,8 +370,6 @@ }, .fixup_map_array_48b = { 3 }, .result = ACCEPT, - .result_unpriv = REJECT, - .errstr_unpriv = "R0 pointer arithmetic of map value goes out of range", .retval = 1, }, { @@ -473,8 +469,6 @@ }, .fixup_map_array_48b = { 3 }, .result = ACCEPT, - .result_unpriv = REJECT, - .errstr_unpriv = "R0 pointer arithmetic of map value goes out of range", .retval = 1, }, { @@ -767,8 +761,6 @@ }, .fixup_map_array_48b = { 3 }, .result = ACCEPT, - .result_unpriv = REJECT, - .errstr_unpriv = "R0 pointer arithmetic of map value goes out of range", .retval = 1, }, {