Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3771009pxt; Tue, 10 Aug 2021 10:56:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDC3wNBdnl3l9WtqggCjjqTACcnoVtuZyUeO+5xhEtcwPlTzWLJU6/YucOyhAhjAr6w0MK X-Received: by 2002:a92:db4c:: with SMTP id w12mr428566ilq.306.1628618213652; Tue, 10 Aug 2021 10:56:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628618213; cv=none; d=google.com; s=arc-20160816; b=Dz0AVHfFetO+ynJNs5be0bIwEitnghlDu1VSwt/LoLOqx/CdXHa7vIdVefkYOy2hZm 0lV/mdo1OBgYf4Om9u5TWhwhsOHjdaGqhGUdTkhXNv1bJ59lkTZlNHzhwjGnVdg2RDzv Vgq4C7j+D9vN0th0Y2HCuUc9iF2/FVDDiKSHfFaYEZbj5iSYE3U9JLQ6VMrdZ6vv2xVT rBYpNVXYQdP0tMDqeIo1HmzGF1RX9OQRCzpGWSZhyhZ2bYYpPXGylN05WZvCtnQbMbmb k5R8CAEn/D3EEML2JFrJn3BJdZ4nJ0tbhfz3OlLGgkRMzBwQiTBsipMepWr8FwP8U4+6 42sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0+0PQrcsUhgT3o84B6C3YBnIvNq4Jz12EDybiOalkRA=; b=XvFDlNzlyw+8Orwd2fBpPg32m6r71RAw48CGr/d9ENgxxM/q/PZvuB6tE90Q1XLh0P iGzWg4tndPzH1q0iIGOytI6jcZj7O1Yuh6rxl8MDk6N76PCDkHqfMSoYbHBn2TJFOyTR Qge3ga3/3iw84yqmffRKyd+mqRLyyyxs8FaiLp3hlC81GBOJW9eNxmpom1b6hl8vJenY Ck6+CgVGkmxceRyps2kBnqtjqCnz6nq5UjKqbr9BEE8732mdkj7BSRdL3fs7kgaIPwe+ BoOK55ryDdJ9r26H5iO/rIi8cyeBr6pyzgBCi2ws9vNL5yuB6kjvZXXiL6+lUksgtGut jrKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vUqhuWUN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j9si4378657ilr.97.2021.08.10.10.56.40; Tue, 10 Aug 2021 10:56:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vUqhuWUN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234908AbhHJRyI (ORCPT + 99 others); Tue, 10 Aug 2021 13:54:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:55516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237251AbhHJRuS (ORCPT ); Tue, 10 Aug 2021 13:50:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C1E5261288; Tue, 10 Aug 2021 17:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628617351; bh=LWtX7Sg/VE+wTK3kLySBFzwV8dTYOhUf8dKH7tMismg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vUqhuWUNa4JbRRpjjidAi6iprkUDJY0LGQWAzzgjnYe+JhmC3JTYLiCCseinIS3RK fSsTQEGtScXINZXTc92qckQBres6ADihDyEOpC5g7BxB3B5kHE4LEOQeOkZg308F0G GDJSfB/SX48sx1mOvfnLt7WCAie+OVSw8bi6mmTU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ye Bin , Theodore Tso , Sasha Levin Subject: [PATCH 5.13 020/175] ext4: fix potential uninitialized access to retval in kmmpd Date: Tue, 10 Aug 2021 19:28:48 +0200 Message-Id: <20210810173001.612148440@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810173000.928681411@linuxfoundation.org> References: <20210810173000.928681411@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ye Bin [ Upstream commit b66541422824cf6cf20e9a35112e9cb5d82cdf62 ] if (!ext4_has_feature_mmp(sb)) then retval can be unitialized before we jump to the wait_to_exit label. Fixes: 61bb4a1c417e ("ext4: fix possible UAF when remounting r/o a mmp-protected file system") Signed-off-by: Ye Bin Link: https://lore.kernel.org/r/20210713022728.2533770-1-yebin10@huawei.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/mmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c index bc364c119af6..cebea4270817 100644 --- a/fs/ext4/mmp.c +++ b/fs/ext4/mmp.c @@ -138,7 +138,7 @@ static int kmmpd(void *data) unsigned mmp_check_interval; unsigned long last_update_time; unsigned long diff; - int retval; + int retval = 0; mmp_block = le64_to_cpu(es->s_mmp_block); mmp = (struct mmp_struct *)(bh->b_data); -- 2.30.2