Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3774343pxt; Tue, 10 Aug 2021 11:01:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUhvS15h/7lQixhl1v6KwRNqtpG2Syntbv2HIavmoHlwt5TDiX7y4Zfb/t45JVPOt59AMM X-Received: by 2002:a92:c5c8:: with SMTP id s8mr212258ilt.140.1628618512068; Tue, 10 Aug 2021 11:01:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628618512; cv=none; d=google.com; s=arc-20160816; b=AzPE7KBjlxGub3cn502JrJigcPq2bjmInjOYefhftT0+wHud4PCXnFC5BUZVay6aDN St8rTFow27ZsNj5PASYJSKzpF9ztJIRM7c4WQZ2K035Hf0n9rVy4X9xvC5e0I9XRjxsy B5/CMu1BHbBS9372k/Oa0S9MgxSBT1gTTY9jqwUeuRTBI/qeRjDYeHAPMO7n6TIvhm7z kTHsYlu3U4aqlMyzYqIdom1vh5m4feMypEf1Re+xTc9fEScjlChm9D0AUuxuxnp6Q46O 7ATx0QF3RGSUt9owQ6vQqqpdEd896xqSqL6ukSOf5QN1pSUn5urLN4v9W14YgVlEQw1A ASaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dkKS3MRUquvge+CNr3G6lUFPP71mvT6Oije0gKoOTLE=; b=uF3oDn/VMESev7hreuZbjdYeSgCJAmep/RE/azz6ckcpTSi9hn8fI3BTTS+O73LNBJ DPRPzczDqTVDxbnPk7kbXKZ9EW+pg+1pDSErnqgTLuGv1F1+W0JT8+WKfy70lIQ0gyeu +dWkzmKOX6h6oCoOLWEOzzbsHgi7jSskZZtAt9mYWImBoGECyIsRlh7EMxAu/lgSHSYf //8mYhUQYDku09fb6xUcB/8FAPmUkr5YVrL0lrZXqZmxIod1Pb2XdJFUUzPobwqDKXjU PZIz7M+O4+RgP0xHniazut0MhhkldrHDhiF3J40bMg32RuG4+QDON0MtjhCDVnOfHvZi zcXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mF585KFm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si1366532iog.10.2021.08.10.11.01.40; Tue, 10 Aug 2021 11:01:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mF585KFm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237103AbhHJSAR (ORCPT + 99 others); Tue, 10 Aug 2021 14:00:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:51934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232192AbhHJR4w (ORCPT ); Tue, 10 Aug 2021 13:56:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D4B4661381; Tue, 10 Aug 2021 17:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628617517; bh=BQ1Xum7W6wbpX23AFzITRJ/1p5/0mI2y8uavi8Uki6o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mF585KFmA5gAHhroDS346baKzmSOkNDgtkvzem2dtL0tHBfO8DzWm38XgcbM0+O+y dXot1V0EXMr1YmkeWM2Xlg9vAsralrSh8ExqG0laeL0F2lqxacXRLlOZSWB6aZtYWg fmrjKh86bUT0IclpFjQ6sBoG+/iMYlcY8iUHWtZw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pawel Laszczak , Peter Chen Subject: [PATCH 5.13 092/175] usb: cdns3: Fixed incorrect gadget state Date: Tue, 10 Aug 2021 19:30:00 +0200 Message-Id: <20210810173003.987719534@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810173000.928681411@linuxfoundation.org> References: <20210810173000.928681411@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pawel Laszczak commit aa35772f61752d4c636d46be51a4f7ca6c029ee6 upstream. For delayed status phase, the usb_gadget->state was set to USB_STATE_ADDRESS and it has never been updated to USB_STATE_CONFIGURED. Patch updates the gadget state to correct USB_STATE_CONFIGURED. As a result of this bug the controller was not able to enter to Test Mode while using MSC function. Cc: Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") Signed-off-by: Pawel Laszczak Link: https://lore.kernel.org/r/20210623070247.46151-1-pawell@gli-login.cadence.com Signed-off-by: Peter Chen Signed-off-by: Greg Kroah-Hartman --- drivers/usb/cdns3/cdns3-ep0.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/cdns3/cdns3-ep0.c +++ b/drivers/usb/cdns3/cdns3-ep0.c @@ -731,6 +731,7 @@ static int cdns3_gadget_ep0_queue(struct request->actual = 0; priv_dev->status_completion_no_call = true; priv_dev->pending_status_request = request; + usb_gadget_set_state(&priv_dev->gadget, USB_STATE_CONFIGURED); spin_unlock_irqrestore(&priv_dev->lock, flags); /*