Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3778674pxt; Tue, 10 Aug 2021 11:06:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxnkEPrLHVP7ORx9DYHDb5oo8iYm8AIZ++fqcXI/0NjtgcmsIOkqQ59axUlnrfhFcxWmw2 X-Received: by 2002:a17:906:8281:: with SMTP id h1mr29852160ejx.352.1628618814181; Tue, 10 Aug 2021 11:06:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628618814; cv=none; d=google.com; s=arc-20160816; b=bsTx8v0nGnuZBXYJqsWH5bCUELSXL9R+D4FBwCTNkVCPHcELzUOJ5FBYB3EW867q0w WFLO5uatko6WyQN9RN6ruwSYKe0hfvdmc8jNyqTyafzUm25d7/kp7qgqTsh54tsYcENp TKZFoH//4kW0z/OaRwUynLfqOQS9Fk0iBaChlAyNboLTrjWS8vxX+Avy4F5DqrkhUJYv AOvLhE0S61NkOR+yjkVGqlsqaUnId6RiMOymp+dGFogxAuZmUrpnI+KSCfffuQokfWh7 lQivgU/46ks357RSfZvZHFCHSG7sZydcPw4Nir6Zq/7h3ZKXVe4wrNvkOe0iJuC6fgHH ZonA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vLqDbk62+53xurRPlxBfd2BITwHy/aJoSn9qN5rWMPY=; b=IKicj0H1hcOG8ZGa21IYeRJQTlhCGXI4TnYZQzgU/bAfzeMu265WiXz0RS954R9XNj m3glvrr4+Jn5T5iswkQf1BZeoQyojMDo7PJR5zuj1jzXQQjGAljv3tCAWD6HTOt+qOXc pPL5mp9KEtNq0DLeWJIwCrnom5r0bNRek8e6y/Cash24F9R0f/BcS2sC5YjChi+BVApc GqjSy4ReF8l+lWh/nPZ7TyTui78Y+hzqeZCyVvhef+Kz+rDkNnGOj4HhlJE5JELeKM7J sLHFSg3e9dQUbWMtlVVON2rJXVtCiPP0IM/3DBZ5mIJDrzdNqcyAQkDE2U5UdWHlSHAm KPcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FRMB7DZc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si22546955edd.72.2021.08.10.11.06.29; Tue, 10 Aug 2021 11:06:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FRMB7DZc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239265AbhHJSFD (ORCPT + 99 others); Tue, 10 Aug 2021 14:05:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:60118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237585AbhHJSBT (ORCPT ); Tue, 10 Aug 2021 14:01:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BBC62613B1; Tue, 10 Aug 2021 17:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628617619; bh=1oExI4xT1X0DgvO44tr3R7Kv855uBCclom3Awv+5h/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FRMB7DZcSg4fg37ZaVVr6vhNJb7staWz7lq2y9F+63q7XhB3o+CNOm67Wh1g3XQtr Az1Hn061hcb2fOEt/o1P748tn28qQf7xkh8J5I5kfcPPxpgBDQOkJg2+UoztL+hZPK yY++Lpx5Ha/1D0Hi3bjILBMOJKY6zK6g9BK31pKQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kamal Agrawal , "Steven Rostedt (VMware)" Subject: [PATCH 5.13 104/175] tracing: Fix NULL pointer dereference in start_creating Date: Tue, 10 Aug 2021 19:30:12 +0200 Message-Id: <20210810173004.392950614@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810173000.928681411@linuxfoundation.org> References: <20210810173000.928681411@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kamal Agrawal commit ff41c28c4b54052942180d8b3f49e75f1445135a upstream. The event_trace_add_tracer() can fail. In this case, it leads to a crash in start_creating with below call stack. Handle the error scenario properly in trace_array_create_dir. Call trace: down_write+0x7c/0x204 start_creating.25017+0x6c/0x194 tracefs_create_file+0xc4/0x2b4 init_tracer_tracefs+0x5c/0x940 trace_array_create_dir+0x58/0xb4 trace_array_create+0x1bc/0x2b8 trace_array_get_by_name+0xdc/0x18c Link: https://lkml.kernel.org/r/1627651386-21315-1-git-send-email-kamaagra@codeaurora.org Cc: stable@vger.kernel.org Fixes: 4114fbfd02f1 ("tracing: Enable creating new instance early boot") Signed-off-by: Kamal Agrawal Signed-off-by: Steven Rostedt (VMware) Signed-off-by: Greg Kroah-Hartman --- kernel/trace/trace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -9006,8 +9006,10 @@ static int trace_array_create_dir(struct return -EINVAL; ret = event_trace_add_tracer(tr->dir, tr); - if (ret) + if (ret) { tracefs_remove(tr->dir); + return ret; + } init_tracer_tracefs(tr, tr->dir); __update_tracer_options(tr);