Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3778921pxt; Tue, 10 Aug 2021 11:07:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGDkuhVp827nIuxw7BRn8EPu6+hCOrwAcyiUgcCANQhOKsvaF+v3MoZzPJ87Gaa+7j7teZ X-Received: by 2002:a92:660e:: with SMTP id a14mr183566ilc.249.1628618829431; Tue, 10 Aug 2021 11:07:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628618829; cv=none; d=google.com; s=arc-20160816; b=omrU/yloRQzzS7LIHmTqqqRI6XnNGuuV52L4GfKlYKwBpflbykW6yPOfiJWGaLl/+2 mjAmm55AYXPRuGvXrOi1LisBLYWBnOEQ5e4f+DCMxHBd9/8uHha/rEZAdVpX/Ent+B4m gi4R4g7/ndHkdgASWpQx/fNOO5YNAfVe4RJyhIKgtwv1YAdL65LeUlSG4MmnfK/tJ/fa 4VmDgRsZ5NC65yo1pOibSC25Rrwjb8Qt8pWmIMq9QMXi3qUB81mVfVPTN1n75U53S87o lU1y2zybZ0ODBzN2hFrhvCP1AQcq37gmlK3WrnyRyQhiR/CIOn8rNWnubevkMDAU17Sx qUog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BXllwr40EXdi9szsdtepMI3VmgCi6soB5SNRzb6+JpU=; b=NEWdE/idZLHXPXOpAg2+h3dEDSlEjIT5CY1ks2J9jFn7I8bA9kzX65JVCK4QBs7wOg 21FKRjY4u/q1GqhgCPAVmWmQ3G6sYEjczJRwzfzZHXabzJZdkyk8rtU6KL+43g/8/en8 BARVCqp1GncgzwJ06k3G56xiuKREgzYkwIes7++RxEnLB+xpFKzDtLTzIHbopCGBmNf1 p0q6WEdVOaWhkQ+YZyxEcRNzJ6jPyhcfI6JKecIsD+EXNi/qe0c7DwJKfEhGiPP3VIPI R4jzAi8JKwO/CBMLtaZtrikV90oiE0v5vxQg+kFCKpOB70Y7VOl+Lw3eIIXwuH+2QOEF R/mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nsK5nypT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j9si4378657ilr.97.2021.08.10.11.06.57; Tue, 10 Aug 2021 11:07:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nsK5nypT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239398AbhHJSFL (ORCPT + 99 others); Tue, 10 Aug 2021 14:05:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:60680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231324AbhHJSB3 (ORCPT ); Tue, 10 Aug 2021 14:01:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 356C161186; Tue, 10 Aug 2021 17:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628617623; bh=7JPd5TI+quikPazaZthqblTvGHnfh1lhRrFWrqZR3Sg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nsK5nypTEVpUjVcFWCsflLWJTrzatD3OsURW/OxIJxmHZ+RZOTM6XFG3WKv2xDr/d hozY4LiOMk9nJAgPJ7YvMowMoEQjdLvXZTXN349Hcet5RkhIJFVb1JXaj83GVMdqkC KywcS42mXYZm1gTLz9lS5bP36Z/8Ll+VLKWacV5s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maxim Devaev Subject: [PATCH 5.13 096/175] usb: gadget: f_hid: idle uses the highest byte for duration Date: Tue, 10 Aug 2021 19:30:04 +0200 Message-Id: <20210810173004.113286146@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810173000.928681411@linuxfoundation.org> References: <20210810173000.928681411@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maxim Devaev commit fa20bada3f934e3b3e4af4c77e5b518cd5a282e5 upstream. SET_IDLE value must be shifted 8 bits to the right to get duration. This confirmed by USBCV test. Fixes: afcff6dc690e ("usb: gadget: f_hid: added GET_IDLE and SET_IDLE handlers") Cc: stable Signed-off-by: Maxim Devaev Link: https://lore.kernel.org/r/20210727185800.43796-1-mdevaev@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/function/f_hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/gadget/function/f_hid.c +++ b/drivers/usb/gadget/function/f_hid.c @@ -573,7 +573,7 @@ static int hidg_setup(struct usb_functio | HID_REQ_SET_IDLE): VDBG(cdev, "set_idle\n"); length = 0; - hidg->idle = value; + hidg->idle = value >> 8; goto respond; break;