Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3779274pxt; Tue, 10 Aug 2021 11:07:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdsi81jnq3A5dADYRKvlvy51gmQ3RTSce/OoB2PtnZHpv+JNWX7REV+mLmp132iyTBt6wp X-Received: by 2002:a17:906:3915:: with SMTP id f21mr29349654eje.178.1628618851313; Tue, 10 Aug 2021 11:07:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628618851; cv=none; d=google.com; s=arc-20160816; b=aZhPRBYjfyI1P29fGQhxXwm8PLpBBNqhVYcx8sEReTp/ShhscG5NEAGIYGlw4bNsD4 UNVt1tTSfB6sMVJDluJWnxwK4GHk0sX7vLMzbR3l24rF4oK674T9Tgdr9W3CCR4aMBu1 FOQRb/9da/73/yF+I4FuTdDRtMqmg1Lxtq4h6dBeUUi6HYdMxtk/HgWDuugFXL5Reyus 6DBlMbq3kSC+dN1RYKUbwJqBaPLwD8raa42fRUMw1RbXLbuK0EwT0QB8kt77DjF6/exB A9hTQ+gbv/y51x0sPWU7K/zaps+yjJ5W1atMXP6YV2Z1gQuMNv4uY61QsxgP+oxfeY2L O8bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mhfE8ovL+PPatkQeLW8VADffvYwC4zsvF4QzupGFle4=; b=Vx7QP3rOQKsQklrKQpznwwUJC/BkGbIvQwWbebIfuGLpq1kXhzVuw3RdcEy+g49qfR 4N2qGb6W4bO1u8U2RMBTCJpnP35jU+GaiLEEUhTmjA/CqEVu0aHHWu6P1j2e1xLbNSmZ ThRqd70IU1rSjh3fyWwbz2EVWpzcfN0kssiM0qSMFmpJjFyKYnpS52z0A2Mn1GO6gd3a M3vqcT5CEFvpNv9RhnRdiBljzv6e+psZG1SPUJTEROWIHELSvUF98CrfXgetlgXGL2CZ jSSinvvELCt3gJy5CnKy1q1VMlqWncPMi3EiOH7dHNXJGnb0LvWRxlmSXISp6Fq+T/W/ UyLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vzXabYtR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ji2si21236423ejc.344.2021.08.10.11.07.01; Tue, 10 Aug 2021 11:07:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vzXabYtR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238386AbhHJSEQ (ORCPT + 99 others); Tue, 10 Aug 2021 14:04:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:60848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238389AbhHJR7d (ORCPT ); Tue, 10 Aug 2021 13:59:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E7F25613BD; Tue, 10 Aug 2021 17:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628617587; bh=mZeIxsdURR5OkVvnLv8FSnYIW8IK2nSTtUf4eC7nvAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vzXabYtRIfcE2pm0Ww1hQbAc5UMKqDgUNsxPaXpFkLXpLnXWwirOm4fkOacfl6MK+ s7SycZXrZ067KcR/lYghf0JPoBn6h1aXz08XtkJ2kOPxCnXoRAlYKnvW0/VmNdb2/q TIh4TGp9mrLS8a4P+LNzYGIFrAfcgusp617lubJE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thierry Reding , Jon Hunter Subject: [PATCH 5.13 124/175] serial: tegra: Only print FIFO error message when an error occurs Date: Tue, 10 Aug 2021 19:30:32 +0200 Message-Id: <20210810173005.036632950@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810173000.928681411@linuxfoundation.org> References: <20210810173000.928681411@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jon Hunter commit cc9ca4d95846cbbece48d9cd385550f8fba6a3c1 upstream. The Tegra serial driver always prints an error message when enabling the FIFO for devices that have support for checking the FIFO enable status. Fix this by displaying the error message, only when an error occurs. Finally, update the error message to make it clear that enabling the FIFO failed and display the error code. Fixes: 222dcdff3405 ("serial: tegra: check for FIFO mode enabled status") Cc: Acked-by: Thierry Reding Signed-off-by: Jon Hunter Link: https://lore.kernel.org/r/20210630125643.264264-1-jonathanh@nvidia.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/serial-tegra.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/tty/serial/serial-tegra.c +++ b/drivers/tty/serial/serial-tegra.c @@ -1045,9 +1045,11 @@ static int tegra_uart_hw_init(struct teg if (tup->cdata->fifo_mode_enable_status) { ret = tegra_uart_wait_fifo_mode_enabled(tup); - dev_err(tup->uport.dev, "FIFO mode not enabled\n"); - if (ret < 0) + if (ret < 0) { + dev_err(tup->uport.dev, + "Failed to enable FIFO mode: %d\n", ret); return ret; + } } else { /* * For all tegra devices (up to t210), there is a hardware