Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3779354pxt; Tue, 10 Aug 2021 11:07:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKUijbVJwdYeeN3MFnXc51HNHwHQg5+SVKYoBpZJGHSh6N0gIe+De8ii8MAjNxM7CaV0P+ X-Received: by 2002:a02:a390:: with SMTP id y16mr29224522jak.120.1628618857813; Tue, 10 Aug 2021 11:07:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628618857; cv=none; d=google.com; s=arc-20160816; b=zgdwOrEYEshxxwLDkWRiplvVJ8p1VqmtrtbO9gCd70lIffZTWnQ1P4H8JIY0lV3Mqp osh5cdZFi7TAjSWacv1FhTha/DyuTXF5/pIPbESSIUQ3CAEvmUJPX1BL6G8TNrbSm5tY /s5UGsi8PbK0mZs/UWPnjM/HRZ0lGGRHRH655BQZH8uiCcPFNOiZboP/Z6aUcY276pwj CzQzdf0TLSgzTkDT1YUfkzWWEDHA6xCmyAp/b6SSTj2zaUmZl9aHfjy8VBM5uUc2FdwQ hnwDQd/NLhMXLwANgJ6Cmhm2qfxx4LlziCyZulVDZ52I9bhZqxXJUWn3Ux3omjSyzdLv c6Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wm6xkx3J/c0H3miRPeAcsS/ehBP+fQJwgLuu1dsuR6g=; b=KNHdqxr6Z1jZR4+wNHww3ILUS8EKVePv1PYoJVUjKuYctazFOQbkFhOBYa6b4zF8Sy JSWCY1tpiLSPLpJXl2o52QCvrM1A1WydaPud65qqzrZen07QKMD/4ghCwDW1Qlq1llgd NGJQLgrBy1w177d3fTDk/uMjl2zlMLGvcKihx2+bDAGt5zAipJ9ccmT2BlWCXByisQIx 9kUS5FavMr7r/k+eD6c0bxNMEb4PIveWBgijor3yayhqhwpCuEEn3o7t7iHOgiQc4Lyz vQ0h0e2PwJuxyZIcdyXMDr5HGvdGz7G3cQ2IfWttolxhNHjqpwL6OWHhvnZ0ZLzcPZLl Eojg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=w5xDtGYY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n14si26480935ilk.78.2021.08.10.11.07.20; Tue, 10 Aug 2021 11:07:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=w5xDtGYY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237085AbhHJSG6 (ORCPT + 99 others); Tue, 10 Aug 2021 14:06:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:33870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234493AbhHJSDN (ORCPT ); Tue, 10 Aug 2021 14:03:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E611961241; Tue, 10 Aug 2021 17:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628617662; bh=pDdLwGfN7E6ybMm18yH4Jbx6PvgDlvXVc+EYZDqlKyI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w5xDtGYYmqflluVdGNHIB7+Ajc/IizUH/+d9XWZNwuH1RRmi0eVWsTFRfGZI7SmOP Vu+JPRrhj/ZOHtli8OJq0A+UekXzSPI0Hod1nvDoIP0monjpmWMQtCKFpeTG9T/EWe EbdVx3TZCxp51Z9+LDM6dVmudgFgdusFtfrX+8pE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mike Tipton , Georgi Djakov Subject: [PATCH 5.13 157/175] interconnect: Always call pre_aggregate before aggregate Date: Tue, 10 Aug 2021 19:31:05 +0200 Message-Id: <20210810173006.139418823@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810173000.928681411@linuxfoundation.org> References: <20210810173000.928681411@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Tipton commit 73606ba9242f8e32023699b500b7922b4cf2993c upstream. The pre_aggregate callback isn't called in all cases before calling aggregate. Add the missing calls so providers can rely on consistent framework behavior. Fixes: d3703b3e255f ("interconnect: Aggregate before setting initial bandwidth") Signed-off-by: Mike Tipton Link: https://lore.kernel.org/r/20210721175432.2119-3-mdtipton@codeaurora.org Signed-off-by: Georgi Djakov Signed-off-by: Greg Kroah-Hartman --- drivers/interconnect/core.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -973,9 +973,14 @@ void icc_node_add(struct icc_node *node, } node->avg_bw = node->init_avg; node->peak_bw = node->init_peak; + + if (provider->pre_aggregate) + provider->pre_aggregate(node); + if (provider->aggregate) provider->aggregate(node, 0, node->init_avg, node->init_peak, &node->avg_bw, &node->peak_bw); + provider->set(node, node); node->avg_bw = 0; node->peak_bw = 0;