Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3781635pxt; Tue, 10 Aug 2021 11:10:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmb2FrQLSnIJy2rq4n5W7f53tNVOI6uZqRh5rbL9Iojq6NwC1EpgVENt1PPxXLPRlaK8Tb X-Received: by 2002:aa7:cc02:: with SMTP id q2mr6394683edt.154.1628619034799; Tue, 10 Aug 2021 11:10:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628619034; cv=none; d=google.com; s=arc-20160816; b=fNfPj8Zo4GmlHU7chpnvbElkWm2xRUzt4JJaly6w6gUuYd6iBfj8pCNRjQ9/0cmGm6 VDfWDUQ9ow+eCqSoZT0lRpBorClwHYzqOnW0RzFXLlLUnn6NCUiAwxgdu4XrWOK1ltEZ 2TqNcXh4SpQqLkYOPdxeGjflyQQHpRcGzraV3tlz33UDPE9eg6/kUS3/xRCHS6f6Vt63 9vf1segQ3ifB/Jk1PsQKB+fCrDoCUiXGWAFXqKrLjzvUAGdlh62npa0RFUlHWmB5Cfvw +LWC8h/OJbPrPC+SNd9lbqb67pUTWsCGwXe14/XXO/3qBgqh4U0yYDH0RGSRmUYQaN6l 1z1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fwCPCuZk5Kd16U4TrTqvZT7hbVQB/2ex7yhukj0PqU4=; b=mWwW5pMMjq/yROaOMaKc7PDhznszIz6rzn2KV/oG1kL060BzHaQKAuo4FNwI/iIwvq thIlc3IKJ3p2/r8Xdg6pgVy3u/ShRDjBzBE2/IYzJs9jHjksYrNIvSRAl48UDr8chsmr 0aJpn8PX2OVw64IyV+JauOlQ6Eo22I8XQ/Gr9S93V/LowVS0APlg4fhmxpka+/f8eEgo CYjmcg2ycDZRZS6+MgxpjrZNFSPzGMF5K4wGMDYZlcZ2ErOFLMFp7np5SOe/d4wCxF6R ceuP5NbaRYqSRwt6yDWCenoZQW39dHKO60FTBJVYaS537TI3FMnwHtD8kHP3GaiskJfp mFOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="SU3H/nK7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j7si12299264ejm.280.2021.08.10.11.10.10; Tue, 10 Aug 2021 11:10:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="SU3H/nK7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236019AbhHJSHk (ORCPT + 99 others); Tue, 10 Aug 2021 14:07:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:40442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233175AbhHJSEC (ORCPT ); Tue, 10 Aug 2021 14:04:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CDCF96140D; Tue, 10 Aug 2021 17:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628617700; bh=O1JXziG7vpsYTUlqBbrRIAVEitqj6XP8aRxP5VOKK/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SU3H/nK7XBS+iq3zEpVTIoRRApMRo1M6yt+KYRT4NcOFuXZLhL4e6SLs3ee2lMjjU P255e4n3c7eGQCqdpxH0pWeF3K/5W6sYKQoCV7zU2O0nUaKWT5KekbX7U03ET1B1UZ VlB40Ud96r6L4QvPDClU4LZqwEIZqNqzDO2S1zaI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rasmus Villemoes , Bartosz Golaszewski Subject: [PATCH 5.13 141/175] Revert "gpio: mpc8xxx: change the gpio interrupt flags." Date: Tue, 10 Aug 2021 19:30:49 +0200 Message-Id: <20210810173005.583724707@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210810173000.928681411@linuxfoundation.org> References: <20210810173000.928681411@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes commit ec7099fdea8025988710ee6fecfd4e4210c29ab5 upstream. This reverts commit 3d5bfbd9716318b1ca5c38488aa69f64d38a9aa5. When booting with threadirqs, it causes a splat WARNING: CPU: 0 PID: 29 at kernel/irq/handle.c:159 __handle_irq_event_percpu+0x1ec/0x27c irq 66 handler irq_default_primary_handler+0x0/0x1c enabled interrupts That splat later went away with commit 81e2073c175b ("genirq: Disable interrupts for force threaded handlers"), which got backported to -stable. However, when running an -rt kernel, the splat still exists. Moreover, quoting Thomas Gleixner [1] But 3d5bfbd97163 ("gpio: mpc8xxx: change the gpio interrupt flags.") has nothing to do with that: "Delete the interrupt IRQF_NO_THREAD flags in order to gpio interrupts can be threaded to allow high-priority processes to preempt." This changelog is blatantly wrong. In mainline forced irq threads have always been invoked with softirqs disabled, which obviously makes them non-preemptible. So the patch didn't even do what its commit log said. [1] https://lore.kernel.org/lkml/871r8zey88.ffs@nanos.tec.linutronix.de/ Cc: stable@vger.kernel.org # v5.9+ Signed-off-by: Rasmus Villemoes Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-mpc8xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpio/gpio-mpc8xxx.c +++ b/drivers/gpio/gpio-mpc8xxx.c @@ -405,7 +405,7 @@ static int mpc8xxx_probe(struct platform ret = devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn, mpc8xxx_gpio_irq_cascade, - IRQF_SHARED, "gpio-cascade", + IRQF_NO_THREAD | IRQF_SHARED, "gpio-cascade", mpc8xxx_gc); if (ret) { dev_err(&pdev->dev,