Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 10 Aug 2021 21:47:17 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Evgeny Novikov <novikov@ispras.ru>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alex Dewar <alex.dewar90@gmail.com>,
        Colin Ian King <colin.king@canonical.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH v2] media: atomisp: Fix error handling in probe
Message-ID: <20210810184717.GZ1931@kadam>
References: <20210810162943.19852-1-novikov@ispras.ru>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210810162943.19852-1-novikov@ispras.ru>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNXP275CA0033.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:18::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16 via Frontend Transport; Tue, 10 Aug 2021 18:47:30 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b2241377-49df-4d30-99d6-08d95c2f52fa
X-MS-TrafficTypeDiagnostic: MWHPR1001MB2255:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR1001MB22554E7E7E3FD49F91E32DF68EF79@MWHPR1001MB2255.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: FPowNCl5V2lfP2058QH6sYZKWzgfdPNrHL1l2SJ53oScgqSxI4PQD3GNnS5lmfWhMoC1AndvUixQMU5O4Jqg67HEjFYeWu/iUg4uoThjjRGldzvzfmGHdB89V4s5i9sSgkrezhWxnaJMh0e3cuo3dqXx1olc0Za+jKj3GMI2lau6YnxEExOmxuVwZZonciGyC6X77KrxHDP2MN6UdhVWaz7+CDENrLqTl6GR45b8z+QQ6N1KJ/3OkUls4AG5DFzFDT64IOcj8ApEhoeBeBw1lREz9Gpp2M1V4fpY/cdM3B9ueQNB1VVD5xlOg2eTG+4C3Qn919LtmYtTW8xa3lq7EFkEUU9ndIom/sl8gYi8JhhAwNolfJAj6i3UCKgoBWQRCpN6rC5YSCZcvrwSXkIFxDBMws+mEjhIvOEhixj/cCZuRfQPVooOyFetq9Vr+I06PHYNONXMBAHLA3pdSdJQj2VqQ3eUYtohdoNsCKzZJRRwwGZQW6vnQG7byAu0nPTjdJkHs/22wMIxS7ayrocd0xgDbG4yDpZxUaLsctJ8bZyt0qnZsxjdllga73yvdrKt05Jv9yPKgoiG/U97Ki9eDgyXVv6CEqCN/guBhXMiJj+q8yjfuv0DY+DRCwt6toRCAttu1iLwo5dVLwm0ywDD9S7PRIYtMLV3+IxOjKr9m+l7fJ8l5tVttcoUZDo6OtIfxO4jwOplTJxaJiycIfNG6A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(136003)(376002)(39860400002)(366004)(38100700002)(38350700002)(2906002)(7416002)(54906003)(6666004)(44832011)(52116002)(956004)(6916009)(86362001)(316002)(6496006)(5660300002)(66946007)(66476007)(1076003)(8676002)(4326008)(55016002)(83380400001)(33656002)(186003)(478600001)(26005)(33716001)(8936002)(4744005)(66556008)(9576002)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v5pNl4c5kxJTGKDRp6opVw/9fOPleJQf4V0HDMbdLbF7Vn2GyOQR17iwbFwm?=
 =?us-ascii?Q?FxO+c9GT38DlPDEpP5irRNkgt2AiEcqLbSqzHHiy0e9+wL63inJUIhoX824G?=
 =?us-ascii?Q?luLdQ3L5IVnZ1OCLzWEV6RAfmkSsDOqkBFh17Dtybsn6xR6CCvTrEisgX1dB?=
 =?us-ascii?Q?nHyRu5GnXxcFy4cbyO+HQ6srKnStoQrY1no4KuZsWF8tCHZJMLJL9FQPX95j?=
 =?us-ascii?Q?psM/rq6swmSxybSjaDtU7qHqbZBnbLuMNkvH75v9tgiPFn/f+OoCYiCthQlk?=
 =?us-ascii?Q?qkXoq1rjTLPuI8pnuBFQm5SFza7eJm5YGSqeRSc8QRdIBZygmo4CpTa84yeC?=
 =?us-ascii?Q?OlnzoHKK0SLlPEMVtRjgsd+zk5i9ql5aYcQ9gdvN9TxlJkzmV63uS4hY89iE?=
 =?us-ascii?Q?3Vnqy6Vi+yfdYfUHeY/UNuf9K08u30NYQGIbusDl5SWVZGUqGIF9FSQSHelU?=
 =?us-ascii?Q?oAnBhD7FgjNZr5zqUWVINL/BunXBxdjyCpN0a2kS3+OH8qopVZVI9ApakK+S?=
 =?us-ascii?Q?PGKIHzV+AtfQWsvNfJsTsMrzlvCNjUKGsU42xeRB1ApTOp7o+7zcenmWCshz?=
 =?us-ascii?Q?kJkZRJc5hN2atb8tvtDK7K7Gaw9y57JzFd8GDBa5cyXqo1Sk0hgxe8UoNdi7?=
 =?us-ascii?Q?eeN3ytaRx28NMOqkcI6QOh9SUa+vY7pF0SbDtpP7IM87f6drgxgkoWo8ItHa?=
 =?us-ascii?Q?wSaAnevj13+Qbw5Hv6tFqJbLpCkoIDh5xQqXkzw/g4wvkUijxdmvjWdAZ3FX?=
 =?us-ascii?Q?0c9GTHs4+b9aGocEtFRjTnOfbT0C1X/B/ybFgizb8tSIbkkuZU2AoaYa/0EF?=
 =?us-ascii?Q?gMk1LBCna5rjM9Jbsp6/D6Bm3kWQM1QBxUt/Ht3cV5c6tjpK2OrQEMVhGg+m?=
 =?us-ascii?Q?FPyQeYATKgKOL+yrEFaD960HMeImzqJPUMoHmqY+Pa9W56QVSgJxpPFIkRjc?=
 =?us-ascii?Q?7UzrDsOOO0Qzp1yx/pzZbtSKjLqXlWZDUNfG/z42Xtf45K23bEky9lRHbQF3?=
 =?us-ascii?Q?2Vn9mEgSO7O585wURdUPfmQAe/ksm+NZFJWOcf16oojYT+6APL+FhnkVVQl/?=
 =?us-ascii?Q?bJmlPEclPOXJ33F71YSbivg4qBDphQsroC1XlqVVqeUGzYEzHe4q1iq9S93k?=
 =?us-ascii?Q?/Q5Q0udy+FJ8qw5fgafMT9J8LY1lKWNeairdOH2Ho421bPiOIgX4YXz2mPXB?=
 =?us-ascii?Q?ZJZ0QHz8tMr49Q4cZxSzMALCwID5wXqs2rIXiEfYn9SIbjRhWX5jIZIGTYBV?=
 =?us-ascii?Q?wyLgKEVbbXm/ta/cu4pjJgV43Mb6Ev9AR6sEY6lQa/0FfbZgVkzLacSGzH3I?=
 =?us-ascii?Q?7R37+/MedxE3s9ix3lwqddyY?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2241377-49df-4d30-99d6-08d95c2f52fa
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2021 18:47:38.1765
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XkvadwMYYd+g8zwCx6REBYS76TI47N3DtBVS8cHcX4rTx+sD2BVwPQVOVs4oGxFTBKn+EaSyr/r82PMmtskfN+o7agkKi4r68HuT8y3EZHo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2255
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10072 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108100123
X-Proofpoint-GUID: 0G7IhDmahsAzce1dqtJAe3agjxVdFpWW
X-Proofpoint-ORIG-GUID: 0G7IhDmahsAzce1dqtJAe3agjxVdFpWW
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 10, 2021 at 07:29:43PM +0300, Evgeny Novikov wrote:
> There were several issues with handling errors in lm3554_probe():
> - Probe did not set the error code when v4l2_ctrl_handler_init() failed.
> - It intermixed gotos for handling errors of v4l2_ctrl_handler_init()
>   and media_entity_pads_init().
> - It did not set the error code for failures of v4l2_ctrl_new_custom().
> - Probe did not free resources in case of failures of
>   atomisp_register_i2c_module().
> 
> The patch fixes all these issues.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>

Perfect.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter