Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 10 Aug 2021 21:51:16 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     trix@redhat.com, mdf@kernel.org, p.pisati@gmail.com,
        atull@kernel.org, linux-fpga@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: machxo2-spi: return an error on failure
Message-ID: <20210810185116.GR22532@kadam>
References: <20210810164036.922830-1-trix@redhat.com>
 <YRKyAScLKow17mPO@kroah.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YRKyAScLKow17mPO@kroah.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNXP275CA0042.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:18::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Tue, 10 Aug 2021 18:51:28 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54c3ee28-642b-49bb-d756-08d95c2fe001
X-MS-TrafficTypeDiagnostic: CO1PR10MB4692:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB469289011A3F7CD068E84FD78EF79@CO1PR10MB4692.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1728;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tgAskrgjRqrveJJaXjeKWBss6XmPco7Dji8ZAbKoFbK+etGVVNExWJuJBoo0rnpO5FN+pR2LiCqrYHb4XjAmOKSojIPEIPgkT5PnTe9P27J8TOOyRduaiTgFmFBHkyyYa5E4/MhdytvCm5+L89LKQNDzPvWLayyjlLFU6speIldmqoNY8f5RWflbhcV5CWrNROw+GLn5qMbw3IqIamc8+dZy6qDQxaC23IDHPFvY1t1F9kjwJqDJafN/RMu5Si7PCRMyZGsIZJl0XA9gx5GOF2tA+SQVL5wLm1ghZlAszdnNgO+vyIejsnuJ4wk4B2tHpuz96GfBtSOwVKOLH727IZJv227KtIG5cRE3mnCpWJ5Ho8BuKR3kx2soF7vneZU198PQ9VwOpF5wB525aag/1RrmVgAy19oXThpTKqy27Sch9VKDuPCi8WvaN2it/Q/G9Nx1/ycBVVMZrH31Rdm1TR1VN9OhIvyRJKSbwn3IoBlwISp2F7bd+i3A7yVe0KQv841418njcHamj48RfwxrHXMvDLzDvX5+nydHX0VN2rn2AVwb6ZejB38GFVR09nluMqQ0D8SsUKxc7IbD+RuhrzkeNq2RMOvOrWfSaw2T07QOjz9I3X8j4rrHUgIjqv1RDsb/v5lAwYf+jp/7b6hoHZ6bVGTpV7E1xpwG9ebivqq9csF86PYAAcjxPQk2NlDkoGf9JNGmn8RLzLzEAghOrQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(136003)(346002)(396003)(39860400002)(478600001)(26005)(186003)(6666004)(4744005)(956004)(5660300002)(38100700002)(52116002)(38350700002)(2906002)(1076003)(44832011)(4326008)(6916009)(6496006)(9576002)(9686003)(8676002)(8936002)(55016002)(66476007)(33656002)(33716001)(66946007)(86362001)(316002)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YoCtrw9TrvLqLy+Uox+Jg7QEaO5fiOQY1B3F4AIcM/+qLzsWea+TBt6AqlTS?=
 =?us-ascii?Q?UnwVQEF0wnV8lgQl0cZbAn7+ZK08KhPM8vRaSR5aM1KDNhQi3MRWj0OW4r2E?=
 =?us-ascii?Q?zrgX+/3PY7+wT6bQ9crCy2Y3EEl9nNbpfMwLM/FZJboKX1FbP0in6S+8amqN?=
 =?us-ascii?Q?AJ4I8ET4VeX++3p3JaRmrnueP8N+16H1VuDqf//o2qO+ryxSGFLs+c5h0B3U?=
 =?us-ascii?Q?RLe82H65QQYEQ2+cU1YfW+UbojhRfWuO9vfkINr+A774KLoiRYhCBbTkmIse?=
 =?us-ascii?Q?g9eWrmG+fumWE4kjAriibRAOy8k+uZ7Z7wYk73KjSSAm7BPtY36t99SBfws2?=
 =?us-ascii?Q?dfyM1r8BNw1BqOZLQR//Bz9QSMjYUzDdGWd/U5K2yAE64EyMt3a6z8xrKF25?=
 =?us-ascii?Q?i1d7crq2dZmECZ9IFe22PnOQ8QUiDDRXwAFiuLVTGtKP6D6eeqbiNVZlJSFN?=
 =?us-ascii?Q?dkAr/+9SO1zpjZC6u0Y9JmuHN+fYt2HRzfePr147bml/8reqzxs8UUALhHth?=
 =?us-ascii?Q?EBBBIWGBbwJ60TmcPKWzDCTKEnzspjC8mmV4V/K4boFG9vvRKzKX8VyBQz9K?=
 =?us-ascii?Q?XSfEAg5AOV7OPLXdYsHP/tW9yaYOhUBASVZEH657/61/mHeqehYJHnj+hFeL?=
 =?us-ascii?Q?Tf+72MpTRqgqqsJEVKvSKwa64pC2dRv3OOAasDLun9cCoWKiVSqXmVeSpGm9?=
 =?us-ascii?Q?35keifJrjCrWFnlRVDNy5+p+JiDeAGbmv9hd4xBao7HsjldBay4YjYw0MRH2?=
 =?us-ascii?Q?PFDi/QS7Z5YD7p72K1IsG7xgp526sZVtVgXuFf0wxSMg7P0He3453r50FaxC?=
 =?us-ascii?Q?VrsbrL9O/JRoyPsFxsopDxAbDptBpgOYomdNo+B+TmD9bHMgQLIg/Zwml8Wb?=
 =?us-ascii?Q?rc5ATe0XqN9EsZd6etY/QnuEC15izH5wQArpK4z/A4E45TRDJRRhN82BpR8X?=
 =?us-ascii?Q?0JrweYn01trUKpMOZIa/zoMdD9EroSouWo5gmJFghtJr2eMuiuoKsuuWCkKD?=
 =?us-ascii?Q?JEI6HbZ27rCB6p8fDKQ8MebzMUA3Xe1Tiwsk0mITJtpbA1NXJIArm8MfKwNw?=
 =?us-ascii?Q?jbTkwGoWx1WxgzG0TyRRzD+i71nBVeCerX6NgDY0PnlNRKze7kul7Ua41Ybn?=
 =?us-ascii?Q?OeDdd2ZmInIkfVq48UAH+irhM5rK+at9hgZsXi4/C6JrQmRNHzRhW5psF4Df?=
 =?us-ascii?Q?oYxSoAsoHjSICXif6R8oDrB9AdSOZa1EcAMl5DaPu254V3BdMXfN1BYsp8jc?=
 =?us-ascii?Q?Nc3LCeD6vI59SWX7Vg3zoW+uNZCBe8vPCPYS8SguJDlvIBMjEV4WUXwymyw+?=
 =?us-ascii?Q?6Btk2VKlsxoFUdi6R79Q4Jy6?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54c3ee28-642b-49bb-d756-08d95c2fe001
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2021 18:51:34.2460
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UbJeP1UgHfWq4ocXdP3of5/J0B4wsE8lovaWFPVL3zWA2zvtPDqkrMYTEg1Yjd6pzbDTFr3Qpv/UHj2mBwvBVNVK60IVU+AeukhMdI1Yn7E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4692
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10072 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 phishscore=0 spamscore=0 mlxlogscore=920 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108100124
X-Proofpoint-ORIG-GUID: bIDM6gP-FqduCLhMvfGAx1oYyMQ3kA_7
X-Proofpoint-GUID: bIDM6gP-FqduCLhMvfGAx1oYyMQ3kA_7
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 10, 2021 at 07:06:09PM +0200, Greg KH wrote:
> On Tue, Aug 10, 2021 at 09:40:36AM -0700, trix@redhat.com wrote:
> > From: Tom Rix <trix@redhat.com>
> > 
> > Reported problem
> > 
> > 	drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
> > 	warn: missing error code 'ret'
> > 
> > 	drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
> > 	warn: missing error code 'ret'
> 
> What reported this?  What does it mean?  Where was it reported?

These are Smatch errors, but my bug reports don't mention Smatch so
that's on me.  I've fixed my report templated to mention Smatch now.

regards,
dan carepenter