Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3866905pxt; Tue, 10 Aug 2021 13:19:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRDxGNfjS7QuNDdLYhf0OfZ9dZBYQa2tU/QRxuNAzOt6EtTPDxy/QgJQctxDkstbzVzWmp X-Received: by 2002:a02:2348:: with SMTP id u69mr28541282jau.141.1628626740648; Tue, 10 Aug 2021 13:19:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628626740; cv=none; d=google.com; s=arc-20160816; b=VxPLb0gFrDneeJQLZ6VMYiKNICie0VVNNUv3AOJRbfTjAPaXDHJbJRreKLnA0EMb+M 4cla9m5fQpwTGFcwH/XZYjbUtmXJ/b8kx8a6B3K6liL9XICGDdPuaFs4mUGOyoQyMhSV Q3WZan22DzjSBo3jqagGlX3jvDnLwv6xGJFOqqH5uzn1YIsL/cIC5zkfNycqn04Wn/DX GMO4dkjJNWG+4AN5VjlXid8WAy6IN+fAPz3Qi0GWXCjRAN8kEqs/+BZRYTTm0DuxqKVS oicZX6R89qu09kDr+EaJhe8u+3TObCpKu0thhq/ttAcHRgVtYjO6PAPmGd+E/3jrq2q3 qpBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=HARNjb41hnTeF9Agrw8P+yql+2IGaltxIkM7QljMlr8=; b=B44bAL/431tAko94TjJ2VAO/RAyRQCIvCEePh3e+zWnwBUlmKsuT9ZckJpN0Bna21n DnZR+lTyJKAiTCon02ehovzbP8WPxsaYF16Xc5Oy4zgvg/2tHzT4WMaZZcS4zk5mj/k7 k5bZzuEJ5aj8ZARb8Mvvar+GaLm//+1wNYM4m8Wvyzx6w/CjTZyUKW9KKzEZjUrrDEBJ HvjcG8OnqT0M8qb5eAJDtARz6F70fwg9O9M0fBz6/n0BZtieNBfbkXyXFNXQBpzUZVrv A/D25Sf7++LO6T9rw9Eh5FdAcbBNZFMIn6vXVvyagY0b8QKzqktP6ekGJ/TJVDg177ER Wtug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZUs4H1n5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f21si2303871iow.30.2021.08.10.13.18.47; Tue, 10 Aug 2021 13:19:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZUs4H1n5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232947AbhHJUS1 (ORCPT + 99 others); Tue, 10 Aug 2021 16:18:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31448 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbhHJUS0 (ORCPT ); Tue, 10 Aug 2021 16:18:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628626683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HARNjb41hnTeF9Agrw8P+yql+2IGaltxIkM7QljMlr8=; b=ZUs4H1n5rM54nnKETbYdXbhlz66GqoGHpnC+dpYGeA4HFOAC96KDOmWxeV8OKM9YxArk+F g/Tyd5pM0jkipq4VcTRQLMfwNKoTwkFLv090+SHPN45pIT2e4z68OrDAe+Ha1jydiWFk+M 6boZU6P3KmdDLFFvi0RlOetDqebKudQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-PuB4BO-hMf2X8vvdEYmL3g-1; Tue, 10 Aug 2021 16:18:02 -0400 X-MC-Unique: PuB4BO-hMf2X8vvdEYmL3g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 60EEF100F7A2; Tue, 10 Aug 2021 20:18:01 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F70D18A9E; Tue, 10 Aug 2021 20:18:00 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-39-willy@infradead.org> References: <20210715033704.692967-39-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 038/138] mm/memcg: Add folio_memcg() and related functions MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1810115.1628626679.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 21:17:59 +0100 Message-ID: <1810116.1628626679@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > memcg information is only stored in the head page, so the memcg > subsystem needs to assure that all accesses are to the head page. > The first step is converting page_memcg() to folio_memcg(). > > The callers of page_memcg() and PageMemcgKmem() are not yet ready to be > converted to use folios, so retain them as wrappers around folio_memcg() > and folio_memcg_kmem(). They will be converted in a later patch set. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Reviewed-by: David Howells