Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3880463pxt; Tue, 10 Aug 2021 13:41:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPgBeCtJTH/S08K0ftTjv62XwFSAnS41rBvM0nSecJeYuZWrhYycbpOfIhZLImcVX5/bPH X-Received: by 2002:a05:6402:546:: with SMTP id i6mr7218936edx.80.1628628094355; Tue, 10 Aug 2021 13:41:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628628094; cv=none; d=google.com; s=arc-20160816; b=IgjgF60Uuoe+iobIFvhsA2MQWRIvktVYj65XxBplWVSwwAcTL4POhbVOCh0ytW8g38 d9JZaiGPVy35uIUlIVI5rlrgJAh7p1AeNKPywXWHK94NiHmFNktIi/3QbvD21PHZKbGb Iu2/yfTbokWTdTqc01Q+oRQrvpURKnnT8uApXKuvnR9JxqwYNaiVO9aXDKKDyIGlO9eW crWMgRlJSurmyS9CUZGa51+2+wlra+wtqXyHjth3ydMDc23kHm28MRyjKdbiqc+WiVf/ W+IRRzmVRILh2l4aqDTpWRyoQjoP8JJFXpmJ38oiiWLTSK8KbSBVcwyQI9UBVmdHWIH5 rrIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=8hN9X0coZ/dZkZpRS5vtT+uzi+4IbErPaehQsrg5q0U=; b=LRSLKUcRjlG79tL334IjamZQbBPrVzw/1XTctSLIPVseqZqWapcFSD+Nv42VIhok3P pE1o3DBbJGIo1aAAVTYhfWOg+yCYg/tqc2BaJmVo6n1q0Fad/hnnRRq1X7TQpwHScW14 79+GgnDeG+4OYhR7JyjsTFxarWGu7j4kN6lyqHzVpxGHGWRJtbJL+3K2HZ3gQjwgGBdz zrZxbS/C8pIcmQ7nHUGdBlD2B7fGTfa+IzN1m5yCO623s9bmR4DRRrWJJHSx6JpYRaEk bbvZJh4Rk8WYvnJn1VIPUN+xLaw1SQ6Zw82MiD1kp/mQgnA+mamJqkPP+WtbhPfETRMK BW1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cV4BC9Fv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w10si25313227ejv.584.2021.08.10.13.41.09; Tue, 10 Aug 2021 13:41:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cV4BC9Fv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbhHJUkI (ORCPT + 99 others); Tue, 10 Aug 2021 16:40:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58670 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbhHJUkH (ORCPT ); Tue, 10 Aug 2021 16:40:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628627984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8hN9X0coZ/dZkZpRS5vtT+uzi+4IbErPaehQsrg5q0U=; b=cV4BC9FvFP559dLnPKQ2djxDyxMfYCEzKNKzxIJUrEn2Jwcdxqhh59hV+AIKeACUmC4/8p RkvlEQC+xJSXY/LdADqtDJPpnYB0Mo7ztBzpEDB1qQYurrQBEGGmRwq9JniwXOF1EkZPJ3 ICtukUlbOgc9zpqcQl+ywol8/AnAqa8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-524-65fBjrNeMviyqPfbF--8uw-1; Tue, 10 Aug 2021 16:39:42 -0400 X-MC-Unique: 65fBjrNeMviyqPfbF--8uw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7749D101C8A0; Tue, 10 Aug 2021 20:39:41 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 530D05C1A1; Tue, 10 Aug 2021 20:39:40 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-51-willy@infradead.org> References: <20210715033704.692967-51-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 050/138] mm/workingset: Convert workingset_activation to take a folio MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1811129.1628627979.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 21:39:39 +0100 Message-ID: <1811130.1628627979@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > This function already assumed it was being passed a head page. No real > change here, except that thp_nr_pages() compiles away on kernels with > THP compiled out while folio_nr_pages() is always present. Also convert > page_memcg_rcu() to folio_memcg_rcu(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Reviewed-by: David Howells