Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20210715033704.692967-53-willy@infradead.org>
References: <20210715033704.692967-53-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     dhowells@redhat.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v14 052/138] mm: Add folio_raw_mapping()
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1811269.1628628133.1@warthog.procyon.org.uk>
Date:   Tue, 10 Aug 2021 21:42:13 +0100
Message-ID: <1811270.1628628133@warthog.procyon.org.uk>
Precedence: bulk

Matthew Wilcox (Oracle) <willy@infradead.org> wrote:

> Convert __page_rmapping to folio_raw_mapping and move it to mm/internal.h.
> It's only a couple of instructions (load and mask), so it's definitely
> going to be cheaper to inline it than call it.  Leave page_rmapping
> out of line.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

I assume you're going to call it from another source file at some point,
otherwise this is unnecessary.

Apart from that,

Reviewed-by: David Howells <dhowells@redhat.com>