Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20210715033704.692967-62-willy@infradead.org>
References: <20210715033704.692967-62-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     dhowells@redhat.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v14 061/138] mm/migrate: Add folio_migrate_flags()
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1812508.1628629765.1@warthog.procyon.org.uk>
Date:   Tue, 10 Aug 2021 22:09:25 +0100
Message-ID: <1812509.1628629765@warthog.procyon.org.uk>
Precedence: bulk

Matthew Wilcox (Oracle) <willy@infradead.org> wrote:

> +	if (folio_test_error(folio))
> +		folio_set_error(newfolio);
> +	if (folio_test_referenced(folio))
> +		folio_set_referenced(newfolio);
> +	if (folio_test_uptodate(folio))
> +		folio_mark_uptodate(newfolio);
> +	if (folio_test_clear_active(folio)) {
> +		VM_BUG_ON_FOLIO(folio_test_unevictable(folio), folio);
> +		folio_set_active(newfolio);
> +	} else if (folio_test_clear_unevictable(folio))
> +		folio_set_unevictable(newfolio);
> +	if (folio_test_workingset(folio))
> +		folio_set_workingset(newfolio);
> +	if (folio_test_checked(folio))
> +		folio_set_checked(newfolio);
> +	if (folio_test_mappedtodisk(folio))
> +		folio_set_mappedtodisk(newfolio);

Since a bunch of these are bits in folio->flags and newfolio->flags, I wonder
if it's better to do use a cmpxchg() loop or LL/SC construct to transfer all
the relevant flags in one go.

Apart from that:

Reviewed-by: David Howells <dhowells@redhat.com>