Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20210715033704.692967-68-willy@infradead.org>
References: <20210715033704.692967-68-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     dhowells@redhat.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v14 067/138] mm/writeback: Add folio_start_writeback()
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1812884.1628630220.1@warthog.procyon.org.uk>
Date:   Tue, 10 Aug 2021 22:17:00 +0100
Message-ID: <1812885.1628630220@warthog.procyon.org.uk>
Precedence: bulk

Matthew Wilcox (Oracle) <willy@infradead.org> wrote:

> Rename set_page_writeback() to folio_start_writeback() to match
> folio_end_writeback().  Do not bother with wrappers that return void;
> callers are perfectly capable of ignoring return values.
> 
> Add wrappers for set_page_writeback(), set_page_writeback_keepwrite() and
> test_set_page_writeback() for compatibililty with existing filesystems.
> The main advantage of this patch is getting the statistics right,
> although it does eliminate a couple of calls to compound_head().
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: David Howells <dhowells@redhat.com>