Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3906530pxt; Tue, 10 Aug 2021 14:25:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpxBAebfTBi0bfSLZuWFO4+2X+Q2DhBRkpzL2j+kCB8nYGHnS27PLCk160fNm5PRmtxMpG X-Received: by 2002:a92:c601:: with SMTP id p1mr63117ilm.284.1628630712207; Tue, 10 Aug 2021 14:25:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628630712; cv=none; d=google.com; s=arc-20160816; b=qps+oyaV7ckkfiOXMs2NDpfAYdzPifEqvWRvZKAaaJ1Qa/SCWucQbuarrUPWQyKx3E ajazS+0q7/9nZosCJzTxoN3ZW7NlfkWtlSXuIr5FIyIvA3jipKve88WzEe0LDFw6e8IV ups5Lf4SYtkYPCo3LQ4CQu50CAT8KnrjjsC8YdpwgaaEPOqWPfL63D472MLjCK+dR2nK LuY1ZV+5Jc3IZwB2Yc/Eybw/9rlzbkG/iaDxnESbTk/hq69TuxP67SWetDUNLnOna36+ Hu1M9d5+Rzr1JqwDYKq7T0LchHDCb2J7CtEt6mbkeTDBwcb7+jf3PxqUBjcjint13aRX foQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=Jk2IhlnlOCt1ZKtSeYx6ofnITIH2EWYZO/2dRAfdcPU=; b=upVT8VQzvOujJYJIHL0dJf6FRIWdDSwH0gdBIMtoUe/0GFUlVJQXT3CzjiCZuHhmmM RWmwtx70jg97zIHnpZETHoMQ3t9411bs61kGZ7KSZEjSWIyhJZIv+vT7NtlfNqcFzW5n IONFCYBM6JcluUxl+OZx+iWJFF1YJZsIP4jrEXuw+jNrQWkPrX8QxwhciAvQngqixaNu uJALoU6cRXV4xbANt+fkl2c+JsWTVN4sDCx3MQfIsjW4Zxv4QQciNC+Kgzp6cZogprlV o+dA8gTigo6wrozTEYKZfMvsJoEQJodTOOSkFR744tWm8U+BSUUgeJWbU8RHoMdqzyPA JQBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D3YrG+XC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i20si24448488jaj.74.2021.08.10.14.25.00; Tue, 10 Aug 2021 14:25:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D3YrG+XC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234647AbhHJVWp (ORCPT + 99 others); Tue, 10 Aug 2021 17:22:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23645 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbhHJVWp (ORCPT ); Tue, 10 Aug 2021 17:22:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628630542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jk2IhlnlOCt1ZKtSeYx6ofnITIH2EWYZO/2dRAfdcPU=; b=D3YrG+XC5QhRb6pDXLO4y3rItCvQtOQJXOztVnDTs016B+9yvm0I+Ox0Jum+L43/yM5lYi U3xBilWDjkkf2MaxwZwUsXG/sVFAFdei4FMVls/QWolXGdvILi5/g9CCVACieYaZ7OZFeK Icw58hKMbaeq9tgVLxCY2P+LeGCBAuM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242--Ht1JF46PyORuJLBuAinOA-1; Tue, 10 Aug 2021 17:22:20 -0400 X-MC-Unique: -Ht1JF46PyORuJLBuAinOA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D20B0185302E; Tue, 10 Aug 2021 21:22:19 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF4EE60BF1; Tue, 10 Aug 2021 21:22:18 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-73-willy@infradead.org> References: <20210715033704.692967-73-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 072/138] mm/writeback: Add folio_account_cleaned() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1813184.1628630537.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:22:17 +0100 Message-ID: <1813185.1628630537@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > Get the statistics right; compound pages were being accounted as a > single page. This didn't matter before now as no filesystem which > supported compound pages did writeback. Also move the declaration > to filemap.h since this is part of the page cache. Add a wrapper for > account_page_cleaned(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Reviewed-by: David Howells