Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3908326pxt; Tue, 10 Aug 2021 14:28:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4eVAOs3rXN+eFztgXRuoOqJQ4eSb90eW01h390sq8zFEv+BWoYlv2EMAlpafc5UXaFWvH X-Received: by 2002:aa7:c3cf:: with SMTP id l15mr7145991edr.83.1628630905643; Tue, 10 Aug 2021 14:28:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628630905; cv=none; d=google.com; s=arc-20160816; b=OBN1qedSp5hmLL8u8Y8tRRnZrVWHFmo/hiJfbDWZ5kFx9nhFHt3czacC9vvnSiBI3G mzfzw679AshXYhUKExdRWocmH9UBa8Uy/At2r0aY2Pjm/U7fWHS1Yhwf8RZ9Q8kAehGZ MspOORSMI9qYnsSwTThYCPbydieq5t7UhBsma+qbvKCftKn/BSPGh5dvonMbgs0XVizv uYu8j22DAfYdz2Yi8I5up9RbBcoxmu4TT7exf+mzSy3BZlJ/gT49kFAVDE7898vgQhff xmwduTQumn5ueWK4Or77a1s2fXP+U3709ebCQqAQnx6Zb0Hz4mKDz5d9hZaUe4NCkcNg RQVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=Zl+SFxMBURzTNx0iFxg9wDAN9QWXIbjsgbL3OqA/y9s=; b=FXzhWtKoWjGejCbFE9vauinWF9GlLvr5ZH23lqFMMDO2540ie5i5vCYk5s5VS40q3L S0E65NKP536p4/xOYkY8U6ViiTrcjfhSz3W7LUmLQcO3Trg6oSST+6dwQdeA6Vr54fZK Z69hGfl8s2wcKMpfdk7Ky1VMm6riVOCuBjj5m2/lE7fYBSE5bx4/jZKFpzHSrXR0+0QU 9wc2MloND7i0HgjCbc/8vJn4FhCJUR9DWrweDIfagpZ//oH1aNtIWJQOqQxDOF3azZB9 mLAaj6o36G3ZBLX/10pfaF+iQfbtTmsarD5ForQeexxo4IdFwLMKuOnYYbt/JAJTrCjP VaHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hw0V2fzF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pk3si21707900ejb.12.2021.08.10.14.28.00; Tue, 10 Aug 2021 14:28:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hw0V2fzF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234434AbhHJVYS (ORCPT + 99 others); Tue, 10 Aug 2021 17:24:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42300 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234564AbhHJVYP (ORCPT ); Tue, 10 Aug 2021 17:24:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628630632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zl+SFxMBURzTNx0iFxg9wDAN9QWXIbjsgbL3OqA/y9s=; b=Hw0V2fzFZz4tu0YFVANSA06bCmLRysLacD3PRqEgwWuRLmzvPLdCbwsnrhZefC/0gxVv1B 3oXctYYSixE/Jhs/32O+Zg542krEtbeN4sOLUXGxPni73TCCgUyGU6GbvaNKVcdh87MVXy cBqoKEYuydBMnpOrw2RkYTf0cek+LZU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-RnWwPulcPtu7SNFoNycdsQ-1; Tue, 10 Aug 2021 17:23:50 -0400 X-MC-Unique: RnWwPulcPtu7SNFoNycdsQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 767D7801B3C; Tue, 10 Aug 2021 21:23:49 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CCCB5D9C6; Tue, 10 Aug 2021 21:23:48 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-74-willy@infradead.org> References: <20210715033704.692967-74-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 073/138] mm/writeback: Add folio_cancel_dirty() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1813245.1628630627.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:23:47 +0100 Message-ID: <1813246.1628630627@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > Turn __cancel_dirty_page() into __folio_cancel_dirty() and add wrappers. > Move the prototypes into pagemap.h since this is page cache functionality. > Saves 44 bytes of kernel text in total; 33 bytes from __folio_cancel_dirty > and 11 from two callers of cancel_dirty_page(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Reviewed-by: David Howells