Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3909528pxt; Tue, 10 Aug 2021 14:30:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwF4yPy+VTxoFs9S6q0H11B8tOtwWAlpKClo18UHr0TFU9pA+yHnyzlxXWshiswl7wKlzou X-Received: by 2002:a17:906:3a46:: with SMTP id a6mr505376ejf.147.1628631044373; Tue, 10 Aug 2021 14:30:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628631044; cv=none; d=google.com; s=arc-20160816; b=hiqyjYxT3/k96Q8K0B8lRiKysKohkLFhOqq2rQVUG7tTMhCtHs2kfLCJZbmqA9viq5 8mc6pybxjRUCaR2k5+AXCA0fyUBFynIEBcFa2Duf+v4cACeFgAAN6F4DhngX9G0KMywq Ms8fRc2CkdSBl3BkzbZWRpUbmC7eE/kHA2c89stThivGRIBKaPLRDI0z/DWV1yuxOuzn GA3xsLR0mH68AFYmRnZ3YFkDmMf9x1x4vpQ/gh4EvpH//aLWjHVLZXwNhibNEdZdmDyo eq4+MmUTvB8NBplCnvWLXSaM9AL5wQ3AHwybSg2vw7a20Uzs60Rqy5lBqsWvZrD0tRN/ 7Xyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=600amtiqtF9qYaf5YhMYdAWHErj6zDZHEY3tP4H3S6k=; b=AtGnDljwQyymm7xVdwGPqCn00clDTUGvLvTefKMDEe/SlKJpm2NpZoq+KusfVB0Vs3 Dg1P7Q4EJyre/EQB/1w7wsFkxF0d+NwcyFRkakgrwTNBDll7XINB9jR/15xaZISg2vLE M6qTBGE00nlveau+5Ovc/3xdbNoplWnpntDu5LnNZBFZpJZOfOztRQG3qKQnGCmXtdsL BAUIdbGpd+ti5P9IbdsOzS7T1vPdWK2rvTwXHusc8Fru7pUChk7cbf9m8V9wDV9q5PET 7Th2usPgo07I+eczigsjnqDJRkxyZ0NL+YoPtleud5IOMhcPS4mwLSurnt/VfZ1tdlt2 9ElA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UOT5BGVI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si5261372eji.217.2021.08.10.14.30.18; Tue, 10 Aug 2021 14:30:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UOT5BGVI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234353AbhHJV0D (ORCPT + 99 others); Tue, 10 Aug 2021 17:26:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:22660 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233962AbhHJV0C (ORCPT ); Tue, 10 Aug 2021 17:26:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628630739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=600amtiqtF9qYaf5YhMYdAWHErj6zDZHEY3tP4H3S6k=; b=UOT5BGVIVHX0IgFhMpSH78GwEEwOHIH8D4zexuQEebugcGaZXbwuT/MX3JkJJ9shUV56Wt Gc1njvm7EOxIfQ9U2WQDnHyQ84H212+7Zq8d4ik0kiwe0LAm9++HxVmEgcgL3kZC+M7FxK NFktCs+XRq3EqBtHhCYda64hGLLIpH8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-boGVFplqPgGaurt5UjLA0w-1; Tue, 10 Aug 2021 17:25:38 -0400 X-MC-Unique: boGVFplqPgGaurt5UjLA0w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1508F101C8A0; Tue, 10 Aug 2021 21:25:37 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0248D1B472; Tue, 10 Aug 2021 21:25:35 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-76-willy@infradead.org> References: <20210715033704.692967-76-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 075/138] mm/writeback: Add folio_account_redirty() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1813347.1628630735.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:25:35 +0100 Message-ID: <1813348.1628630735@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > Account the number of pages in the folio that we're redirtying. > Turn account_page_dirty() into a wrapper around it. Also turn > the comment on folio_account_redirty() into kernel-doc and > edit it slightly so it makes sense to its potential callers. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Reviewed-by: David Howells