Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3917856pxt; Tue, 10 Aug 2021 14:46:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMS9Fcn0HBzn7PtprOB56P790IQjL22pu1dFI2lxkpsnlmlUmIfBxFA/0s45B+ZA/Xbeo8 X-Received: by 2002:a17:906:fa12:: with SMTP id lo18mr612060ejb.288.1628631983772; Tue, 10 Aug 2021 14:46:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628631983; cv=none; d=google.com; s=arc-20160816; b=c0UvUCIYi5OmRbnkQxVtqYw+r2aSC1uHoFf+HAkjmyawYE/DNFtpFwz2Ers66a3o0F zw6g5WMYNGGq6RjMA/96LpoN70mraRHqgo1nwyGHkLqnlWFmnacsGSQI1Fer62YA0Bxy yvjfQmSK6bZAFlwHn4J4YTivHAgJc9IK+QeubVHRC3qmTGxyxl0716Nu/pCmNYCicssP W73c9Kab91TO0koSOr0Eg9mz85iyG0uznxRwDN7/oGYSGGa7NFAN7nw7h9bC+oCICQcy eHXi03cynaTsOvN/zzNfvsdqfnCicmhsWpL6D71hnaKJNrzuUykEKI6hXlEQEnJPU+f9 MKBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=eNfeyWrqqbqel+aMF+OwDIK7E5m7g6wfz5VP9czGAHg=; b=XhnAOsB2ODO4h9jc5xls51Ayoo/6SHMAqneP2jJmmVINQB9irhW5iEzFFb1DMDsLlY w3o31aoDYAIUJfnTmI3AxXSwCuUD97JogdOqdi4ZJaJIncOVj9sa1utkTx7y6huPxiqo ZrX81g94k3+tWe8jKdhLMv4i9i1YQFktF3O1HDTR29d+UcQBkmIYQ1LuIMZ4ItMtcR6Q YFbl4ZMNDahYrbfCTJzTOy1xY+jMZ03nONDKCXg/Se2/Y4FPxjYRnOdrqU0tXuEnPeSu akIILwC4zVjxmLKgs6twtefqmvUOCxq0iJFeH0RoVOZKy6Ks12zPbjl4E9B6886EtN5a JAAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R1qKBXkc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cq1si21456020edb.603.2021.08.10.14.45.59; Tue, 10 Aug 2021 14:46:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R1qKBXkc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234531AbhHJVo7 (ORCPT + 99 others); Tue, 10 Aug 2021 17:44:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20671 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234103AbhHJVo4 (ORCPT ); Tue, 10 Aug 2021 17:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628631871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eNfeyWrqqbqel+aMF+OwDIK7E5m7g6wfz5VP9czGAHg=; b=R1qKBXkc9UEIkJFx2l108kpNQ65cWFi0d5AWSb1cvt/JZUbPFoi1AOHUYsck/jQbK4z3OC Ut6y9rHglClFi8owSN4u30hBlYCCcA6NrJSCM/s8GAs7Rv1k6meR11G+P9GXirJ5KOR4Mx XTafig4kkFM0sjmKF343kqXvFH2f1nQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-291-_jVYxBs6NEqvFFOjQ_xFDQ-1; Tue, 10 Aug 2021 17:44:30 -0400 X-MC-Unique: _jVYxBs6NEqvFFOjQ_xFDQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 03552760C0; Tue, 10 Aug 2021 21:44:29 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id D36355D6CF; Tue, 10 Aug 2021 21:44:27 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-83-willy@infradead.org> References: <20210715033704.692967-83-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 082/138] mm/lru: Convert __pagevec_lru_add_fn to take a folio MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1814230.1628631867.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:44:27 +0100 Message-ID: <1814231.1628631867@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > * looking at the same page) and the evictable page will be stranded > * in an unevictable LRU. Does that need converting to say 'folio'? Other than that: Reviewed-by: David Howells