Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3925051pxt; Tue, 10 Aug 2021 15:00:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0rV1X4hb935WCIgrrnZCr6nsOJFjMweEaYyJdv3OnA7fJfIMkSrEG58eiSwOEc2UUWUrY X-Received: by 2002:a02:866b:: with SMTP id e98mr29772158jai.48.1628632827918; Tue, 10 Aug 2021 15:00:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628632827; cv=none; d=google.com; s=arc-20160816; b=ITSrvJ+8ViL9mKbkenPCVTmpbAZ11dbZpsFF5nHVCs+lP3h3iwqVgOC55F1SLl/s0b uDLgZtPa6hgncr0/aW2ukrZs1mX7zGNqDPXUreNVJ/p59hVYbjwwn1My6U/5vM/3qY3J 8gbrFwzNKc1vrEDUp+B8sRpvFiTpFJVkNM3HpLuhwNkW/oMCyWK0AmilJpVyyzYd2h5A E/mp4LZrx+QPkfHd3kqZzed7Uw6+XZ8byXYGLBi/YJ+g736MwgCEuD4TkvPJFdhWfJnx hvIqYIT+sWuMGOBx1piXO4tzmqkRzIx2KnTqoJ6qz/1/yib5MLUbIzIS6+A26aHVXqtX aW1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=ElH7xQBolMkqBkTgOcSotCt04OkZm087iZKxD4bzejI=; b=IDz4eCDeRN2kKFSALuIoqVEfjT90yApRwKBGqAPVPPPSAuW1z6Ba24TY4LPMTOFqRn 4VLnP9dP8zBcV4VVMlKTRuwoGhEurbEMifbcYDCq7Jbzygva2ZiHUl4XW2/I3EXGGZUZ ha1UxVHE9I56/YYXMceubprpRlLu3rWIh9/f0RRXfx6sZH5ks3JNMy+YOnIUfV5rTj3u v0SQJjoqkKwnJKwqMLS/+sIa9VjTlM48+qUFuZ8LgBNiem4iSvYIwqEMDwkeZxRPalqQ 6y7lz+/jNedNhfYFx8Tl21uxCURqfi+unqYuG6qYiqpvgDXuYkfyAadYSb3LCCb87wVb qlbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bbH9HE7v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y26si23143504jar.1.2021.08.10.15.00.15; Tue, 10 Aug 2021 15:00:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bbH9HE7v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234315AbhHJV7v (ORCPT + 99 others); Tue, 10 Aug 2021 17:59:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34106 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231372AbhHJV7u (ORCPT ); Tue, 10 Aug 2021 17:59:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628632767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ElH7xQBolMkqBkTgOcSotCt04OkZm087iZKxD4bzejI=; b=bbH9HE7vj2Ogj9wLX+IFHmyzv79GjYfEHf0bFtKyUmGb2LeVAZY+Dllj96Uw1cO5DfhqUt q8ZUSxSkWQys9FIa53G2WaCOjmVOflXLJC1eM86Bv9Qaa+xvfsnLga+9xDtK8Mx0lz+DcU QSQ6yGVkBwX3Oo641lWeVV/YAZahzYM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-RjGCULpxP1iqN7XStS2Y_w-1; Tue, 10 Aug 2021 17:59:26 -0400 X-MC-Unique: RjGCULpxP1iqN7XStS2Y_w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9A6CF1009607; Tue, 10 Aug 2021 21:59:25 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7DF7A421F; Tue, 10 Aug 2021 21:59:24 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-87-willy@infradead.org> References: <20210715033704.692967-87-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 086/138] mm/filemap: Add filemap_add_folio() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1814869.1628632763.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:59:23 +0100 Message-ID: <1814870.1628632763@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > Convert __add_to_page_cache_locked() into __filemap_add_folio(). > Add an assertion to it that (for !hugetlbfs), the folio is naturally > aligned within the file. Move the prototype from mm.h to pagemap.h. > Convert add_to_page_cache_lru() into filemap_add_folio(). Add a > compatibility wrapper for unconverted callers. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Reviewed-by: David Howells