Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3926393pxt; Tue, 10 Aug 2021 15:02:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDaJJmU2RsO4G6jlQ5tUyWjCn4P6DjM0fzDKo5o7P1Zr/v2mdqhCk2dCFwR6bMvLjuVv7G X-Received: by 2002:a92:8e41:: with SMTP id k1mr765047ilh.276.1628632949347; Tue, 10 Aug 2021 15:02:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628632949; cv=none; d=google.com; s=arc-20160816; b=lteKT8ZvbHuHeg3cjHCqLXIDBODBSRBAxx/oeAM+oy9xf88/2W55Qd9xro4ArDOHWl t/HQAck5zh/R7ewZN4jPTgLEZns9bq2Fh63lflpr+azAgE8+A9qvmBClrHnSF9r/EIEc 5BpoYI/cLqEE+P0YSHWXjgKLKv4ToU07FTi04pKhG7E6fD78aOVCuE5zOQGVrI2RRRaV 7fEQE57WeYqlt3hanQM2IUJHdcyoIGizb8SoG+8ob7eZV6NT1K4ynwPjta/U9Uk5Q/aU VxHWVO1KImpZKbyvHoUfZcDMd3xwjhMEfbDVcIQ5d5wFEJJtcmV7aZotUDJqX905zuxj njCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=TKI2CnsdvFNjqndaNstsi5v6QE1bxINGXNExmIgLnIk=; b=J+SlDqZIA+Vt1F3z5ALZ97BWCJlLAh+olqXKgRY072/sra0bXyUJsnYrmfj9R+XNpG 8MnPzj6NEfKRVX9r8/O64zVfOl0M/O9S197dflu5/fqhTT1mHaLrp3rNLiJcxZy/spYK nFgAIiTIfTQBMR7F0gxYNKPe36/tnyQWRlP5D9ks0nBoqRhmoWH0y7Y86BO38vadLZKM 03Zj45K2Q8LYLWWSWCEgNePckmLZtIN5XUw9qu04Ydg9dP0NFktEbf8ZtUbnVcgNzBA4 aKN07T2aK9vsXA9bn1J6z3F4hGsH8U8b+2IDxw4x6WNXGCq7SYG1DL05512Z85Ji3NPD xDWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=RQklxLJz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y26si23143504jar.1.2021.08.10.15.02.15; Tue, 10 Aug 2021 15:02:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=RQklxLJz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235032AbhHJWBc (ORCPT + 99 others); Tue, 10 Aug 2021 18:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235069AbhHJWBb (ORCPT ); Tue, 10 Aug 2021 18:01:31 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 424FBC061765 for ; Tue, 10 Aug 2021 15:01:09 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id k2so23186629plk.13 for ; Tue, 10 Aug 2021 15:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TKI2CnsdvFNjqndaNstsi5v6QE1bxINGXNExmIgLnIk=; b=RQklxLJzaKm5M8XYcoIxx2s+VbZJEnssRgd9fY2NkyKOraI6mAZUM1sUxYZfk1KDOy h0J+BEVcvhbGgefSvBtebh1jgJwBfZifBPxJppyifTFn+V58U1xSvikJhycfXu08UTAp hfky0dx4D3LjAWP8lxEbt3sLJEQ8fodBmasFbE+/vNIaakBKdwT9IajR0vc3fJ0iIDem Ics4fvJ8RWGrZuVuGqvaQNXCs9enGUASo4+cM1OHo1TmHKtwxfO2iwtkomzWk5AG01o/ zRUnBmUJogsp55aBu7PIzzTwFhiLXqMxVfi6McoCwfRbJCP8c7vDTZdFotBEI+CC/e2T 8b7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TKI2CnsdvFNjqndaNstsi5v6QE1bxINGXNExmIgLnIk=; b=YSN4OnthZnSoWesjhq0Ye6WTDUiUrZItglWfTtDpwBmCAH2LngtjjVsG06Y0xJt2be LgmropBwNuvu+8p+kY2YhsSSwHkP2tQmSuwZAk1VQgjt6QHr+f3BxUHRhexSeUfl40i/ sE6BgiXYLuXjM7yBF7WFtqHaBpLNOrT+zx/0T5R0qoQ9KcdaKJrKR7lXtwEx43GfRhew FAL7DjfXgLDgknjBdBK7TFkFRWN50qJq/SNWVYcOa9U7Rozr1ktywLs94tin18ckvX2h CrMep0v0rO45LXwA4kCDwa/HiDILqNPJOb6YEu5LAt+RRvYtiWNarmdKuDtE0cCHVdY8 +RhA== X-Gm-Message-State: AOAM532a8o3r69GEmB7ekO15rM8mDQS5hWqckHzKdPTLLg7dXtLaKSoa Y1KHsPLSMV0F88WWDnkiNjtrtejd17glWZV/uQgcDy8cHjlmpA== X-Received: by 2002:a17:90a:1b0d:: with SMTP id q13mr7125701pjq.217.1628632868528; Tue, 10 Aug 2021 15:01:08 -0700 (PDT) MIME-Version: 1.0 References: <20210805043503.20252-1-bvanassche@acm.org> <20210805043503.20252-4-bvanassche@acm.org> <20210809145953.GB21234@lst.de> In-Reply-To: <20210809145953.GB21234@lst.de> From: Brendan Higgins Date: Tue, 10 Aug 2021 15:00:57 -0700 Message-ID: Subject: Re: [PATCH v4 3/3] configfs: Add unit tests To: Christoph Hellwig Cc: Bart Van Assche , Joel Becker , linux-kernel@vger.kernel.org, Bodo Stroesser , "Martin K . Petersen" , Yanko Kaneti Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 9, 2021 at 7:59 AM Christoph Hellwig wrote: > > > text and binary attribute support. This is how I run these tests: > > > > set -e > > if [ -e .config ]; then > > make ARCH=um mrproper > > fi > > if [ ! -e .kunit/.kunitconfig ]; then > > cat <.kunit/.kunitconfig > > CONFIG_CONFIGFS_FS=y > > CONFIG_CONFIGFS_KUNIT_TEST=y > > CONFIG_KUNIT=y > > CONFIG_PROVE_LOCKING=y > > CONFIG_SYSFS=y > > CONFIG_UBSAN=y > > EOF > > cp .kunit/.kunitconfig .kunit/.config > > fi > > ./tools/testing/kunit/kunit.py run > > This is very useful documentation, but shouldn't it go into a README.kunit > or similar instead of a commit message? You could also put this in a .kunitconfig specific to your subsystem like we did for ext4: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ext4/.kunitconfig You can then build using this .kunitconfig with something like: ./tools/testing/kunit/kunit.py run --kunitconfig=fs/ext4/.kunitconfig > > +config CONFIGFS_KUNIT_TEST > > + bool "Configfs Kunit test" if !KUNIT_ALL_TESTS > > + depends on CONFIGFS_FS && KUNIT=y > > + default KUNIT_ALL_TESTS Cheers!