Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3928976pxt; Tue, 10 Aug 2021 15:06:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+Mc37FJMIQyH3tG5Q9D636onb/aLCxPNShE/Lf9RawvhrOfMrqlxynQ9r9c/APXX2Ch/h X-Received: by 2002:a92:c605:: with SMTP id p5mr107626ilm.209.1628633191764; Tue, 10 Aug 2021 15:06:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628633191; cv=none; d=google.com; s=arc-20160816; b=wwL1GPJQOvfs8yZhdBUAFga/i7OGscmd4d/uLOZNcov4qFQWJyo0A2ejuAldEZ4tT7 IDwnErlo4IotYF3rA9hC6vW1EdDNfYThX9z4zUiihiCK7hdjJF3FA4foemgcb5O5ZI8t bXauPeOwiMjUFIrAZJxhmQ6qFBASvZBQIcuNwtyIqPin4vnocMxjexSoRz/nY0PU+MG5 UcxO5QBPgw3tfpvw8FhDaAKZhy/LZrUIy7wOvReysoMwvyGI9KQR0hwNSgQzBSOXLD2Y UiIkROWNJHWrZ8vHyXcFdjIMvCAJ4aYDZl34sCzueb2uSeuTILC0+SeFP5GmrCC/yB/0 vSOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=KlRVFcfsiPZEuz6J4GfZil/2Tt8hvbgnI3Yitqd2JX8=; b=pcLFmd3U2KsKwvt3JASpQZqJDZEz+pr4IVuFmgkK/n/hgk1zAOCsWqzBDZT7Gfqkhc TwQdwNiuSoGs/XLysy4LV911k7M5KlQE5/hchAQx9olGr0TRv3Kzzw/pSf/BwWL1EV2o 89zsU4y6DxGKkb9/fPqEeP+Fjp4uApleCiU6Z9EbA6c2/YmOd3pgSieen3Js1Gi1hFlm ujgr7TjYhg+1MgqWthIevUq3kNHyb1LYTecww46EOQVV/Gn6UiF7u5Qoy/2jB7WCeZKF lE3aVx4BXHiKhTuMtptyMYePAG0OQOyEDnjMs3KhBkyP6k3ujnjUwEi8JohAuFTKPMLi PGlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gtxVXoeW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r6si25059735iov.48.2021.08.10.15.06.20; Tue, 10 Aug 2021 15:06:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gtxVXoeW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235038AbhHJWGB (ORCPT + 99 others); Tue, 10 Aug 2021 18:06:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34261 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234814AbhHJWGA (ORCPT ); Tue, 10 Aug 2021 18:06:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628633137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KlRVFcfsiPZEuz6J4GfZil/2Tt8hvbgnI3Yitqd2JX8=; b=gtxVXoeWiDTShqsmBlLWZiGfwpCRevDmHv9I7Lrs4b2mKUKuyCR5vyGWIqD1StlT2mnf02 ryTQt39wAPvOcFgZjuIcaUSuWpAyCyFR4qCoF6bY4J8Dk7ARgm8ux9t/dI94dxKmPjxAF4 yZAajtXQwB6atTWJTqJH75X8rAho1Cc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-fMf0dIkKOKW7rilvcogtaw-1; Tue, 10 Aug 2021 18:05:36 -0400 X-MC-Unique: fMf0dIkKOKW7rilvcogtaw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E8258042EB; Tue, 10 Aug 2021 22:05:35 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 854FC5D9CA; Tue, 10 Aug 2021 22:05:34 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-89-willy@infradead.org> References: <20210715033704.692967-89-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 088/138] mm/filemap: Add filemap_get_folio MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1815134.1628633133.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 23:05:33 +0100 Message-ID: <1815135.1628633133@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > filemap_get_folio() is a replacement for find_get_page(). > Turn pagecache_get_page() into a wrapper around __filemap_get_folio(). > Remove find_lock_head() as this use case is now covered by > filemap_get_folio(). > > Reduces overall kernel size by 209 bytes. __filemap_get_folio() is > 316 bytes shorter than pagecache_get_page() was, but the new > pagecache_get_page() is 99 bytes longer, one presumes. > . > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: David Howells