Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp4073626pxt; Tue, 10 Aug 2021 19:28:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzAJBm1QwjjHk5HjdM9RSSu45g9WZOuzC5m/RFCPIenmhu1Ll0EsktyRlnGJ7F0d62wyJr X-Received: by 2002:aa7:c606:: with SMTP id h6mr1711499edq.363.1628648931795; Tue, 10 Aug 2021 19:28:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628648931; cv=none; d=google.com; s=arc-20160816; b=ii0oowXc1Yr+53sYyIuS0h5NWmnKrXDBvmwo1yUZdCX/fR925aD624yJSbUORE9iBx T1N+TdNfQS9R1eWJI1tS/eA6vwUdWHNErIMZcZ0E40YEytJGA1xHXnrE+QJkAPnkGgbz Qp1Ef5/P4YDWsBpXfaPbpLuJ2fc9hOLfsL8wXVtu6tzqoe03dEaLymR5iPqvCmDeh4FR JcFMYYrEP5JAFnRo0cxb2ylklpkNiJs1Ze8tRNehY3wzPLXq0d6O6lUL13uRZKJHNe7d jiesAiLd2HhrzAFkwdIxV3ZWbO/ka2uF2RaXwHQ55Xv+xkWXnn1Y/awiocIMDtykaaBY WYJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=M7ABmyJsxGwiJCfUUfU3UN9zaJoWL+WLYQ0wCYfuKKI=; b=IyR0dEgQdexsBhz0rWfpM3BdTYNPEo5uPjvsxgHsLnWuZhgZCoBnyPhKYOlcp0Oe80 jRL+u+6O4R8+PlCHlTr1n47gk5AR5zG1qKeba1lG+sLJ96Cebt17jJVr6xaNe5zU9OlS 7Kx0o33XKAAKiLvCagqZVPxO1VVRzY5q31DlKpvh/BOfnOF8sSoFF7YxVW+YQ0Q3ctcC jMEL4n+H+IgScfEKjSX/JSPjFkjGBUs/hCxQExk0Syz1NKrwZ0uF282uhdZN1InhWZOW b8ZWDXevzWTqUL9ZxChLgSSoyyiaYhirATPR4fHWXJzihVzaqzPHt6g8lKfgHSE+/6Df 1bKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=i3uizKnK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p7si23460857edw.488.2021.08.10.19.28.26; Tue, 10 Aug 2021 19:28:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=i3uizKnK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231789AbhHKCYA (ORCPT + 99 others); Tue, 10 Aug 2021 22:24:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34285 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230099AbhHKCX7 (ORCPT ); Tue, 10 Aug 2021 22:23:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628648616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M7ABmyJsxGwiJCfUUfU3UN9zaJoWL+WLYQ0wCYfuKKI=; b=i3uizKnKIw/HwmwqXgUgYohEIdHYOrTICIdNpyoQzXXDLIC5IojTkLfnLH+lW1y5pc/W0m WGx9ZkPA9RkyZY6wM95TugG+jkRipfFOexmQGVGE4P158c8aB9LWboyWeemGPsn+kyiCLE IIJhWlTYFKl3UH8L8y4TYCH/rd9tv5w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-350-NCQm-SeDOkKnlT9w_3IBvw-1; Tue, 10 Aug 2021 22:23:33 -0400 X-MC-Unique: NCQm-SeDOkKnlT9w_3IBvw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 40D24824F83; Wed, 11 Aug 2021 02:23:31 +0000 (UTC) Received: from localhost (ovpn-12-209.pek2.redhat.com [10.72.12.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FCE55D740; Wed, 11 Aug 2021 02:23:29 +0000 (UTC) Date: Wed, 11 Aug 2021 10:23:27 +0800 From: Baoquan He To: Tom Lendacky , rientjes@google.com Cc: Robin Murphy , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, rppt@linux.ibm.com, brijesh.singh@amd.com, kexec@lists.infradead.org, iommu@lists.linux-foundation.org, m.szyprowski@samsung.com Subject: Re: [PATCH RFC 0/2] dma-pool: allow user to disable atomic pool Message-ID: <20210811022327.GF23322@MiWiFi-R3L-srv> References: <20210624052010.5676-1-bhe@redhat.com> <20210624092930.GA802261@MiWiFi-R3L-srv> <8b3d4e02-6e94-ad59-a480-fed8e55c009a@arm.com> <20210805065410.GA2051@MiWiFi-R3L-srv> <5df93c4e-ffdd-88c5-db4a-1a09826d047a@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5df93c4e-ffdd-88c5-db4a-1a09826d047a@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/21 at 03:52pm, Tom Lendacky wrote: > On 8/5/21 1:54 AM, Baoquan He wrote: > > On 06/24/21 at 11:47am, Robin Murphy wrote: > >> On 2021-06-24 10:29, Baoquan He wrote: > >>> On 06/24/21 at 08:40am, Christoph Hellwig wrote: > >>>> So reduce the amount allocated. But the pool is needed for proper > >>>> operation on systems with memory encryption. And please add the right > >>>> maintainer or at least mailing list for the code you're touching next > >>>> time. > >>> > >>> Oh, I thoutht it's memory issue only, should have run > >>> ./scripts/get_maintainer.pl. sorry. > >>> > >>> About reducing the amount allocated, it may not help. Because on x86_64, > >>> kdump kernel doesn't put any page of memory into buddy allocator of DMA > >>> zone. Means it will defenitely OOM for atomic_pool_dma initialization. > >>> > >>> Wondering in which case or on which device the atomic pool is needed on > >>> AMD system with mem encrytion enabled. As we can see, the OOM will > >>> happen too in kdump kernel on Intel system, even though it's not > >>> necessary. > > > > Sorry for very late response, and thank both for your comments. > > > >> > >> Hmm, I think the Kconfig reshuffle has actually left a slight wrinkle here. > >> For DMA_DIRECT_REMAP=y we can assume an atomic pool is always needed, since > >> that was the original behaviour anyway. However the implications of > >> AMD_MEM_ENCRYPT=y are different - even if support is enabled, it still > >> should only be relevant if mem_encrypt_active(), so it probably does make > >> sense to have an additional runtime gate on that. > > > >> > >> From a quick scan, use of dma_alloc_from_pool() already depends on > >> force_dma_unencrypted() so that's probably fine already, but I think we'd > >> need a bit of extra protection around dma_free_from_pool() to prevent > >> gen_pool_has_addr() dereferencing NULL if the pools are uninitialised, even > >> with your proposed patch as it is. Presumably nothing actually called > >> dma_direct_free() when you tested this? > > > > Yes, enforcing the conditional check of force_dma_unencrypted() around > > dma_free_from_pool sounds reasonable, just as we have done in > > dma_alloc_from_pool(). > > > > I have tested this patchset on normal x86_64 systems and one amd system > > with SME support, disabling atomic pool can fix the issue that there's no > > managed pages in dma zone then requesting page from dma zone will cause > > allocation failure. And even disabling atomic pool in 1st kernel didn't > > cause any problem on one AMD EPYC system which supports SME. I am not > > expert of DMA area, wondering how atomic pool is supposed to do in > > SME/SEV system. > > I think the atomic pool is used by the NVMe driver. My understanding is > that driver will do a dma_alloc_coherent() from interrupt context, so it > needs to use GFP_ATOMIC. The pool was created because dma_alloc_coherent() > would perform a set_memory_decrypted() call, which can sleep. The pool > eliminates that issue (David can correct me if I got that wrong). Thanks for the information. While from the code comment around which atomic pool is requested, on amd system it's used to satisfy decrypting memory because that can't block. Combined with your saying, it's because NVMe driver need decrypted memory on AMD system? void *dma_direct_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle, gfp_t gfp, unsigned long attrs) { ...... /* * Remapping or decrypting memory may block. If either is required and * we can't block, allocate the memory from the atomic pools. */ if (IS_ENABLED(CONFIG_DMA_COHERENT_POOL) && !gfpflags_allow_blocking(gfp) && (force_dma_unencrypted(dev) || (IS_ENABLED(CONFIG_DMA_DIRECT_REMAP) && !dev_is_dma_coherent(dev)))) return dma_direct_alloc_from_pool(dev, size, dma_handle, gfp); ...... } Looking at the those related commits, the below one from David tells that atomic dma pool is used when device require non-blocking and unencrypted buffer. When I checked the system I borrowed, it's AMD EYPC and SME is enabled. And it has many pci devices, as you can see, its 'ls pci' outputs 113 lines. But disabling the three atomic pools didn't trigger any error on that AMD system. Does it mean only specific devices need this atomic pool in SME/SEV enabling case? Should we add more details in document or code comment to make clear this? commit 82fef0ad811fb5976cf36ccc3d2c3bc0195dfb72 Author: David Rientjes Date: Tue Apr 14 17:05:01 2020 -0700 x86/mm: unencrypted non-blocking DMA allocations use coherent pools When CONFIG_AMD_MEM_ENCRYPT is enabled and a device requires unencrypted DMA, all non-blocking allocations must originate from the atomic DMA coherent pools. Select CONFIG_DMA_COHERENT_POOL for CONFIG_AMD_MEM_ENCRYPT. Signed-off-by: David Rientjes Signed-off-by: Christoph Hellwig diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 1d6104ea8af0..2bf2222819d3 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1520,6 +1520,7 @@ config X86_CPA_STATISTICS config AMD_MEM_ENCRYPT bool "AMD Secure Memory Encryption (SME) support" depends on X86_64 && CPU_SUP_AMD + select DMA_COHERENT_POOL select DYNAMIC_PHYSICAL_MASK select ARCH_USE_MEMREMAP_PROT select ARCH_HAS_FORCE_DMA_UNENCRYPTED [~]# lscpu Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian CPU(s): 32 On-line CPU(s) list: 0-31 Thread(s) per core: 2 Core(s) per socket: 16 Socket(s): 1 NUMA node(s): 4 Vendor ID: AuthenticAMD BIOS Vendor ID: AMD CPU family: 23 Model: 1 Model name: AMD EPYC 7351P 16-Core Processor BIOS Model name: AMD EPYC 7351P 16-Core Processor Stepping: 2 CPU MHz: 2395.439 BogoMIPS: 4790.87 Virtualization: AMD-V L1d cache: 32K L1i cache: 64K L2 cache: 512K L3 cache: 8192K ...... [~]# lspci| wc -l 113 > > > > > > Besides, even though atomic pool is disabled, slub page for allocation > > of dma-kmalloc also triggers page allocation failure. So I change to > > take another way to fix them, please check v2 post. The atomic pool > > disabling an be a good to have change. > > > > Thanks > > Baoquan > > >