Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: URTmqXauW8LtgQw3OLK8jdP5QHA+wAPveQSJQ6CwxF4JtVHlodg73idhhwrDcwyZBxYtB0tnye
 7RiQ9REStlKANdkY2Z372pcqo0sUtXIw0zjpFWv+K4zmi2aZ9oGkYlH1MA/vRBv/pjBxUNt7E8
 4wl52zRIGPp+EnHunAZlkvZIPCiQ0/CRJF1QSvQupTnBIW3bXtmCL9sst5AJbKOKka8RjTAQ1O
 M+G6QxRbv0y2EL3s29WJmCbXUXiZoUW9QfJeLNXgPVKOuIqUBQbEio9EIBulgM83kM/5LPJG5n
 Hr416HLWG9ym6bucwes+5Ur0
IronPort-PHdr: A9a23:U2DlRxWa3eejId7dr2xNDhmnHznV8Kz2VTF92vMcY1JmTK2v8tzYM
 VDF4r011RmVB92du6oP1LSempujcFRI2YyGvnEGfc4EfD4+ouJSoTYdBtWYA1bwNv/gYn9yN
 s1DUFh44yPzahANS47xaFLIv3K98yMZFAnhOgppPOT1HZPZg9iq2+yo9JDffRlEiCC+bL9uI
 xm7rwTcvdQKjIV/Lao81gHHqWZSdeRMwmNoK1OTnxLi6cq14ZVu7Sdete8/+sBZSan1cLg2Q
 rJeDDQ9LmA6/9brugXZTQuO/XQTTGMbmQdVDgff7RH6WpDxsjbmtud4xSKXM9H6QawyVD+/9
 KpgVgPmhzkbOD446GHXi9J/jKRHoBK6uhdzx5fYbJyJOPZie6/Qe9YaRWtaXsZKVixBBIy8Z
 JYRAeQYIO1YoYj9qEUKrRSjGAKgAO3ixiNNinLwwKY00fkuERve0QMvEdIBsnTaotv2OqkPT
 e+417XIwSnZYv9KxTvx9IrFfxY8qv+MR7Jwds/RxFEtGAPEj1SQqZHlPzSI3esOs2iU9etgX
 v+ohm8nqgBxoiKgxsYwhoXViI8Y0U3E+jljwIovO9K3VVN7bMeiHZBNuC6UK5F4Tdk+Q2F0p
 ik60LsGtIamcSUXx5oqxBrSZvybf4aG7RzuVvucLCl5iX94dr+yhBm//0euxODgSsS501RHo
 y5Zn9XQqH0Ayx3e58ubR/Z5+EqqxDWB1xjL5+1aPUw5kbDXJp0hz7IqiJYfrEXOEjX0lUnri
 qKda18q9fKy6+v9Z7XrvpqcN4hphQ7gKqkugcm/AfggMggJQmib5fyw1L398k39R7VHlvg2n
 bPYsJDePMgbvqy5DxJM3oYt6RuzEi2q0NsfnXkAI1JFfAyIg5L1NFHJJfD0Ffa/g1Kynzd33
 /3KIKHtD5HXInXAkLrtZ6hx51NdxQYpz91T+opYCrQbL/LyXk/xusbYDhg8MwGsw+fmCdV92
 ZkfWW6THqOUPrjfsUKU6eI1OeWDepIauCvlJ/g/+/HulWM5mUMafaSx2ZsXaXa4HulpIkmAY
 nrjnM0BEWEUsQo6V+HqllKCXiBJZ3qoXKIz+Cs7CIS4AofHXIyth6aB3CjoVrNMYWUTO1GeE
 WrvP7eEUvZEPDOAIsZgymRffaWqUcks2Qz451yy8KZuMueBon5QjpnkztUgorKL/Sw=
IronPort-HdrOrdr: A9a23:5tqW/avFhgOGEoosZfaEj6yd7skDc9V00zEX/kB9WHVpmwKj5q
 aTdZUgpGbJYVkqKRQdcLy7Scu9qDbnhP1ICOoqXItKPjOW3FdARbsKheDfKn/bexEWndQtsp
 uIsJISNDQzNzJHZArBjDVQ2uxOruW6zA==
MIME-Version: 1.0
References: <20210723003607.64179-1-yzhai003@ucr.edu> <20210811035405.17382-1-yzhai003@ucr.edu>
In-Reply-To: <20210811035405.17382-1-yzhai003@ucr.edu>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Tue, 10 Aug 2021 21:19:20 -0700
Message-ID: <CABvMjLRj-ofVoNpOvT+DPOdW-=L52KbsRYeaKv=MTYfSJPZNBA@mail.gmail.com>
Subject: Re: [PATCH v4] media: atomisp: fix the uninitialized use and rename "retvalue"
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Juan Antonio Aldea-Armenteros <juant.aldea@gmail.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk

Hi All:
For your information, I update my signed-off zone using my full name
"Yizhuo Zhai"

On Tue, Aug 10, 2021 at 8:54 PM Yizhuo Zhai <yzhai003@ucr.edu> wrote:
>
> From: Yizhuo <yzhai003@ucr.edu>
>
> Inside function mt9m114_detect(), variable "retvalue" could
> be uninitialized if mt9m114_read_reg() returns error, however, it
> is used in the later if statement, which is potentially unsafe.
>
> The local variable "retvalue" is renamed to "model" to avoid
> confusion.
>
> Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
> Signed-off-by: Yizhuo Zhai<yzhai003@ucr.edu>
> ---
>  drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
> index f5de81132177..77293579a134 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
> @@ -1533,16 +1533,19 @@ static struct v4l2_ctrl_config mt9m114_controls[] = {
>  static int mt9m114_detect(struct mt9m114_device *dev, struct i2c_client *client)
>  {
>         struct i2c_adapter *adapter = client->adapter;
> -       u32 retvalue;
> +       u32 model;
> +       int ret;
>
>         if (!i2c_check_functionality(adapter, I2C_FUNC_I2C)) {
>                 dev_err(&client->dev, "%s: i2c error", __func__);
>                 return -ENODEV;
>         }
> -       mt9m114_read_reg(client, MISENSOR_16BIT, (u32)MT9M114_PID, &retvalue);
> -       dev->real_model_id = retvalue;
> +       ret = mt9m114_read_reg(client, MISENSOR_16BIT, MT9M114_PID, &model);
> +       if (ret)
> +               return ret;
> +       dev->real_model_id = model;
>
> -       if (retvalue != MT9M114_MOD_ID) {
> +       if (model != MT9M114_MOD_ID) {
>                 dev_err(&client->dev, "%s: failed: client->addr = %x\n",
>                         __func__, client->addr);
>                 return -ENODEV;
> --
> 2.17.1
>


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside