Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 11 Aug 2021 06:19:28 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     luomeng <luomeng12@huawei.com>
Cc:     Luis Chamberlain <mcgrof@kernel.org>, axboe@kernel.dk,
        hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com,
        hch@infradead.org, jack@suse.cz, osandov@fb.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] block: replace incorrect uses of GENHD_FL_UP
Message-ID: <YRNd4O1uV1auj/pK@infradead.org>
References: <20210720182048.1906526-1-mcgrof@kernel.org>
 <051ab019-5163-e691-43ed-052401b6b95a@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <051ab019-5163-e691-43ed-052401b6b95a@huawei.com>
Precedence: bulk

On Wed, Aug 11, 2021 at 10:42:20AM +0800, luomeng wrote:
> Hi:
>    When the fuzz test injected memory allocation failed, I had this BUG_ON:
> kernel BUG at fs/sysfs/group.c:116.
>   The cause of the bug_ON is that the add_disk memory fails to be allocated
> but no error processing is performed.
>   I find your patches add error processing. So what is your next step with
> these patches.

I have one more pending series on top of this one I need to submit here:

http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/alloc_disk

to make sure the disk always has a valid queue reference.  After that
Luis work to return an error from add_disk should be much easier bause
we not have defined state.