Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp4166747pxt; Tue, 10 Aug 2021 22:38:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyG18eOspDbpWx7hEcuLbaeaGz9tPhqgLcemLFQjr/05WBXdPD0qWyLO3jhKNq7HeWZ+Dte X-Received: by 2002:a92:d64d:: with SMTP id x13mr175780ilp.202.1628660287192; Tue, 10 Aug 2021 22:38:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628660287; cv=none; d=google.com; s=arc-20160816; b=HwOBWhoTXIuHxR0SBlRmzP2JSpawXVQR0BXctXURWhl9RA8DrD5VqK5X8/U/5NIhik HLEUtfrnjO5+xoEPzPNZaoljcbQ5YQIf4fMl0Di/8IWpmjkVZDEMc3Zs3lpGPBsmBGuu ceah9AKhr1mq7WVJqQs/koKLzqrZ7JWjj1scO/NVkIZhkRfkWoBV8Hi2fyFPxF/IXtle Eq8HW3KuLflzEbd9/dWaDr2Kwy0wjhzpIHcpp5rJ+qd5y47hfRX9tzKQcBc2bRGjQ36X PXqvQtmOykHVOJuPy9dYnCPOakL2hNnG13sYwH3VDh5hJ26mA8V/ZgGubTXWWrluKxzG sW6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ScSbxJofNLIiJut+toTZ7USozFNrpn/9FRU/yhxl+AE=; b=bMKqEf5zna8pE1NBcIGnTUPGb9RzOMHtRCoUpCkEPKeNPmaopaxLMaR1tNupu4HKcS Snxwx0kFseB+gL/flp9ieywiJN63tgtOT6o++a83esFKTNlIHq/DLbMaAT2xVDUq4V8d /jvo8N77r3+GjHA5irx11cR8R++g2KMtnb2YP09S1ivAE11Ua2GTXXMpfRO519xhrs0R lMnAcxIcEoMOFqa1uWhdXTBTRY4f/nwQY+2TgGrr+JNtr34faneSKSlVvUKW4Olzvetd 32j4QWLbdfZ/24jGsIvq2KlAQUeRAvfQnSYnCVabQmsCqqJ3uQLNs35sjFGupYpz0wdV pEdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="eb6WOqa/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w24si12577037jal.110.2021.08.10.22.37.55; Tue, 10 Aug 2021 22:38:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="eb6WOqa/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234398AbhHKFed (ORCPT + 99 others); Wed, 11 Aug 2021 01:34:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234325AbhHKFec (ORCPT ); Wed, 11 Aug 2021 01:34:32 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7548C061799 for ; Tue, 10 Aug 2021 22:34:09 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id hv22-20020a17090ae416b0290178c579e424so2845067pjb.3 for ; Tue, 10 Aug 2021 22:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ScSbxJofNLIiJut+toTZ7USozFNrpn/9FRU/yhxl+AE=; b=eb6WOqa/iiW+lVxPN/WwlN1ktVPrT2bUzlrRfDrYo41IvDzG4/ln5yWs6uXhICalPc 8R0u5AzW7yMU6cYgS+wfVr1wFhPcTBbZD2Xyd4b7nHZ3hafixxLtxxbPGwpJLDHfRGdI zsU9bV0uTcH4s9YjyKyk3RwVbO/HStRc+oKgUx5B2+8G9pO8KCbN0SSodCkkTKH5OwCj NkEi8tGAip3xqqCWY5Cd5cCb4jacmdKEE4+LxGNZA+sGwQu085Zzb25vTOg1ndLK0z5V r4ejQRIY4GkBb+GZRhHuNkrSOOBP5ZQyuytbggBbhP7/xyVm24hsXA8Zo39boZpUz10E Ygng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ScSbxJofNLIiJut+toTZ7USozFNrpn/9FRU/yhxl+AE=; b=RiGdEoBX2ce3QuAr2Os6UeklI1K9iDnfn2sXNt4yraxiMi/dvYKE1xh+3X7aUwhSoe 1qezF6GAc8hUic7Fyh1bke6bpLEwy2MTaW8FvvtM9HEknJCxoEOJyTrbm63Xn2zur3cU zAZW3gxPti8LeWEHkruFiMldGoGRt6/+8YJAzHmWmuezYXd2K/p8DXJ77Xe9Br7awaiB Z6EGbmp2pCYF4p8qlxcmNxhGjO84X7X+hxEyHZx/YLFHMAiC/kNg1cAE6iCR0kfZQ7Zg 4Q75ooGc6UGWcWcXwBibN6c8t+sAaVHppU7aTqhWTIqqB5VP974xnhgpMlvkY5UauFUI 3woA== X-Gm-Message-State: AOAM533Z4SSbEMyKzkQ0sGQHYyhaEG5PHxC/OE5/3cbZ9DuyKGjlxA0L D/FUvVU0IOUNQEzjUDp0QP8whg== X-Received: by 2002:a17:902:8507:b029:12b:533e:5e9d with SMTP id bj7-20020a1709028507b029012b533e5e9dmr28394940plb.53.1628660049321; Tue, 10 Aug 2021 22:34:09 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id q4sm6443106pga.48.2021.08.10.22.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 22:34:08 -0700 (PDT) Date: Wed, 11 Aug 2021 11:04:06 +0530 From: Viresh Kumar To: Quentin Perret Cc: Rafael Wysocki , Vincent Donnefort , lukasz.luba@arm.com, Andy Gross , Bjorn Andersson , Cristian Marussi , Fabio Estevam , Kevin Hilman , Matthias Brugger , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Sudeep Holla , linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 0/8] cpufreq: Auto-register with energy model Message-ID: <20210811053406.jqwextgtnxhgsjd2@vireshk-i7> References: <20210811051859.ihjzhvrnuct2knvy@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811051859.ihjzhvrnuct2knvy@vireshk-i7> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-08-21, 10:48, Viresh Kumar wrote: > On 10-08-21, 13:35, Quentin Perret wrote: > > This series adds more code than it removes, > > Sadly yes :( > > > and the unregistration is > > not a fix as we don't ever remove the EM tables by design, so not sure > > either of these points are valid arguments. > > I think that design needs to be looked over again, it looks broken to > me everytime I land onto this code. I wonder why we don't unregister > stuff. Coming back to this series. We have two options, based on what I proposed here: https://lore.kernel.org/linux-pm/20210811050327.3yxrk4kqxjjwaztx@vireshk-i7/ 1. Let cpufreq core register with EM on behalf of cpufreq drivers. 2. Update drivers to use ->ready() callback to do this stuff. I am fine with both :) -- viresh