Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210704153314.6995-1-keguang.zhang@gmail.com>
 <YO5yo8v/tRZLGEdo@matsya> <CAJhJPsUNCSK4VYv9Z4ZNDxC03F4CxQoAXCCf+TJmmbdUe4XNNA@mail.gmail.com>
 <YPLrsXEmmHPtbZ+N@matsya> <YPMVyYoBojHYsMbJ@kroah.com> <YPa2+TsdL0PrR3hR@matsya>
 <YPa4IAk3sh7bai15@kroah.com> <YPa/DsO1vWcXKJKd@matsya> <CAJhJPsV211=Y_wrXqaiWz7Tqhvbj-ETwSNWqLcbt8PHi8=JMLA@mail.gmail.com>
In-Reply-To: <CAJhJPsV211=Y_wrXqaiWz7Tqhvbj-ETwSNWqLcbt8PHi8=JMLA@mail.gmail.com>
From:   Kelvin Cheung <keguang.zhang@gmail.com>
Date:   Wed, 11 Aug 2021 15:18:03 +0800
Message-ID: <CAJhJPsXtm_i5OAtSxZn9mSumAp0X8r5EKJ3VLt1nmC-j-EuOyw@mail.gmail.com>
Subject: Re: [PATCH V5] dmaengine: Loongson1: Add Loongson1 dmaengine driver
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Greg KH <gregkh@linuxfoundation.org>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Kelvin Cheung <keguang.zhang@gmail.com> =E4=BA=8E2021=E5=B9=B47=E6=9C=8821=
=E6=97=A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=888:22=E5=86=99=E9=81=93=EF=BC=
=9A
>
> Hi Vinod, Greg,
>
> Vinod Koul <vkoul@kernel.org> =E4=BA=8E2021=E5=B9=B47=E6=9C=8820=E6=97=A5=
=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=888:18=E5=86=99=E9=81=93=EF=BC=9A
> >
> > On 20-07-21, 13:48, Greg KH wrote:
> > > On Tue, Jul 20, 2021 at 05:13:53PM +0530, Vinod Koul wrote:
> > > > On 17-07-21, 19:39, Greg KH wrote:
> > > > > On Sat, Jul 17, 2021 at 08:09:45PM +0530, Vinod Koul wrote:
> > > > > > On 17-07-21, 18:57, Kelvin Cheung wrote:
> > > > > > > Vinod Koul <vkoul@kernel.org> =E4=BA=8E2021=E5=B9=B47=E6=9C=
=8814=E6=97=A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=881:14=E5=86=99=E9=81=93=
=EF=BC=9A
> > > > > > > >
> > > > > > > > On 04-07-21, 23:33, Keguang Zhang wrote:
> > > > > > > >
> > > > > > > > > +static struct platform_driver ls1x_dma_driver =3D {
> > > > > > > > > +     .probe  =3D ls1x_dma_probe,
> > > > > > > > > +     .remove =3D ls1x_dma_remove,
> > > > > > > > > +     .driver =3D {
> > > > > > > > > +             .name   =3D "ls1x-dma",
> > > > > > > > > +     },
> > > > > > > > > +};
> > > > > > > > > +
> > > > > > > > > +module_platform_driver(ls1x_dma_driver);
> > > > > > > >
> > > > > > > > so my comment was left unanswered, who creates this device!
> > > > > > >
> > > > > > > Sorry!
> > > > > > > This patch will create the device: https://patchwork.kernel.o=
rg/patch/12281691
> > > > > >
> > > > > > Greg, looks like the above patch creates platform devices in mi=
ps, is
> > > > > > that the right way..?
> > > > >
> > > > > I do not understand, what exactly is the question?
> > > >
> > > > So this patch was adding Loongson1 dmaengine driver which is a plat=
form
> > > > device. I asked about the platform device and was told that [1] cre=
ates
> > > > the platform device. I am not sure if that is the recommended way g=
iven
> > > > that you have been asking people to not use platform devices.
> > >
> > > Yes, but this link:
> > >
> > > > [1]: https://patchwork.kernel.org/patch/12281691
> > >
> > > Does look like a "real" platform device in that you have fixed resour=
ces
> > > for the device and no way to discover it on your own.
> > >
> > > But why are you not using DT for this?  That looks like the old platf=
orm
> > > data files.
> >
> > Apparently I was told that this platform does not use DT :( Looking at
> > it it should.. Maybe Kelvin can explain why..
>
> Yes, the DT support of Loongson32 is still on the way.
> Therefore, I have to use the old way to let the driver work.
> I will update this driver once this platform supports DT.
>
Hi Vinod,
Is there anything to be improved?
Perhaps this patch is acceptable now?

Thanks!
> >
> > --
> > ~Vinod
>
>
>
> --
> Best regards,
>
> Kelvin Cheung


--=20
Best regards,

Kelvin Cheung