Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp4260175pxt;
        Wed, 11 Aug 2021 01:34:04 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyDBSl5cxzMstBDkqhFGvMDVid61tGM1A8icW1abyiS5dTzuAFrYxycW0y7ULT3yxluolpC
X-Received: by 2002:a05:6402:13cf:: with SMTP id a15mr10051548edx.117.1628670844332;
        Wed, 11 Aug 2021 01:34:04 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1628670844; cv=none;
        d=google.com; s=arc-20160816;
        b=enIxyfKUesxqTSj9maKSd7e8Yf/XRcRq7dl1xdTnKAtrPrWVlrr1tYb3Oi98xmUbYt
         G4AcmIvR1HH2ciIqEBt2Y+fxtmhU8bLjPxvVNju7pP4hLBMHCwovzfGjZ4jrJ60qPAU4
         xQngJel42F613vwDZe+KrOwX8XKfGqBKyClGT8+fI13PUaSrCuolNuVb84vEKAW6aGS6
         LaNfYomIKuw8LA0EOBbQMkCF5MVV4CKn5k/TJq4GdlU9M6suLbdHujU5u/2cIOJoalzN
         o1WpuWKBkvEJUbSUc+Iu7FsDYMnqiz0hvGI1Fm8oxjiLPHbmn5eJqqM7/dXr+9H/9YoJ
         esoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version:dkim-signature;
        bh=T9aF/gnHHaozYj2J+OBaspaiiV6uiEkY/GBIP7m0gEg=;
        b=dWer6ybn/ss7Bz6aQro1s6AmkKSuZa9Fb51mEdam+HkJwddvz3QEhX3Q86j9+tkqDo
         CBZnT9MOofvnilcoyphz0b8KPsmjAEVwSMI/Be6ND65jrcXfGvsF4+Llzrg34wJ36DP7
         2JgJwhQqSNrhkE7uhr40sqODCG4U/IKtBrtgjBJZe8y0x9jvbeDeqFZTtH0D9Unucgcd
         +8Qrj2KiteqenONpkZJXHaNhCXPM/No/8r4C5OHTyDEXZ/8A70RnkCJlOTB4X/cGwQuI
         qZLw1rgnkCRyEm3ZJfiY5TIdqmzvjZYfT+XWB40Buoux0k0KM+YAet1Xp6HXXPUbP014
         aQDg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linaro.org header.s=google header.b=z4zPOj2o;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id e10si26195449edj.183.2021.08.11.01.33.39;
        Wed, 11 Aug 2021 01:34:04 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linaro.org header.s=google header.b=z4zPOj2o;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233112AbhHKIck (ORCPT <rfc822;lists.md@gmail.com> + 99 others);
        Wed, 11 Aug 2021 04:32:40 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57098 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233167AbhHKIcj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Aug 2021 04:32:39 -0400
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1099EC0613D5
        for <linux-kernel@vger.kernel.org>; Wed, 11 Aug 2021 01:32:16 -0700 (PDT)
Received: by mail-lf1-x133.google.com with SMTP id y34so4016376lfa.8
        for <linux-kernel@vger.kernel.org>; Wed, 11 Aug 2021 01:32:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=T9aF/gnHHaozYj2J+OBaspaiiV6uiEkY/GBIP7m0gEg=;
        b=z4zPOj2oXB+m27UeJcQn5BVLsxsB4z1KOcQYkV7Zp4KvMRcbXTwGaQYgvfjzMX/nBU
         +zmL0eQOyKOXcbZUzpKCJJfPmbA62iwzKwBm+4YtiuzZjzMDYUtdFO0Mz87QkQPr38YJ
         fggNcHhRGF/BagSG37jlWaIkXwYqR0dnF13GLl5azCiqyXmrLFlj3Tzz5mag8r20A6HE
         pZ7rAO2PUBHurc0seOXsZIH1lLrsbGPHPpF9eFSVOwVG8GzQQjJDJ79SKGk+YdBFO9Gx
         3MZeVhJt+5R2p2mJ8v9vcjavRhrjmWHrZ+uhVc8cVKFVyzaTQfCwk2AHhFi9e1n9y8UE
         jwsw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=T9aF/gnHHaozYj2J+OBaspaiiV6uiEkY/GBIP7m0gEg=;
        b=c6o1WoQgcAfSLiWgda6FBKoDun3dnreWcNN6gs2AVEvaLIbMMJCeFJUcXHd/IThQNd
         S5z7GRLGsQx8fkGs599NFQw1JECXDPa2IvxbfxoQwroiXGAhT3/ARVkIZ51RPLLPwf5b
         EWUMxsotLeGHPLifA9VoZjEoVUkNH2oCqBM5XorIGhAF8KUAc9UZ0ObuX5LOzFaLzfWf
         UCNPhefUMOfODAoWEsl/ZrnmDeHv7SNWEc5AeSpN7cG6MHG3yT8TYLNLtIdwJlNBm8Z5
         SZc3fihhmbB0gCQJNvxNiI4OeA6U6lQg+BO3wjDDIykEiq083oh3vIaZJRSUBJtMsRDO
         X+Xg==
X-Gm-Message-State: AOAM531Bobo50j5S+SSNoKpqr2SiZzjBgZQVo/5vPDdNTZdiXTMfjCkU
        GOgEa4aWqpUcEMLDADOnT36gKjLkdHmqyVA5lc84dg==
X-Received: by 2002:a19:c7cd:: with SMTP id x196mr24373795lff.465.1628670734307;
 Wed, 11 Aug 2021 01:32:14 -0700 (PDT)
MIME-Version: 1.0
References: <20210726013345.1634442-1-jay.xu@rock-chips.com>
In-Reply-To: <20210726013345.1634442-1-jay.xu@rock-chips.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Wed, 11 Aug 2021 10:32:03 +0200
Message-ID: <CACRpkdbU+SXCaJ5N65zKw-btn_CQisp+rhozjtCaZ7y59mvTtQ@mail.gmail.com>
Subject: Re: [PATCH v7 0/9] gpio-rockchip driver
To:     Jianqun Xu <jay.xu@rock-chips.com>
Cc:     =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 26, 2021 at 3:34 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

> Separate gpio driver from pinctrl driver, and support gpio v2 controller.

Mostly looks good, but waiting for a respin to address Bartosz
comments on patch 5.

Yours,
Linus Walleij