Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: rnayak=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 89553C433F1
Subject: Re: [PATCH v6 1/2] PM / Domains: Add support for 'required-opps' to
 set default perf state
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Roja Rani Yarubandi <rojay@codeaurora.org>,
        Stephan Gerhold <stephan@gerhold.net>
References: <1628074696-7979-1-git-send-email-rnayak@codeaurora.org>
 <1628074696-7979-2-git-send-email-rnayak@codeaurora.org>
 <CAPDyKFrebwt5=S7hqXvcqRvt+-EXLcVmRSRZt1uPf-9n7_pRDg@mail.gmail.com>
 <2afd0fac-ed28-c090-a345-3fd4284b4125@codeaurora.org>
 <20210810024308.gurvzpbe2bc2bhky@vireshk-i7>
From:   Rajendra Nayak <rnayak@codeaurora.org>
Message-ID: <e452c0b5-5555-d6e2-40da-6aa21a26766d@codeaurora.org>
Date:   Wed, 11 Aug 2021 15:30:46 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210810024308.gurvzpbe2bc2bhky@vireshk-i7>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/10/2021 8:13 AM, Viresh Kumar wrote:
> On 09-08-21, 16:38, Rajendra Nayak wrote:
>> Sure, I can do that, apart from the error print, the function currently also
>> returns a -EINVAL in case of the missing 'required-opps', are we suggesting
>> we change that to not return an error also?
> 
> No.
> 
>> Since this is completely optional in the device node, we would want the function to
>> ideally not return error and only do so in case 'required-opps' exists and the
>> translation to performance state fails.
> 
> Not really. The function should return failure if the property isn't
> there, but it shouldn't be EINVAL but ENODEV.

In my case I don't want to error out if the property is missing, I want to error out
only when the property exists but can't be translated into a performance state.

So currently I check if the property exists and *only then* try to translate it, Ulf asked
me to skip the check. If I do that and I call of_get_required_opp_performance_state()
unconditionally, and if it errors out I will need to put in additional logic (check for
return value of ENODEV) to distinguish between the property-does-not-exist vs
property-exists-but-cannot-be-translated case.
It just seems more straight-forward to call this only when the property exists, Ulf?
  

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation