Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Shaun Tancheff <shaun@tancheff.com>
CC:     Damien Le Moal <Damien.LeMoal@wdc.com>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        Aravind Ramesh <Aravind.Ramesh@wdc.com>,
        Adam Manzanares <a.manzanares@samsung.com>,
        Himanshu Madhani <himanshu.madhani@oracle.com>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Jens Axboe <axboe@fb.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v5 1/2] blk-zoned: allow zone management send operations
 without CAP_SYS_ADMIN
Thread-Topic: [PATCH v5 1/2] blk-zoned: allow zone management send operations
 without CAP_SYS_ADMIN
Thread-Index: AQHXjqDFdLbKA5ZypU6CJovBECqU7g==
Date:   Wed, 11 Aug 2021 11:05:18 +0000
Message-ID: <20210811110505.29649-2-Niklas.Cassel@wdc.com>
References: <20210811110505.29649-1-Niklas.Cassel@wdc.com>
In-Reply-To: <20210811110505.29649-1-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?pvuRH7q9NZnfW4Id9QehhSLRFSDLVsgFs8DVI2SFT+ycADsysftg/Ky1BP?=
 =?iso-8859-1?Q?GTIdP0ewLwF3s6w00fE6mcsHippQ3gVuEkYZjwzQmg9TzJ1wG0qIchSty8?=
 =?iso-8859-1?Q?NbW0neTwfQKrUZz+CaZ9vTarXVXxoQDwl8zTGI7XIDDbWSftywJryzh2h5?=
 =?iso-8859-1?Q?rqdtQ7Re06jMB/yRPBvUDBWgXLXMuDhwQHBa8qJRDFGZUwDDxZWc+yLc/W?=
 =?iso-8859-1?Q?sxxNhebYo2ptt7JYRfn/f8RHW2iUuy3WhhxPirNU+Yq0PCobkA3y/hnLTr?=
 =?iso-8859-1?Q?3zu8Hq4QwmuruGtA8ixUyFESijVBXD8VM9ovBLz5Ojgp7cBcGwUgj07j27?=
 =?iso-8859-1?Q?P9exRGFjf1m4spe72UmTTFUPnadnq38/3p1AeqRvZS/nxGgOv+N8XXc98q?=
 =?iso-8859-1?Q?U98m9B2uGWU8aiSPu/FI8vLhZ4YqQo8oXj07uliaenDOLiN/KA4yXoLu3n?=
 =?iso-8859-1?Q?FwUQfHtkXibJLobus3s6W4v/NwkeRUVvl9oAj0B/sqZFLUw2yRYULz9scB?=
 =?iso-8859-1?Q?7Qm04MawGUQuuQgnUaEEKGHwYgM6AILWp+zCaOE+ABn9LibbORPsWurdrL?=
 =?iso-8859-1?Q?G80pPe59c1UiTEBO3RHx+pfAkCz5XATcdjy+Obro3zTYPCIAEJg/Cu3r2+?=
 =?iso-8859-1?Q?MzMGWg8P4Lq6RNnOTszKgB62Hz4mifZ7hsZSH5GXXPwpfpiA3KsgCxjHLA?=
 =?iso-8859-1?Q?Qyj2ppxuly9DMIL56y7Ryk/narDvsWFQCG8t1lcW76FJ53AquzAQ25RRSE?=
 =?iso-8859-1?Q?tqEoBRqQeFAU5quhDBA6+gQWsMW+iT29ZuzGa7vjTnz+PtmsBRUhD9YeIn?=
 =?iso-8859-1?Q?sn0jPjOWKVWPUvx2n5PeWgfNcPk3cOeHGckfEeSmsWRVLBgrEeTVQYf8ko?=
 =?iso-8859-1?Q?+LH7A8A/WP6mE7QDP3nUg4UU2Z5/XfomFTJa9tYU9COQAdtWDRLcdYeOBs?=
 =?iso-8859-1?Q?iZBfazPOO4/EsN3YYfw6yxyAsD0iVZupShUasfOAkiY4QZzJ1VamWEUK+J?=
 =?iso-8859-1?Q?n2W3VpoLBQrx/qDWSPKRttYUjIK7Bl6kD1dGo8xR/eIQ9t/3XJ4D7NpUAu?=
 =?iso-8859-1?Q?1ESp8WIuikzhfCZy1WbA9BQu8rI6RyHaW98wqwaAG4WoX2HBHjzpwOuVW6?=
 =?iso-8859-1?Q?BYtYDd2L0S+NLQdzA0wGqQYml94JknuoEYLEmCT6TBLYjTYOYGzY32/ODS?=
 =?iso-8859-1?Q?nf6ufMm6grsZn+88JeayUMCFl72G423ROYHNkuEqM9eDzjFiZd+Y2WHwuj?=
 =?iso-8859-1?Q?VmynNMD0mCZ2YvlMDLR/Z9pLreslQik7ZFB4sVg75DgAQOB367M5CAzglb?=
 =?iso-8859-1?Q?bgSFpfaiS8hRD1MSdPAfMHwcx7Rd0bjXMCLJnjU4cPG3WEGi6RCN8eS5l8?=
 =?iso-8859-1?Q?iFU2hXeD9b?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d8d747f-a983-41ae-490b-08d95cb7e7af
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2021 11:05:18.3628
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8s05pyETuI598J/wUWpjijWM1VzxwEPMZcxzVsKjvsJfz4u4efOWeHid9ql44H7TD3KlHW6tXzCEC2NVE7q7EQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7719
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Niklas Cassel <niklas.cassel@wdc.com>

Zone management send operations (BLKRESETZONE, BLKOPENZONE, BLKCLOSEZONE
and BLKFINISHZONE) should be allowed under the same permissions as write().
(write() does not require CAP_SYS_ADMIN).

Additionally, other ioctls like BLKSECDISCARD and BLKZEROOUT only check if
the fd was successfully opened with FMODE_WRITE.
(They do not require CAP_SYS_ADMIN).

Currently, zone management send operations require both CAP_SYS_ADMIN
and that the fd was successfully opened with FMODE_WRITE.

Remove the CAP_SYS_ADMIN requirement, so that zone management send
operations match the access control requirement of write(), BLKSECDISCARD
and BLKZEROOUT.

Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Aravind Ramesh <aravind.ramesh@wdc.com>
Reviewed-by: Adam Manzanares <a.manzanares@samsung.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: stable@vger.kernel.org # v4.10+
---
Changes since v4:
-Picked up additional Reviewed-by tag.

Note to backporter:
Function was added as blkdev_reset_zones_ioctl() in v4.10.
Function was renamed to blkdev_zone_mgmt_ioctl() in v5.5.
The patch is valid both before and after the function rename.

 block/blk-zoned.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 86fce751bb17..8a60dbeb44be 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -421,9 +421,6 @@ int blkdev_zone_mgmt_ioctl(struct block_device *bdev, f=
mode_t mode,
 	if (!blk_queue_is_zoned(q))
 		return -ENOTTY;
=20
-	if (!capable(CAP_SYS_ADMIN))
-		return -EACCES;
-
 	if (!(mode & FMODE_WRITE))
 		return -EBADF;
=20
--=20
2.31.1