Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        Shaun Tancheff <shaun@tancheff.com>
CC:     Damien Le Moal <Damien.LeMoal@wdc.com>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        Aravind Ramesh <Aravind.Ramesh@wdc.com>,
        Adam Manzanares <a.manzanares@samsung.com>,
        Himanshu Madhani <himanshu.madhani@oracle.com>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Jens Axboe <axboe@fb.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v5 2/2] blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN
Thread-Topic: [PATCH v5 2/2] blk-zoned: allow BLKREPORTZONE without
 CAP_SYS_ADMIN
Thread-Index: AQHXjqDFbqdVjmh3FESvxZ0E3nXwJA==
Date:   Wed, 11 Aug 2021 11:05:19 +0000
Message-ID: <20210811110505.29649-3-Niklas.Cassel@wdc.com>
References: <20210811110505.29649-1-Niklas.Cassel@wdc.com>
In-Reply-To: <20210811110505.29649-1-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?34Af3d3v78WlST+UI9NM1Ws+y/bNK0BTpTLDO7yMCcouOzzDPkmYNmRbXN?=
 =?iso-8859-1?Q?qwv/AETa80PXgcD1i344797f6UMasuSn4oqcjg5kSUP1KaNcy1n4+hrWjH?=
 =?iso-8859-1?Q?hgK60sQsiY4RPDKy2QU24utLP/FEHWzDrLNIwNNM32lLQrbEeA1AJU3cr5?=
 =?iso-8859-1?Q?7Rg8p0QlEMiSP+WgTV574gF9EbFKZJd00IWaW1LpVA2UbANBEbIqWUolOm?=
 =?iso-8859-1?Q?UvZ59T6KMCkCObVb8AN5Ouu+KMnHYyYq+7auo27EEvz87UhfoOJECU9GKB?=
 =?iso-8859-1?Q?hpMj/IeLPAVAX1/yyfP64a507N1MEzSM0p2gqwMZXGwhzn8SHb2OsxZXmo?=
 =?iso-8859-1?Q?mJyIZ//TzxQ/A55kLS6YK0mezRjJVh+Id2ERZ4Iy/M5+9mR1XuDZXmo2iq?=
 =?iso-8859-1?Q?grHgcrRs1P4rBOpd6rDmpb2cRHggenrDT2H+BOujeeEQEOkY2axyAMy7vb?=
 =?iso-8859-1?Q?okmRpCASGEO8yu8kzOjAFXToZ7oAKemmtdFNNq8UsV82NyjRVx8chN9VQx?=
 =?iso-8859-1?Q?BoHZu+K/98u+1Wlll8J2l2Jofa8FuPppD8ASFha0SMRKoMV2QHVABoFDHN?=
 =?iso-8859-1?Q?1CLMxMFVUGPRezwJ4vqJ+tVzEOFooe2r3FpqcGUtEyUfizvygt3QCm3bHY?=
 =?iso-8859-1?Q?+tAyAHZhAKDhrt0fY/i42bZd/ELB7QmYUuInWMUkN4Xb7QktgbXmoiZVfl?=
 =?iso-8859-1?Q?z9nD2l3A0QgC6plmIVVK+oOPfKrjtVWxlXwTuW0c/kM25AYeBOL9o2tdWp?=
 =?iso-8859-1?Q?9hEPznxdhdAdZBl3car6bayyWOXJoNfLBXjXxTgYrg/QKmHo3DPzuxp5CJ?=
 =?iso-8859-1?Q?fX2Jexw7+wdFTFggN30r+EkA+ihVS4mf5ZbcoEuCdVgHqrEhIb/9VtrKb0?=
 =?iso-8859-1?Q?GR2kXoatYbCpyYHhanoULtSsmF7cSmVEKGdyYpeahrOSPODMVLeYvB0Fut?=
 =?iso-8859-1?Q?zFX0ALHC1eHc+ConHQJzJrQpfTYHXnAowdogQeuR1qEkxYTwfiXe3xTGtu?=
 =?iso-8859-1?Q?cWhJVrhlVdtOcojJKyHtLuZq8E4Ya0TWQhPUyqZ0eDQ7wQZi/Wt3xp6EMU?=
 =?iso-8859-1?Q?zgyUxO/sODrZI7EpeyZF5pfVoQkS4UMYIcL6kR9E8ccxzgcD2HEIcE1efM?=
 =?iso-8859-1?Q?8TSaaZ7CahTADhbrxGuIPpbEF2NhIArTni+4EPzyxnOC9n+D2AnCRPFL6s?=
 =?iso-8859-1?Q?gxj4KgP2zOYV8o32ZC9dzrhoGPD8EY71HR3Q3/4mmk3RS4chRJwAYTV07n?=
 =?iso-8859-1?Q?pDflfGfoBmgr/CxoUPX20lOxzcUAA5Fc43jQv5llTXVQn7xykAeMdkiYtl?=
 =?iso-8859-1?Q?ZHvgdaYeTYVuhdip6M+j3R17zthTzE0H66z9PsXFWrH0PUiEOlIyKNahRk?=
 =?iso-8859-1?Q?XuS3yTKXWp?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a708f78-4e72-413c-7501-08d95cb7e83f
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2021 11:05:19.3087
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: q9JAmcR9AMaRWvemCuKs8Azp9DdrsTixUDMT3sNuXC3Ompp/fmHuKzGIzEjTXuLqxpFsBYAE9mLK319ayN1RhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7719
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Niklas Cassel <niklas.cassel@wdc.com>

A user space process should not need the CAP_SYS_ADMIN capability set
in order to perform a BLKREPORTZONE ioctl.

Getting the zone report is required in order to get the write pointer.
Neither read() nor write() requires CAP_SYS_ADMIN, so it is reasonable
that a user space process that can read/write from/to the device, also
can get the write pointer. (Since e.g. writes have to be at the write
pointer.)

Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Aravind Ramesh <aravind.ramesh@wdc.com>
Reviewed-by: Adam Manzanares <a.manzanares@samsung.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: stable@vger.kernel.org # v4.10+
---
Changes since v4:
-Picked up additional Reviewed-by tag.
-Corrected Damien's email.

 block/blk-zoned.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 8a60dbeb44be..1d0c76c18fc5 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -360,9 +360,6 @@ int blkdev_report_zones_ioctl(struct block_device *bdev=
, fmode_t mode,
 	if (!blk_queue_is_zoned(q))
 		return -ENOTTY;
=20
-	if (!capable(CAP_SYS_ADMIN))
-		return -EACCES;
-
 	if (copy_from_user(&rep, argp, sizeof(struct blk_zone_report)))
 		return -EFAULT;
=20
--=20
2.31.1