Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 11 Aug 2021 12:58:46 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Tang Bin <tangbin@cmss.chinamobile.com>
Cc:     olivier.moysan@foss.st.com, arnaud.pouliquen@foss.st.com,
        lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] ASoC: stm32: spdifrx: Delete unnecessary check in the
 probe function
Message-ID: <20210811115846.GC4167@sirena.org.uk>
References: <20210811115523.17232-1-tangbin@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="H8ygTp4AXg6deix2"
Content-Disposition: inline
In-Reply-To: <20210811115523.17232-1-tangbin@cmss.chinamobile.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--H8ygTp4AXg6deix2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 11, 2021 at 07:55:23PM +0800, Tang Bin wrote:
> The function stm32_spdifrx_parse_of() is only called by the function
> stm32_spdifrx_probe(), and the probe function is only called with
> an openfirmware platform device. Therefore there is no need to check
> the device_node in probe function.

What is the benefit of not doing the check?  It seems like reasonable
defensive programming.

--H8ygTp4AXg6deix2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmETu3UACgkQJNaLcl1U
h9ASJwf+LWfdLiXawrYtfjW25aPh7dylTBVdUi25A0M6PyTBOcrj0nbIhD5AJ0M2
Q32W/NV+nTugHYOK9xIu9sgwEaq4sZMPP2tM6A0+K4oX8RijtxygqBeZQ/AWUK7F
UPPJObcnC2TO65la2HxerkUZzyw7NtI4BAMAHNQrZKUxpNnAhkLYvsIHRU+MDOcV
u8oG0tc0ZHcTwcnidQGGZEBTvS/hNnwlXVr85jYT6ZmnscKT33+0sfzyw3Eb3YDK
epJ4LR9H0dOyjqF0ubhDtIStDbHDAKgZwZTsvY5rWyxITc4bhQsAbem9qPObI0m9
j7Zt/YqiCkLlbCHIj5djMnnAdIqL1w==
=J1OY
-----END PGP SIGNATURE-----

--H8ygTp4AXg6deix2--