Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 11 Aug 2021 13:12:00 +0100
From:   Jamie Iles <jamie@nuviainc.com>
To:     James Morse <james.morse@arm.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        shameerali.kolothum.thodi@huawei.com,
        Jamie Iles <jamie@nuviainc.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        lcherian@marvell.com, bobo.shaobowang@huawei.com
Subject: Re: [PATCH v1 01/20] x86/resctrl: Kill off alloc_enabled
Message-ID: <YRO+kCdb43EzXEBa@hazel>
References: <20210729223610.29373-1-james.morse@arm.com>
 <20210729223610.29373-2-james.morse@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210729223610.29373-2-james.morse@arm.com>
Precedence: bulk

Hi James,

On Thu, Jul 29, 2021 at 10:35:51PM +0000, James Morse wrote:
> rdt_resources_all[] used to have extra entries for L2CODE/L2DATA entries.
> These were hidden from resctrl by the alloc_enabled value.
> 
> Now that the L2/L2CODE/L2DATA resources have been merged together,
> alloc_enabled doesn't mean anything, it always has the same value as
> alloc_capable which indicates CAT is supported by this cache.
> 
> Remove alloc_enabled and its helpers.
> 
> Signed-off-by: James Morse <james.morse@arm.com>

There's a comment referring to alloc_enabled in rdtgroup_create_info_dir 
that can be replaced with alloc_capable.

Thanks,

Jamie