Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 11 Aug 2021 15:33:25 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     =?iso-8859-1?Q?H=E5kon?= Bugge <haakon.bugge@oracle.com>
Cc:     Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/core/sa_query: Remove unused function
Message-ID: <YRPDlTHjagRUqtOS@unreal>
References: <1628684831-26981-1-git-send-email-haakon.bugge@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1628684831-26981-1-git-send-email-haakon.bugge@oracle.com>
Precedence: bulk

On Wed, Aug 11, 2021 at 02:27:11PM +0200, H?kon Bugge wrote:
> ib_sa_service_rec_query() was introduced in kernel v2.6.13 by commit
> cbae32c56314 ("[PATCH] IB: Add Service Record support to SA client")
> in 2005. It was not used then and have never been used since.
> 
> Removing it.
> 
> Signed-off-by: H?kon Bugge <haakon.bugge@oracle.com>
> ---
>  drivers/infiniband/core/sa_query.c | 101 -------------------------------------
>  include/rdma/ib_sa.h               |  10 ----
>  2 files changed, 111 deletions(-)

You shouldn't stop there and remove ib_sa_service_rec_callback,
ib_sa_service_rec_release, ib_sa_service_query and probably
ib_sa_service_rec.

Thanks