Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 11 Aug 2021 05:49:17 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Joe Perches <joe@perches.com>
Cc:     Jonathan Toppins <jtoppins@redhat.com>, netdev@vger.kernel.org,
        leon@kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
        Veaceslav Falico <vfalico@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        "David S. Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] bonding: combine netlink and console
 error messages
Message-ID: <20210811054917.722bd988@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <d5e1aada694465fd62f57695e264259815e60746.camel@perches.com>
References: <cover.1628650079.git.jtoppins@redhat.com>
        <e6b78ce8f5904a5411a809cf4205d745f8af98cb.1628650079.git.jtoppins@redhat.com>
        <d5e1aada694465fd62f57695e264259815e60746.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 10 Aug 2021 20:27:01 -0700 Joe Perches wrote:
> > +#define BOND_NL_ERR(bond_dev, extack, errmsg) do {		\
> > +	if (extack)						\
> > +		NL_SET_ERR_MSG(extack, errmsg);			\
> > +	else							\
> > +		netdev_err(bond_dev, "Error: %s\n", errmsg);	\
> > +} while (0)
> > +
> > +#define SLAVE_NL_ERR(bond_dev, slave_dev, extack, errmsg) do {		\
> > +	if (extack)							\
> > +		NL_SET_ERR_MSG(extack, errmsg);				\
> > +	else								\
> > +		slave_err(bond_dev, slave_dev, "Error: %s\n", errmsg);	\
> > +} while (0)  
> 
> Ideally both of these would be static functions and not macros.

That may break our ability for NL_SET_ERR_MSG to place strings 
back in a static buffer, no?