Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] net/ipv4/tcp.c: remove superfluous header file in
 tcp.c
To:     Mianhan Liu <liumh1@shanghaitech.edu.cn>,
        Eric Dumazet <edumazet@google.com>,
        "David S . Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Matthew <Wilcoxwilly@infradead.org>
References: <20210811133305.14640-1-liumh1@shanghaitech.edu.cn>
From:   Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <6240ae70-3a50-2570-a115-c61ef09286a6@gmail.com>
Date:   Wed, 11 Aug 2021 16:19:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210811133305.14640-1-liumh1@shanghaitech.edu.cn>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/11/21 3:33 PM, Mianhan Liu wrote:
> nr_free_buffer_pages could be exposed through mm.h instead of swap.h,
> and then tcp.c wouldn't need swap.h. Moreover, after preprocessing
> all the files that use nr_free_buffer_pages, it turns out that those files
> have already included mm.h.
> Thus, we can move nr_free_buffer_pages from swap.h to mm.h safely
> so as to reduce the obsolete includes.
> 
> Signed-off-by: MianHan Liu <liumh1@shanghaitech.edu.cn>

Not sure why tcp gets a special treatment.
Patch title does not match changelog at all.

You should submit a pure mm patch, then eventually one networking follow up.

# git grep -n linux/swap.h -- net
net/9p/trans_virtio.c:34:#include <linux/swap.h>
net/ipv4/sysctl_net_ipv4.c:18:#include <linux/swap.h>
net/ipv4/tcp.c:263:#include <linux/swap.h>
net/ipv4/udp.c:81:#include <linux/swap.h>
net/netfilter/ipvs/ip_vs_ctl.c:27:#include <linux/swap.h>
net/openvswitch/meter.c:15:#include <linux/swap.h>
net/sctp/protocol.c:36:#include <linux/swap.h>