Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp4521392pxt; Wed, 11 Aug 2021 07:54:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9oVgrfpYRCdMq6A2JUEwTOZStQ5t5ofVgHF6Z+PLtoVGZFkVgpZrxDeNdRekjEErTHTQb X-Received: by 2002:a92:7c07:: with SMTP id x7mr557436ilc.198.1628693640362; Wed, 11 Aug 2021 07:54:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628693640; cv=none; d=google.com; s=arc-20160816; b=wufnzdHPEp+bA/GFTwN4fVZruqNOePbs+3cxkGdR+hFxiknDi7zgZkMupGm+eDNjyl AqktystuPzaUuAdIKURqQqWhuHJWiu9PEu6otsFM33tjioRUWib4hS36asAdIE5dNwzW mqhrcmC5W8Wb27b/Z0zbF1DUs0rlbNElLhp+GoQOnorVRb1KJrY6rRNZpZjnfN3nIUTL hBvNFxGQDBVOl00KxPpgCsCfVc4Cku/bsSlDWmoLKQOZ7kV8sxyLZRx/HusNsubkIlmX HWxHMQlzlWgbOrSsjpqYepJvbX6EP/FIWobKkxdKozsBr+hYjNn8KpsRSOokQXNWSwcx VGTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=Eys1WxciEg1/dC1Kxm9kbihHRWLI/mIwKljkXQDaqoY=; b=VNU2w9+aRuaayvQvLiiFvEeNqvHO4qZOEa0wrt5p8+Y/tp8u0oaP69qOKVEVh7mHmg 4M21235XvhvyWoeIS0wnKspYsdh7hxZocSSimh6iSIhBbQofdqkZvMJabIT7resoV4am j0axcHqbpRP/0NVVWth8IYYu1m69DoUI1/PcwCgp+vbTbyOdEdJ7Z5wOGCueRJuQprMV RdSvej0zMaHEMC73x6HoioRJOsiuetOM6BD+DxrUy0yugZSf6bI0UP8SCtnZ6080Ay73 pbyGe9d55sj+WnxxcJ6kOClu1QBbnLHdebMLeh/mFdTHfvM6lFRm57JyCNJVpPu1x3JL wp3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=h+7xw3eX; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d3si1545421ilq.47.2021.08.11.07.53.47; Wed, 11 Aug 2021 07:54:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=h+7xw3eX; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232663AbhHKOxE (ORCPT + 99 others); Wed, 11 Aug 2021 10:53:04 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:41832 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232506AbhHKOxD (ORCPT ); Wed, 11 Aug 2021 10:53:03 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7D05B1FED8; Wed, 11 Aug 2021 14:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628693558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eys1WxciEg1/dC1Kxm9kbihHRWLI/mIwKljkXQDaqoY=; b=h+7xw3eXEJH/u7ItYpnHWwaVcyK+1cIQddfQyF4duqUtTQTejCze+QpDO9Zl2SUMC8tY0n Xc5quF6Sa+9giqfM0OyqRCHQBMWylIppbi+zxVaQWIwYzieV2EseD/VMiFsmjQI/g4cKst 9XNvVM/3sak5jAvwelxM2PSAlGttmPk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628693558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eys1WxciEg1/dC1Kxm9kbihHRWLI/mIwKljkXQDaqoY=; b=6W5ZXZYn9nn0SLrEOcyvilpqUqGmcgocIKE8Ghempfy96IFtQjUfNJw+83aGh5hFsJCdOl SCw09Ol5q+h/2vDg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 5E61F136D9; Wed, 11 Aug 2021 14:52:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id pA+2FTbkE2EUUgAAGKfGzw (envelope-from ); Wed, 11 Aug 2021 14:52:38 +0000 Subject: Re: [PATCH v14 059/138] mm/rmap: Add folio_mkclean() To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-60-willy@infradead.org> From: Vlastimil Babka Message-ID: Date: Wed, 11 Aug 2021 16:52:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-60-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote: > Transform page_mkclean() into folio_mkclean() and add a page_mkclean() > wrapper around folio_mkclean(). > > folio_mkclean is 15 bytes smaller than page_mkclean, but the kernel > is enlarged by 33 bytes due to inlining page_folio() into each caller. > This will go away once the callers are converted to use folio_mkclean(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: Vlastimil Babka