Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp4524837pxt; Wed, 11 Aug 2021 07:59:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkjRaZYi0aOUBbiXEm9b960/l+SkHUWC2RfIM//avul6N0B1WPbB/KJxBmDzdFpL2a/xjZ X-Received: by 2002:a05:6e02:12eb:: with SMTP id l11mr76325iln.118.1628693941166; Wed, 11 Aug 2021 07:59:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628693941; cv=none; d=google.com; s=arc-20160816; b=xGzSz5JjAZFBHS4R3Yx+rk6Pl50lNfo6Rbkt8OJQB4HCZ7RkJmrDG/IlvhWE8qY6Yf uBjUApIZp+z+kCirM25iiLPKYJ4L7KqkTrGrO2sS8wX68Of9PnEDG622hKG7MlrnJszp wZMXB1jpzMqHcuu8xrYhkAJ/miayHzj4diK8kTStqDt7TgeqU/DhsdioxtreQFFPv9KA 5FEkjLG6fY5fSAX8WNc8NOxJIjUyLgiBnT9dQ20+6rDo+0vaOCF6c1/Bu+jUa56jKixb NjKS5RyqWaVvtRXqQq2l05kesiQ0FClq6NubdFqrhvrQlRvhEAkYvn+bjhljRP8cpi4j LsuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sxjpe8U8+ZHfXcYWBfce/Brxk/9js2ihphx4OJMweFQ=; b=rznJvEO1fdawKzT6LXv7yA6XAEV4qS4mwTY7FlyeNwRLavgQxKhk8DtwthLABA9T71 4caqCZ1Ff/vUKAevRFevio5eP09Xzbhiu2qGUOaLU6+c1I/1TtgZRdFMTp887dS+U6h9 kxXyd2QBjKu3K7lDHaTxtpxcnkGkGAGgM2Vt3JGlKyscHiNIV+bCYpIi+z0icfqQQARj VvblhBJexDD+2v1GEH1b6PSiQRmWrshb96/xKA377iLSQ5M315l2KXECDVfXea5ZORtA rvf9O3WCqRx27ZEQNH6gJaTaH+Yf7DRKr+6Prjvx88UPcTHK9ZbGSbaNEoeK3ohYs2HI 4rNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=t9ER4x2t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k3si23418093iog.8.2021.08.11.07.58.49; Wed, 11 Aug 2021 07:59:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=t9ER4x2t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232715AbhHKO6Q (ORCPT + 99 others); Wed, 11 Aug 2021 10:58:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45248 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232540AbhHKO6P (ORCPT ); Wed, 11 Aug 2021 10:58:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=sxjpe8U8+ZHfXcYWBfce/Brxk/9js2ihphx4OJMweFQ=; b=t9ER4x2tadeKCwr5LvGzGB1eyd oWciKQAKKiAWz9ZAXpZea+XXqPvX3Y0r1TnLek/6rp76ViDg8rTeftpLprtlXKMsVxdKLR9/CtnUj Rpe18YeOPadXB5ZhcTYYg+PH9LmOgKC9kzMw7JqGn7hJOKz36F+NHmhhle6jEbKv1SFg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mDpfo-00H8L8-Nm; Wed, 11 Aug 2021 16:57:40 +0200 Date: Wed, 11 Aug 2021 16:57:40 +0200 From: Andrew Lunn To: Luo Jie Cc: agross@kernel.org, bjorn.andersson@linaro.org, davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, robert.marko@sartura.hr, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH v2 1/3] net: mdio: Add the reset function for IPQ MDIO driver Message-ID: References: <20210810133116.29463-1-luoj@codeaurora.org> <20210810133116.29463-2-luoj@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210810133116.29463-2-luoj@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + ret = clk_prepare_enable(priv->mdio_clk); > + if (ret) > + return ret; > + > + return 0; This can be simplified to just: return clk_prepare_enable(priv->mdio_clk); Andrew