Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 11 Aug 2021 16:59:21 +0200
From:   Jan Kara <jack@suse.cz>
To:     "F.A. SULAIMAN" <asha.16@itfac.mrt.ac.lk>
Cc:     jack@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix array index out of bound exception
Message-ID: <20210811145921.GG14725@quack2.suse.cz>
References: <20210811131150.20282-1-asha.16@itfac.mrt.ac.lk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210811131150.20282-1-asha.16@itfac.mrt.ac.lk>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed 11-08-21 18:41:50, F.A. SULAIMAN wrote:
> From: "F.A.Sulaiman" <asha.16@itfac.mrt.ac.lk>
> 
> Array index out of bound exception occurs when the 'part' variable is
> passed into the freeSpactTable array, this can be avoided using pointer
> arithmetic. 
> 
> Signed-off-by: F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>

I'm sorry but this doesn't even compile and the change is obviously
bogus...

								Honza

> ---
>  fs/udf/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index 2f83c1204e20..d330c7162c3a 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -2522,7 +2522,7 @@ static unsigned int udf_count_free(struct super_block *sb)
>  			sbi->s_lvid_bh->b_data;
>  		if (le32_to_cpu(lvid->numOfPartitions) > part) {
>  			accum = le32_to_cpu(
> -					lvid->freeSpaceTable[part]);
> +					(lvid->freeSpaceTable + part));
>  			if (accum == 0xFFFFFFFF)
>  				accum = 0;
>  		}
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR