Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v14 061/138] mm/migrate: Add folio_migrate_flags()
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        linux-kernel@vger.kernel.org
Cc:     linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
References: <20210715033704.692967-1-willy@infradead.org>
 <20210715033704.692967-62-willy@infradead.org>
From:   Vlastimil Babka <vbabka@suse.cz>
Message-ID: <601db7e4-eb11-d235-8362-79e204d284d8@suse.cz>
Date:   Wed, 11 Aug 2021 17:14:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210715033704.692967-62-willy@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote:
> Turn migrate_page_states() into a wrapper around folio_migrate_flags().
> Also convert two functions only called from folio_migrate_flags() to
> be folio-based.  ksm_migrate_page() becomes folio_migrate_ksm() and
> copy_page_owner() becomes folio_copy_owner().  folio_migrate_flags()
> alone shrinks by two thirds -- 1967 bytes down to 642 bytes.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

After fixing the bug below,
Acked-by: Vlastimil Babka <vbabka@suse.cz>


> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h

...

> @@ -36,10 +36,10 @@ static inline void split_page_owner(struct page *page, unsigned int nr)
>  	if (static_branch_unlikely(&page_owner_inited))
>  		__split_page_owner(page, nr);
>  }
> -static inline void copy_page_owner(struct page *oldpage, struct page *newpage)
> +static inline void folio_copy_owner(struct folio *newfolio, struct folio *old)

This changed order so that new is first.

...

> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -538,82 +538,80 @@ int migrate_huge_page_move_mapping(struct address_space *mapping,
>  }
>  
>  /*
> - * Copy the page to its new location
> + * Copy the flags and some other ancillary information
>   */
> -void migrate_page_states(struct page *newpage, struct page *page)
> +void folio_migrate_flags(struct folio *newfolio, struct folio *folio)
>  {

...

> -	copy_page_owner(page, newpage);
> +	folio_copy_owner(folio, newfolio);

This passes old first.

>  
> -	if (!PageHuge(page))
> +	if (!folio_test_hugetlb(folio))
>  		mem_cgroup_migrate(folio, newfolio);
>  }
> -EXPORT_SYMBOL(migrate_page_states);
> +EXPORT_SYMBOL(folio_migrate_flags);