Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 11 Aug 2021 18:45:55 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>, phil@philpotter.co.uk,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] staging: r8188eu: Remove wrapper around vfree
Message-ID: <YRP+wz05avsLx3EN@kroah.com>
References: <20210802192721.23110-1-Larry.Finger@lwfinger.net>
 <20210802192721.23110-3-Larry.Finger@lwfinger.net>
 <20210811154412.GA1005754@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210811154412.GA1005754@roeck-us.net>
Precedence: bulk

On Wed, Aug 11, 2021 at 08:44:12AM -0700, Guenter Roeck wrote:
> On Mon, Aug 02, 2021 at 02:27:17PM -0500, Larry Finger wrote:
> > This call is so simple that there is no need, or use, for a wrapper.
> > 
> 
> Except the wrapper was presumably there to map generic code to Linux
> code, and the patch doesn't add an include <linux/vmalloc.h> anywhere.
> This results in widespread build errrors such as
> 
> drivers/staging/r8188eu/core/rtw_mlme.c: In function '_rtw_free_mlme_priv':
> drivers/staging/r8188eu/core/rtw_mlme.c:129:17: error: implicit declaration of function 'vfree'
> 
> for all architectures where <linux/vmalloc.h> isn't included indirectly.

Has now been fixed up in my tree and will show up in the next
linux-next.

sorry about that,

greg k-h