Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp4694034pxt;
        Wed, 11 Aug 2021 11:46:22 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJw/Q0Md0VfbKNLwH0g4qhu6JWQ4emsAL1Wx7lri2lkvXFzavnMECzBGtJSCUfKhvIYMbb1G
X-Received: by 2002:a6b:f813:: with SMTP id o19mr19185ioh.49.1628707582042;
        Wed, 11 Aug 2021 11:46:22 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1628707582; cv=none;
        d=google.com; s=arc-20160816;
        b=RbZ9Jvl1lsBBpZDe6xGUo9AT9lpvtECewXVL6lFl8KEhudd4OtnzyMdNG9euBvrsP5
         JSAlvO+g6brtAMlHvHlcrkClcd1GLcos/eodhvYWZaSe88zcFqcMV/E7OUMFNxJI7JFp
         AgxjexbbnN1+wy1zlA1g5CNdYwP6i2Omi5PEvsPIWhKEADiG/HcnUaq2LBEGEjZb84Cd
         M5vIV7Olvu+3uV6dwJvP3Nul7XWxuIlJ5jeu7LHvFZOG4daJnhauyGPqKCIlQ7xO9TcA
         8bnglhYlh5wBfALqUWhYGRLBpGRJZm7KP/ewKwvKD7lN/DHguRLuAJ4J2dsZJhJizadv
         ex/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date;
        bh=tvmLgckqKWaOacUHywQu/p3EtTqQnIViRyRpm7Hhego=;
        b=Lee5H0J2TUnZp2gqigdXsEGNUVWx4Di7SpryZMBHLTkys5Oy2AVP+PzR+nA9MKXI71
         LnkIqiDdJhGqH2fSjTDg5+fPr3dLvTeuzY9471fxlKxJ6sLCuur9AMwzQVfVfXjrSgwp
         buWUx5ND8Y5QQvbrFCKpJplJFJetLHbFqQIqDbfj+asn4CdzhKwdGWNDo7geT2mcMOlX
         uzawHId7kfQHtdqqed3z0BE9Q74whK/SgFMh8i4osmSpEXz5YJwIjMZQTf1oxUF102FE
         KCChTcI5xotu6GQOijqCljplkU0Av7gawe0AtFxwOgo1bPVq2qNNBQ01zj2wfgP5b98u
         oiiQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id g1si122100ile.140.2021.08.11.11.46.09;
        Wed, 11 Aug 2021 11:46:22 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229634AbhHKSo4 (ORCPT <rfc822;list.andrew.ls@gmail.com>
        + 99 others); Wed, 11 Aug 2021 14:44:56 -0400
Received: from smtp7.emailarray.com ([65.39.216.66]:10272 "EHLO
        smtp7.emailarray.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229655AbhHKSoz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Aug 2021 14:44:55 -0400
Received: (qmail 87087 invoked by uid 89); 11 Aug 2021 18:44:27 -0000
Received: from unknown (HELO localhost) (amxlbW9uQGZsdWdzdmFtcC5jb21AMTYzLjExNC4xMzIuMQ==) (POLARISLOCAL)  
  by smtp7.emailarray.com with SMTP; 11 Aug 2021 18:44:27 -0000
Date:   Wed, 11 Aug 2021 11:44:26 -0700
From:   Jonathan Lemon <jonathan.lemon@gmail.com>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        richardcochran@gmail.com, davem@davemloft.net
Subject: Re: [PATCH -next] ptp: ocp: Fix missing pci_disable_device() on
 error in ptp_ocp_probe()
Message-ID: <20210811184426.imoyh2wa3fjetiyc@bsd-mbp.dhcp.thefacebook.com>
References: <20210810125453.2182835-1-yangyingliang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210810125453.2182835-1-yangyingliang@huawei.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 10, 2021 at 08:54:53PM +0800, Yang Yingliang wrote:
> If ptp_ocp_device_init() fails, pci_disable_device() need be
> called, fix this by using pcim_enable_device().

I just posted an alternate patch to address this.
-- 
Jonathan