Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Use GIC_SPI for intc cells
To:     Stephen Boyd <swboyd@chromium.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        Matthias Kaehlcke <mka@chromium.org>
References: <20210811181904.779316-1-swboyd@chromium.org>
From:   Alex Elder <elder@linaro.org>
Message-ID: <b504e53c-6f04-b749-ff95-d686539e9d70@linaro.org>
Date:   Wed, 11 Aug 2021 13:45:42 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210811181904.779316-1-swboyd@chromium.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/11/21 1:19 PM, Stephen Boyd wrote:
> Let's use the GIC_SPI macro instead of a plain 0 here to match other
> uses of the primary interrupt controller on sc7280.
> 
> Suggested-by: Matthias Kaehlcke <mka@chromium.org>
> Cc: Alex Elder <elder@linaro.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>

Looks good, thanks.  It's done that way for IPA on other
platforms too, or at least that's the intention...

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index f70ab3c5d08b..569802536321 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -598,8 +598,8 @@ ipa: ipa@1e40000 {
>   				    "ipa-shared",
>   				    "gsi";
>   
> -			interrupts-extended = <&intc 0 654 IRQ_TYPE_EDGE_RISING>,
> -					      <&intc 0 432 IRQ_TYPE_LEVEL_HIGH>,
> +			interrupts-extended = <&intc GIC_SPI 654 IRQ_TYPE_EDGE_RISING>,
> +					      <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>,
>   					      <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
>   					      <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>;
>   			interrupt-names = "ipa",
> 
> base-commit: 97ec669dfcfa22f8a595356ceb6ce46e7b4a82e9
>