Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 03/18] ARC: mm: move mmu/cache externs out to setup.h
To:     Mike Rapoport <rppt@kernel.org>
Cc:     linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, Anshuman Khandual <anshuman.khandual@arm.com>,
        Vineet Gupta <vgupta@kernel.com>
References: <20210811004258.138075-1-vgupta@kernel.org>
 <20210811004258.138075-4-vgupta@kernel.org> <YRNb0EbPzejXJdax@kernel.org>
From:   Vineet Gupta <vineet.gupta@linux.dev>
Message-ID: <fe3a8a38-69ef-ff4b-6e63-b110ffc188e7@linux.dev>
Date:   Wed, 11 Aug 2021 11:46:21 -0700
MIME-Version: 1.0
In-Reply-To: <YRNb0EbPzejXJdax@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hi Mike,

On 8/10/21 10:10 PM, Mike Rapoport wrote:
> Hi Vineet,
>
> On Tue, Aug 10, 2021 at 05:42:43PM -0700, Vineet Gupta wrote:
>> Signed-off-by: Vineet Gupta <vgupta@kernel.com>
> Hmm, this one seems odd. Try https://www.kernel.com/ ;-)

Oops, last minute switch to my kernel.org address - this update was not 
atomic ;-)

>> Signed-off-by: Vineet Gupta <vgupta@kernel.org>
>> ---
>>   arch/arc/include/asm/cache.h |  4 ----
>>   arch/arc/include/asm/mmu.h   |  4 ----
>>   arch/arc/include/asm/setup.h | 12 ++++++++++--
> A sentence about why these move would have been nice.

Sure
---->
"Don't pollute mmu.h and cache.h with some of ARC internal bootlog/setup 
related functions.
move them aside to setup.h"

Thx for taking the time to review !

-Vineet