Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp4701677pxt; Wed, 11 Aug 2021 12:00:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziZWYBP7cuINwNnJhErF91r21Q47JNzE2JgXNYnz64zeDY1FSrKTg3ZEaJMk9wIzJPp8aM X-Received: by 2002:a05:6e02:114e:: with SMTP id o14mr91998ill.121.1628708428523; Wed, 11 Aug 2021 12:00:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628708428; cv=none; d=google.com; s=arc-20160816; b=VUeV5s1V/KIMheq17TtyWEarG7ulerd4vDcrc7dUn0qujnz8xhCuB07UYxajfHrfgY cvTW2TRJxA5Nl/PUJG4/2UxeNEk94RnLmkYKzoOEiiVXV5F+WqwW28zFHgOv7snqzwbQ Rtgdql4n1BrB2GnUcMhPBuaaNMF+hpYt8P1X2XwhYU/NSFH6XrP8qZ/US0FbaKkUrY/i grM5Sj975Hef20IRnJw5w5WEu6Gmmmn4iZtpPU+X0NFy/Ka/QpfUv04/+lzVV/vWB1Gv S3Pdt+pGnQ3E/RWMIqsVpJyVNezT0RUcxlWe3DZI1Hom/j2AnsqDpeDDWlrbWMWjHBX6 8MtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xfa2OwnEbVFut/pIa+Pgnjs+ro+nCNRCTpvPrEKonw0=; b=JfSve12bnBRe+KA4xEhJUKx0YZWnYEkAD/SxQWktuAQeBE7y+8gK5qtI/EUb3XBDml dj0prehp353T35rtHhVQSlzbI9vJ3ux3iwiqKL6QG4RQJcD8On2IFaIhT9Q9ZryY6WEB WoIN3W5Yk3awn0Z3u5pwmJKNv9bNNeEB0fypeTa6ECyCDecgKwctqSzuZ9E7T9IrXdrK NM+/yXFaaBVtg60crcC6gLYvfc7TP3zxAoCQeGpNKT9elOlb6XRZz12EB7HxL99FdOdG 2WavB5ErFWcsBgKKzS2ws+FRnWAQw4RruP3zPBn0AWzwsIA1njVaxDKT6NTjUXMT1vI8 rPwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=Qwq1Sd5K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si118012iog.10.2021.08.11.11.59.55; Wed, 11 Aug 2021 12:00:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=Qwq1Sd5K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231534AbhHKS6d (ORCPT + 99 others); Wed, 11 Aug 2021 14:58:33 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:11230 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231366AbhHKS6L (ORCPT ); Wed, 11 Aug 2021 14:58:11 -0400 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 17BIq9wn001296; Wed, 11 Aug 2021 13:57:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=xfa2OwnEbVFut/pIa+Pgnjs+ro+nCNRCTpvPrEKonw0=; b=Qwq1Sd5Kn1JO2A1jpvQPFr+WYondFd5QtnQu+hf7wWrm/TkDW3gQtVZoYxyCyS1fF4ww AnpyWj8ph1gnj0TpTbGaYy8QYaEWBPyO6gMsqUjmPOHdF7FZhz4y7G7yYGCaWPkQfuKJ GoF2o3/6AItTYZxxbXzRYyrxZ5K/yfeYUmYvXwrB7ZpuRXNlF40VF2hNXSjA5tiYOCFD eUH48OwwaUsHLDR4tIhXDB2/ajLhPUucw9HI5iqjeOxQJVaOPuRCJGwg8YbJRYS4LtPk JoJ0i2CshlIsC3srrJoyxz+X5OK6WKZAojDXmc1kmrxjRsWuxhhmfcFXtFkaKvoI+Aqy lA== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0a-001ae601.pphosted.com with ESMTP id 3acgjkra4r-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 11 Aug 2021 13:57:32 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 11 Aug 2021 19:57:28 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2242.12 via Frontend Transport; Wed, 11 Aug 2021 19:57:28 +0100 Received: from vitaly-Inspiron-5415.ad.cirrus.com (unknown [198.90.238.180]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 3C05945D; Wed, 11 Aug 2021 18:57:28 +0000 (UTC) From: Vitaly Rodionov To: Jaroslav Kysela , Takashi Iwai CC: , , , Stefan Binding Subject: [PATCH v4 10/27] ALSA: hda/cs8409: Simplify CS42L42 jack detect. Date: Wed, 11 Aug 2021 19:56:37 +0100 Message-ID: <20210811185654.6837-11-vitalyr@opensource.cirrus.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210811185654.6837-1-vitalyr@opensource.cirrus.com> References: <20210811185654.6837-1-vitalyr@opensource.cirrus.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: Z5XOP0KlYAmBuWC9Y7qPYm_aEglonpyG X-Proofpoint-ORIG-GUID: Z5XOP0KlYAmBuWC9Y7qPYm_aEglonpyG X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 impostorscore=0 mlxlogscore=816 suspectscore=0 phishscore=0 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108110130 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Binding Cleanup interrupt masks. Remove unnecessary read/writes. Ensure Tip Sense/Type Detection interrupts are enabled/disabled when needed. Signed-off-by: Stefan Binding Signed-off-by: Vitaly Rodionov --- Changes in v2: - No changes Changes in v3: - No changes Changes in v4: - No changes sound/pci/hda/patch_cs8409.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/sound/pci/hda/patch_cs8409.c b/sound/pci/hda/patch_cs8409.c index f4401c1e8572..4ad832f5c4ba 100644 --- a/sound/pci/hda/patch_cs8409.c +++ b/sound/pci/hda/patch_cs8409.c @@ -406,10 +406,8 @@ static void cs8409_cs42l42_enable_jack_detect(struct hda_codec *codec) cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1b71, 0x00C0, 1); /* Clear interrupts status */ cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x130f, 1); - cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1b7b, 1); /* Enable interrupt */ - cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1320, 0x03, 1); - cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1b79, 0x00, 1); + cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1320, 0xF3, 1); mutex_unlock(&spec->cs8409_i2c_mux); } @@ -424,11 +422,13 @@ static void cs8409_cs42l42_run_jack_detect(struct hda_codec *codec) /* Clear interrupts */ cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1308, 1); cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1b77, 1); + cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1320, 0xFF, 1); + cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x130f, 1); cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1102, 0x87, 1); cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1f06, 0x86, 1); cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1b74, 0x07, 1); - cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x131b, 0x01, 1); + cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x131b, 0xFD, 1); cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1120, 0x80, 1); /* Wait ~110ms*/ usleep_range(110000, 200000); @@ -487,9 +487,6 @@ static void cs8409_jack_unsol_event(struct hda_codec *codec, unsigned int res) reg_hs_status = cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1124, 1); reg_ts_status = cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x130f, 1); - /* Clear interrupts, by reading interrupt status registers */ - cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1b7b, 1); - mutex_unlock(&spec->cs8409_i2c_mux); /* If status values are < 0, read error has occurred. */ @@ -499,6 +496,11 @@ static void cs8409_jack_unsol_event(struct hda_codec *codec, unsigned int res) /* HSDET_AUTO_DONE */ if (reg_cdc_status & CS42L42_HSDET_AUTO_DONE) { + mutex_lock(&spec->cs8409_i2c_mux); + /* Disable HSDET_AUTO_DONE */ + cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x131b, 0xFF, 1); + mutex_unlock(&spec->cs8409_i2c_mux); + type = ((reg_hs_status & CS42L42_HSTYPE_MASK) + 1); /* CS42L42 reports optical jack as type 4 * We don't handle optical jack @@ -521,6 +523,11 @@ static void cs8409_jack_unsol_event(struct hda_codec *codec, unsigned int res) } } + mutex_lock(&spec->cs8409_i2c_mux); + /* Re-Enable Tip Sense Interrupt */ + cs8409_i2c_write(codec, CS42L42_I2C_ADDR, 0x1320, 0xF3, 1); + mutex_unlock(&spec->cs8409_i2c_mux); + } else { /* TIP_SENSE INSERT/REMOVE */ switch (reg_ts_status) { -- 2.25.1