Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 11 Aug 2021 15:31:32 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Steen Hegelund <steen.hegelund@microchip.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        <UNGLinuxDriver@microchip.com>, <netdev@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH net-next 1/2] net: sparx5: switchdev: adding frame DMA
 functionality
Message-ID: <20210811153132.63480934@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210811075909.543633-2-steen.hegelund@microchip.com>
References: <20210811075909.543633-1-steen.hegelund@microchip.com>
        <20210811075909.543633-2-steen.hegelund@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 11 Aug 2021 09:59:08 +0200 Steen Hegelund wrote:
> This add frame DMA functionality to the Sparx5 platform.
>=20
> Ethernet frames can be extracted or injected autonomously to or from the
> device=E2=80=99s DDR3/DDR3L memory and/or PCIe memory space. Linked list =
data
> structures in memory are used for injecting or extracting Ethernet frames.
> The FDMA generates interrupts when frame extraction or injection is done
> and when the linked lists need updating.

Something to fix:

drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c: In function =E2=80=98s=
parx5_fdma_start=E2=80=99:
drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c:544:6: warning: variabl=
e =E2=80=98proc_ctrl=E2=80=99 set but not used [-Wunused-but-set-variable]
  544 |  u32 proc_ctrl;
      |      ^~~~~~~~~